fix: VCertTknClient SDK methods are working again

The VCertTknClient SDK methods left to work since the releases v.0.9.0
until v0.9.2 given a mistake which caused the endpoints used in the
background were the specific endpoints declared for the VCertClient.

Also it was created a bunch of tests to test the VCertTknClient SDK
methods in order to confirm they are working correctly.

Resolves: #115

Author: marcos-albornoz

src/main/java/com/venafi/vcert/sdk/VCertTknClient.java

@@ -7,7 +7,7 @@
 import com.venafi.vcert.sdk.connectors.Connector;
 import com.venafi.vcert.sdk.connectors.TokenConnector;
 import com.venafi.vcert.sdk.connectors.tpp.TokenInfo;
-import com.venafi.vcert.sdk.connectors.tpp.Tpp;
+import com.venafi.vcert.sdk.connectors.tpp.TppToken;
 import com.venafi.vcert.sdk.connectors.tpp.TppTokenConnector;
 import com.venafi.vcert.sdk.endpoint.Authentication;
 
@@ -22,7 +22,7 @@ protected Connector createConnector(Config config) throws VCertException {
     	Connector connector;
     	switch (config.connectorType()) {
     	case TPP_TOKEN:{
-    		connector = new TppTokenConnector(Tpp.connect(config));
+    		connector = new TppTokenConnector(TppToken.connect(config));
     		break;
     	}
     	default:

src/main/java/com/venafi/vcert/sdk/connectors/cloud/CloudConnector.java

@@ -703,7 +703,7 @@ public static class ApiClientInformation{
   public static class CsrAttributes {
 	  private String commonName;
 	  private String organization;
-	  private String[] organizationalUnits;
+	  //private String[] organizationalUnits;
 	  private String locality;
 	  private String state;
 	  private String country;

src/main/java/com/venafi/vcert/sdk/connectors/cloud/CloudConnectorUtils.java

@@ -388,7 +388,7 @@ public static CsrAttributes buildCsrAttributes(CertificateRequest request, Polic
   	  }
 
   	  //computing the organizational Units
-  	  List<String> reqOrgUnits = Optional.ofNullable(request).map(req -> req.subject()).map(s -> s.organizationalUnit()).orElse(null);
+  	  /*List<String> reqOrgUnits = Optional.ofNullable(request).map(req -> req.subject()).map(s -> s.organizationalUnit()).orElse(null);
 
   	  if( reqOrgUnits!=null && reqOrgUnits.size() > 0) {
   		  String[] reqOrgUnitsArray = reqOrgUnits.toArray(new String[0]);
@@ -405,7 +405,7 @@ public static CsrAttributes buildCsrAttributes(CertificateRequest request, Polic
 
   		  if(defaultOrgUnits!=null && defaultOrgUnits.length>0)
   			  csrAttributes.organizationalUnits(defaultOrgUnits);
-  	  }
+  	  }*/
 
   	  //computing the localities
   	  List<String> reqLocalities = Optional.ofNullable(request).map(req -> req.subject()).map(s -> s.locality()).orElse(null);

src/main/java/com/venafi/vcert/sdk/connectors/tpp/TppConnector.java

@@ -169,7 +169,7 @@ public ZoneConfiguration readZoneConfiguration(String zone) throws VCertExceptio
     Policy policy = serverPolicy.toPolicy();
     ZoneConfiguration zoneConfig = serverPolicy.toZoneConfig();
     zoneConfig.policy(policy);
-    zoneConfig.zoneId(zone);
+    zoneConfig.zoneId(getPolicyDN(zone));
     return zoneConfig;
   }
 

src/test/java/com/venafi/vcert/sdk/VCertTknClientTest.java

@@ -1,5 +1,8 @@
 package com.venafi.vcert.sdk;
 
+import com.venafi.vcert.sdk.Config;
+import com.venafi.vcert.sdk.VCertException;
+import com.venafi.vcert.sdk.VCertTknClient;
 import com.venafi.vcert.sdk.certificate.CertificateRequest;
 import com.venafi.vcert.sdk.certificate.ImportRequest;
 import com.venafi.vcert.sdk.certificate.RenewalRequest;

src/test/java/com/venafi/vcert/sdk/connectors/tpp/TppConnectorATForSSH.java

@@ -24,6 +24,7 @@
 import com.venafi.vcert.sdk.certificate.SshCertificateRequest;
 import com.venafi.vcert.sdk.certificate.SshConfig;
 import com.venafi.vcert.sdk.endpoint.Authentication;
+import com.venafi.vcert.sdk.utils.TppTestUtils;
 
 class TppConnectorATForSSH {
 

src/test/java/com/venafi/vcert/sdk/connectors/tpp/TppTokenConnectorAT.java

@@ -29,6 +29,7 @@
 import com.venafi.vcert.sdk.connectors.ZoneConfiguration;
 import com.venafi.vcert.sdk.endpoint.Authentication;
 import com.venafi.vcert.sdk.policy.domain.PolicySpecification;
+import com.venafi.vcert.sdk.utils.TppTestUtils;
 
 import feign.FeignException;
 import feign.FeignException.BadRequest;

src/test/java/com/venafi/vcert/sdk/connectors/tpp/TppTokenConnectorATForSSH.java

@@ -25,6 +25,7 @@
 import com.venafi.vcert.sdk.certificate.SshCertificateRequest;
 import com.venafi.vcert.sdk.certificate.SshConfig;
 import com.venafi.vcert.sdk.endpoint.Authentication;
+import com.venafi.vcert.sdk.utils.TppTestUtils;
 
 class TppTokenConnectorATForSSH {
 

src/test/java/com/venafi/vcert/sdk/connectors/tpp/TppTokenConnectorPolicyAT.java

@@ -7,6 +7,8 @@
 import com.venafi.vcert.sdk.connectors.tpp.endpoint.ValidateIdentityRequest;
 import com.venafi.vcert.sdk.connectors.tpp.endpoint.ValidateIdentityResponse;
 import com.venafi.vcert.sdk.policy.domain.PolicySpecification;
+import com.venafi.vcert.sdk.utils.TppTestUtils;
+
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.DisplayName;
 import org.junit.jupiter.api.Test;

src/test/java/com/venafi/vcert/sdk/connectors/tpp/TppTokenConnectorTest.java

@@ -16,6 +16,8 @@
 import com.venafi.vcert.sdk.policy.converter.tpp.TPPPolicySpecificationValidator;
 import com.venafi.vcert.sdk.policy.domain.PolicySpecification;
 import com.venafi.vcert.sdk.policy.domain.PolicySpecificationConst;
+import com.venafi.vcert.sdk.utils.TppTestUtils;
+
 import feign.FeignException;
 import feign.Request;
 import feign.Response;