Fixing the security hotsposts reported in SonarCloud analysis

Author: marcos-albornoz

src/main/java/com/venafi/vcert/sdk/connectors/ConnectorException.java

@@ -438,5 +438,14 @@ public PickupIdOrThumbprintNotSetToGetCertIdException() {
 					+ "in the CertificateRequest to determine the certificate Id.");
 		}
 	}
+	
+	public static class ClientIdentifierException extends ConnectorException {
+		
+		private static final long serialVersionUID = 1L;
+		
+		public ClientIdentifierException(Exception e) {
+			super("It wasn't possible to determine the Client Identifier", e);
+		}
+	}
 
 }

src/main/java/com/venafi/vcert/sdk/connectors/cloud/CloudConnector.java

@@ -397,7 +397,6 @@ private PEMCollection retrieveCertificateAsPemCollectionFromCSRProvided(Certific
 		  try {
 			  TimeUnit.SECONDS.sleep(2);
 		  } catch (InterruptedException e) {
-			  e.printStackTrace();
 			  throw new AttemptToRetryException(e);
 		  }
 	  }

src/main/java/com/venafi/vcert/sdk/connectors/tpp/AbstractTppConnector.java

@@ -172,7 +172,6 @@ protected SshCertRetrieveDetails retrieveTppSshCertificate(SshCertificateRequest
             try {
                 TimeUnit.SECONDS.sleep(2);
             } catch (InterruptedException e) {
-                e.printStackTrace();
                 throw new AttemptToRetryException(e);
             }
         }

src/main/java/com/venafi/vcert/sdk/connectors/tpp/TppConnector.java

@@ -345,7 +345,6 @@ public PEMCollection retrieveCertificate(CertificateRequest request) throws VCer
       try {
         TimeUnit.SECONDS.sleep(2);
       } catch (InterruptedException e) {
-        e.printStackTrace();
         throw new AttemptToRetryException(e);
       }
     }

src/main/java/com/venafi/vcert/sdk/connectors/tpp/TppTokenConnector.java

@@ -410,7 +410,6 @@ public PEMCollection retrieveCertificate(CertificateRequest request) throws VCer
             try {
                 TimeUnit.SECONDS.sleep(2);
             } catch (InterruptedException e) {
-                e.printStackTrace();
                 throw new AttemptToRetryException(e);
             }
         }

src/main/java/com/venafi/vcert/sdk/utils/VCertUtils.java

@@ -12,6 +12,7 @@
 import com.venafi.vcert.sdk.certificate.CertificateRequest;
 import com.venafi.vcert.sdk.connectors.tpp.AbstractTppConnector.CertificateRequestsPayload;
 import com.venafi.vcert.sdk.connectors.tpp.AbstractTppConnector.NameValuePair;
+import com.venafi.vcert.sdk.connectors.ConnectorException.ClientIdentifierException;
 import com.venafi.vcert.sdk.connectors.cloud.CloudConnector.ApiClientInformation;
 import com.venafi.vcert.sdk.connectors.tpp.CustomFieldRequest;
 
@@ -125,15 +126,15 @@ public static String getIpAddress() throws UnknownHostException {
 
 	}
 
-	public static void addApiClientInformation(com.venafi.vcert.sdk.connectors.cloud.CloudConnector.CertificateRequestsPayload payload ) {
+	public static void addApiClientInformation(com.venafi.vcert.sdk.connectors.cloud.CloudConnector.CertificateRequestsPayload payload ) throws ClientIdentifierException {
 		//add client information
 		ApiClientInformation clientInfo = new ApiClientInformation();
 		clientInfo.type(VCertConstants.DEFAULT_VENDOR_AND_PRODUCT_NAME );
 
 		try {
 			clientInfo.identifier(VCertUtils.getIpAddress());
 		} catch (UnknownHostException e) {
-			e.printStackTrace();
+			throw new ClientIdentifierException( e);
 		}
 
 		payload.apiClientInformation(clientInfo);