Fix Linter Messages

Author: Anton Schulte

vunit/library.py

@@ -11,13 +11,12 @@
 """
 
 import logging
-from typing import cast
+from typing import cast, TYPE_CHECKING
 from vunit.design_unit import Entity, VHDLDesignUnit
-from typing import TYPE_CHECKING
+from vunit.vhdl_standard import VHDLStandard
 
 if TYPE_CHECKING:
     from vunit.source_file import SourceFile, VHDLSourceFile, VerilogSourceFile
-from vunit.vhdl_standard import VHDLStandard
 
 LOGGER = logging.getLogger(__name__)
 

vunit/project.py

@@ -515,7 +515,9 @@ def _get_files_to_recompile(self, files, dependency_graph, incremental):
                 result_list.append(source_file)
         return result_list
 
-    def get_dependencies_in_compile_order(self, target_files=None, implementation_dependencies=False) -> list[SourceFile]:
+    def get_dependencies_in_compile_order(
+        self, target_files=None, implementation_dependencies=False
+    ) -> list[SourceFile]:
         """
         Get a list of dependencies of target files including the
         target files.

vunit/sim_if/__init__.py

@@ -186,7 +186,7 @@ def supports_coverage():
         """
         return False
 
-    def merge_coverage(self, file_name, args):  # pylint: disable=unused-argument
+    def merge_coverage(self, file_name, args):  # pylint: disable=unused-argument,no-self-use
         """
         Hook for simulator interface to creating coverage reports
         """

vunit/source_file.py

@@ -120,7 +120,7 @@ def content_hash(self):
         return hash_string(self._content_hash + self._compile_options_hash())
 
     def add_to_library(self, library: Library):
-        raise NotImplemented
+        raise NotImplementedError
 
 
 class VerilogSourceFile(SourceFile):

vunit/ui/__init__.py

@@ -17,7 +17,7 @@
 import logging
 import json
 import os
-from typing import Any, Callable, Literal, Optional, Set, Union, cast
+from typing import Any, Callable, Literal, Optional, Set, Union, cast, TYPE_CHECKING
 from pathlib import Path
 from fnmatch import fnmatch
 from vunit.test.list import TestList
@@ -47,7 +47,6 @@
 from .library import Library, LibraryList
 from .results import Results
 
-from typing import TYPE_CHECKING
 
 if TYPE_CHECKING:
     from vunit.source_file import SourceFile as Source_File

vunit/ui/common.py

@@ -12,10 +12,8 @@
 from glob import glob
 from os import environ
 from logging import getLogger
-from typing import Any, Iterable, Optional, List, TypeVar, Union
+from typing import Iterable, Optional, List, TypeVar, Union
 
-from vunit.ui.source import SourceFile
-from ..sim_if import is_string_not_iterable
 from ..vhdl_standard import VHDL, VHDLStandard
 
 LOGGER = getLogger(__name__)

vunit/ui/library.py

@@ -11,10 +11,11 @@
 from pathlib import Path
 from fnmatch import fnmatch
 from typing import Any, List, Literal, Optional, Union
-from vunit.sim_if import OptionType
+from typing import TYPE_CHECKING
 
-from vunit.test.bench_list import TestBenchList
-from vunit.ui.preprocessor import Preprocessor
+from ..sim_if import OptionType
+from ..test.bench_list import TestBenchList
+from .preprocessor import Preprocessor
 from ..vhdl_standard import VHDL, VHDLStandard
 from ..project import Project
 from ..source_file import file_type_of, FILE_TYPES, VERILOG_FILE_TYPES
@@ -24,8 +25,6 @@
 from .testbench import TestBench
 from .packagefacade import PackageFacade
 
-from typing import TYPE_CHECKING
-
 if TYPE_CHECKING:
     from vunit.ui import VUnit
 
@@ -196,7 +195,7 @@ def add_source_files(  # pylint: disable=too-many-arguments
 
         """
         return SourceFileList(
-            source_files=[
+            [
                 self.add_source_file(
                     file_name,
                     preprocessors,
@@ -362,9 +361,6 @@ class LibraryList(List[Library]):
     A list of :class:`.Library`
     """
 
-    def __init__(self, libraries: "list[Library]"):
-        list.__init__(self, libraries)
-
     def get_test_benches(self, pattern: str = "*", allow_empty: bool = False) -> list[TestBench]:
         """
         Get a list of test benches

vunit/ui/packagefacade.py

@@ -9,12 +9,11 @@
 """
 
 from pathlib import Path
-from typing import Optional, Union
+from typing import Optional, Union, TYPE_CHECKING
 from vunit.design_unit import DesignUnit
 
 from vunit.ui.source import SourceFileList
 from ..com import codec_generator
-from typing import TYPE_CHECKING
 
 if TYPE_CHECKING:
     from vunit.ui import VUnit

vunit/ui/preprocessor.py

@@ -22,7 +22,7 @@ def __init__(self, order: int = 0) -> None:
         """
         self.order = order
 
-    def run(self, code: str, file_name: str) -> str:  # pylint: disable=unused-argument
+    def run(self, code: str, file_name: str) -> str:  # pylint: disable=unused-argument,no-self-use
         """
         Preprocess code.
 

vunit/ui/results.py

@@ -9,13 +9,12 @@
 """
 
 from pathlib import Path
-from typing import Any, Dict, Optional, Union
-from typing import TYPE_CHECKING
+from typing import Any, Dict, Optional, Union, TYPE_CHECKING
+from .common import TEST_OUTPUT_PATH
 
 if TYPE_CHECKING:
     from vunit.sim_if import SimulatorInterface
     from vunit.test.report import TestReport
-from .common import TEST_OUTPUT_PATH
 
 
 class Results(object):