Skip to content

Confusion of value 99 for rule_applied #15

Description

@RosaMGini

dear @YMao-UMCU

i think there has been some confusion in the implementation of value 99 of rule_applied. in the wiki this is the dictionary

Image

and this does indeed happen in Example 3.

but i had noticed that 99 also happens in a different situation. i have implemented in Example 7 of this new branch this example of input data

Image

where we have a missing unit but no instructions on what to do with it, because LAB_unit_conversion does not have MISSING instructions

Image

so for me ground truth should be the following

Image

because no conversion is possible and the result must be discarded

however if i run the example (i have created a script to run examples and inspect the output here) i get the following

Image

which has 2 discrepancies

  • the value is assumed in cm and converted and then accepted, which is not compliant with the instructions
  • the rule_applied is 99, which is inconsistent with the dictionary above and with its correct use in Example 3

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions