Skip to content

Commit f9ff494

Browse files
unity-cchuEvergreen
authored andcommitted
Renamed provider from ShadowShape2DProvider to ShadowCaster2DProvider
1 parent 2f16715 commit f9ff494

12 files changed

Lines changed: 38 additions & 23 deletions

Packages/com.unity.render-pipelines.universal/Editor/2D/Provider2D/Shadow2DSources_PropertyDrawer.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
namespace UnityEditor.Rendering.Universal
88
{
99
[CustomPropertyDrawer(typeof(Shadow2DProviderSources))]
10-
internal class Shadow2DProviderSources_PropertyDrawer : Provider2DSources_PropertyDrawer<ShadowShape2DProvider, Shadow2DProviderSource>
10+
internal class Shadow2DProviderSources_PropertyDrawer : Provider2DSources_PropertyDrawer<ShadowCaster2DProvider, Shadow2DProviderSource>
1111
{
1212
public override int GetProviderType() { return (int)ShadowCaster2D.ShadowCastingSources.ShapeProvider; }
1313
}

Packages/com.unity.render-pipelines.universal/Editor/2D/Provider2D/ShadowShape2DProvider_SpriteSkin_PropertyDrawer.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,14 @@
77

88
namespace UnityEditor.Rendering.Universal
99
{
10-
[CustomPropertyDrawer(typeof(ShadowShape2DProvider_SpriteSkin))]
10+
[CustomPropertyDrawer(typeof(ShadowCaster2DProvider_SpriteSkin))]
1111
internal class ShadowShape2DProvider_SpriteSkin_PropertyDrawer : Provider2D_ProperyDrawer
1212
{
1313
public static string k_GPUSkinningError = "Shadow Caster 2D is not compatible with GPU skinning.";
1414

1515
public override void OnGUI(Rect position, SerializedProperty property, GUIContent label)
1616
{
17-
ShadowShape2DProvider_SpriteSkin provider = property.managedReferenceValue as ShadowShape2DProvider_SpriteSkin;
17+
ShadowCaster2DProvider_SpriteSkin provider = property.managedReferenceValue as ShadowCaster2DProvider_SpriteSkin;
1818
base.OnGUI(position, property, label);
1919

2020
if (PlayerSettings.gpuSkinning)

Packages/com.unity.render-pipelines.universal/Editor/2D/Shadows/ShadowCaster2DEditor.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ public override void OnInspectorGUI()
217217
#endif
218218

219219
ShadowCaster2D shadowCaster2D = target as ShadowCaster2D;
220-
ShadowShape2DProvider provider = m_ShadowShape2DProvider.boxedValue as ShadowShape2DProvider;
220+
ShadowCaster2DProvider provider = m_ShadowShape2DProvider.boxedValue as ShadowCaster2DProvider;
221221
if (provider != null && shadowCaster2D.shadowCastingSource == ShadowCaster2D.ShadowCastingSources.ShapeProvider)
222222
{
223223
// Draw the fold out for non

Packages/com.unity.render-pipelines.universal/Runtime/2D/Shadows/Providers/ShadowShape2DProvider.cs

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,18 +2,24 @@
22
using System.Collections;
33
using System.Collections.Generic;
44
using UnityEngine;
5+
using UnityEngine.Scripting.APIUpdating;
56

67
#if UNITY_EDITOR
78
using UnityEditor;
89
#endif
910

1011
namespace UnityEngine.Rendering.Universal
1112
{
12-
/// <summary>
13-
/// Class <c>ShadowShape2DProvider</c> has methods called by a <c>ShadowCaster2D</c> to determine if it should be listed as a Casting Option, and to provide geometry if it is the active <c>ShadowShape2DProvider</c>
14-
/// </summary>
13+
14+
[System.Obsolete("Use ShadowCaster2DProvider instead.")]
15+
public abstract class ShadowShape2DProvider : ShadowCaster2DProvider { }
16+
17+
/// <summary>
18+
/// Class <c>ShadowShape2DProvider</c> has methods called by a <c>ShadowCaster2D</c> to determine if it should be listed as a Casting Option, and to provide geometry if it is the active <c>ShadowShape2DProvider</c>
19+
/// </summary>
1520
[Serializable]
16-
public abstract class ShadowShape2DProvider : Provider2D
21+
[MovedFrom(true, "UnityEngine.Rendering.Universal", "Unity.RenderPipelines.Universal.2D.Runtime", "ShadowShape2DProvider")]
22+
public abstract class ShadowCaster2DProvider : Provider2D
1723
{
1824
/// <summary>
1925
/// Gets the name to be listed in the <c>ShadowCaster2D</c> Casting Option drop down.

Packages/com.unity.render-pipelines.universal/Runtime/2D/Shadows/Providers/ShadowShape2DProvider_Collider.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,13 @@
33
using System.Collections.Generic;
44
using System.Runtime.CompilerServices;
55
using Unity.Collections;
6+
using UnityEngine.Scripting.APIUpdating;
67

78
namespace UnityEngine.Rendering.Universal
89
{
910
[Serializable]
10-
class ShadowShape2DProvider_Collider2D : ShadowShape2DProvider
11+
[MovedFrom(true, "UnityEngine.Rendering.Universal", "Unity.RenderPipelines.Universal.2D.Runtime", "ShadowShape2DProvider_Collider2D")]
12+
class ShadowCaster2DProvider_Collider2D : ShadowCaster2DProvider
1113
{
1214
const float k_InitialTrim = 0.05f;
1315

Packages/com.unity.render-pipelines.universal/Runtime/2D/Shadows/Providers/ShadowShape2DProvider_SpriteRenderer.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,15 @@
44
using Unity.Collections;
55
using Unity.Collections.LowLevel.Unsafe;
66
using UnityEngine;
7+
using UnityEngine.Scripting.APIUpdating;
78
using UnityEngine.U2D;
89

910

1011
namespace UnityEngine.Rendering.Universal
1112
{
1213
[Serializable]
13-
class ShadowShape2DProvider_SpriteRenderer : ShadowShape2DProvider
14+
[MovedFrom(true, "UnityEngine.Rendering.Universal", "Unity.RenderPipelines.Universal.2D.Runtime", "ShadowShape2DProvider_SpriteRenderer")]
15+
class ShadowCaster2DProvider_SpriteRenderer : ShadowCaster2DProvider
1416
{
1517
const float k_InitialTrim = 0.05f;
1618

Packages/com.unity.render-pipelines.universal/Runtime/2D/Shadows/Providers/ShadowShape2DProvider_SpriteShape.cs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77
using Unity.Collections.LowLevel.Unsafe;
88
using UnityEngine.U2D;
99
using Unity.Mathematics;
10+
using UnityEngine.Scripting.APIUpdating;
11+
1012

1113
#if UNITY_EDITOR
1214
using UnityEditor;
@@ -15,7 +17,8 @@
1517
namespace UnityEngine.Rendering.Universal
1618
{
1719
[Serializable]
18-
internal class ShadowShape2DProvider_SpriteShape : ShadowShape2DProvider
20+
[MovedFrom(true, "UnityEngine.Rendering.Universal", "Unity.RenderPipelines.Universal", "ShadowShape2DProvider_SpriteShape")]
21+
internal class ShadowCaster2DProvider_SpriteShape : ShadowCaster2DProvider
1922
{
2023
const float k_InitialTrim = 0.02f;
2124

Packages/com.unity.render-pipelines.universal/Runtime/2D/Shadows/Providers/ShadowShape2DProvider_SpriteSkin.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,15 @@
55
using Unity.Collections;
66
using Unity.Collections.LowLevel.Unsafe;
77
using UnityEngine;
8+
using UnityEngine.Scripting.APIUpdating;
89
using UnityEngine.U2D;
910
using UnityEngine.U2D.Animation;
1011

1112
namespace UnityEngine.Rendering.Universal
1213
{
1314
[Serializable]
14-
class ShadowShape2DProvider_SpriteSkin : ShadowShape2DProvider
15+
[MovedFrom(true, "UnityEngine.Rendering.Universal", "Unity.RenderPipelines.Universal.2D.Runtime", "ShadowShape2DProvider_SpriteSkin")]
16+
class ShadowCaster2DProvider_SpriteSkin : ShadowCaster2DProvider
1517
{
1618
const float k_InitialTrim = 0.05f;
1719

Packages/com.unity.render-pipelines.universal/Runtime/2D/Shadows/Shadow Provider Utility/ShapeProviderUtility.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ namespace UnityEngine.Rendering.Universal
1111
{
1212
internal class ShapeProviderUtility
1313
{
14-
static public void CallOnBeforeRender(ShadowShape2DProvider shapeProvider, Component component, ShadowMesh2D shadowMesh, Bounds bounds)
14+
static public void CallOnBeforeRender(ShadowCaster2DProvider shapeProvider, Component component, ShadowMesh2D shadowMesh, Bounds bounds)
1515
{
1616
if (component != null)
1717
{
@@ -24,7 +24,7 @@ static public void CallOnBeforeRender(ShadowShape2DProvider shapeProvider, Compo
2424
}
2525
}
2626

27-
static public void PersistantDataCreated(ShadowShape2DProvider shapeProvider, Component component, ShadowMesh2D shadowMesh)
27+
static public void PersistantDataCreated(ShadowCaster2DProvider shapeProvider, Component component, ShadowMesh2D shadowMesh)
2828
{
2929
if (component != null)
3030
{
@@ -34,20 +34,20 @@ static public void PersistantDataCreated(ShadowShape2DProvider shapeProvider, Co
3434
}
3535

3636
#if UNITY_EDITOR
37-
static public void TryGetDefaultShadowShapeProviderSource(GameObject go, out Component outSource, out ShadowShape2DProvider outProvider)
37+
static public void TryGetDefaultShadowShapeProviderSource(GameObject go, out Component outSource, out ShadowCaster2DProvider outProvider)
3838
{
3939
outSource = null;
4040
outProvider = null;
4141

4242
// Create some providers to check against.
43-
var providerTypes = TypeCache.GetTypesDerivedFrom<ShadowShape2DProvider>();
44-
var providers = new List<ShadowShape2DProvider>(providerTypes.Count);
43+
var providerTypes = TypeCache.GetTypesDerivedFrom<ShadowCaster2DProvider>();
44+
var providers = new List<ShadowCaster2DProvider>(providerTypes.Count);
4545
foreach (Type providerType in providerTypes)
4646
{
4747
if (providerType.IsAbstract)
4848
continue;
4949

50-
providers.Add(Activator.CreateInstance(providerType) as ShadowShape2DProvider);
50+
providers.Add(Activator.CreateInstance(providerType) as ShadowCaster2DProvider);
5151
}
5252

5353
// Fetch the components to check.

Packages/com.unity.render-pipelines.universal/Runtime/2D/Shadows/ShadowCaster2D.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ internal enum EdgeProcessing
9292

9393
[SerializeField] int m_InstanceId;
9494
[SerializeField] Component m_ShadowShape2DComponent;
95-
[SerializeReference] ShadowShape2DProvider m_ShadowShape2DProvider;
95+
[SerializeReference] ShadowCaster2DProvider m_ShadowShape2DProvider;
9696
[SerializeField] ShadowCastingSources m_ShadowCastingSource = (ShadowCastingSources)(-1);
9797

9898
[SerializeReference] internal ShadowMesh2D m_ShadowMesh;
@@ -158,7 +158,7 @@ public float alphaCutoff
158158

159159
// Make this public if possible...
160160
internal Component shadowShape2DComponent { get { return m_ShadowShape2DComponent; } set { m_ShadowShape2DComponent = value; } }
161-
internal ShadowShape2DProvider shadowShape2DProvider { get { return m_ShadowShape2DProvider; } set { m_ShadowShape2DProvider = value; } }
161+
internal ShadowCaster2DProvider shadowShape2DProvider { get { return m_ShadowShape2DProvider; } set { m_ShadowShape2DProvider = value; } }
162162

163163
int m_PreviousShadowGroup = 0;
164164
bool m_PreviousCastsShadows = true;

0 commit comments

Comments
 (0)