[VFX] Avoid serializing the "model" Object in VFXEditorTaskDesc

Author: ludovic-theobald

Packages/com.unity.visualeffectgraph/Editor/Data/VFXDataMesh.cs

@@ -150,7 +150,7 @@ public override void FillDescs(
                     shaderSourceIndex = -1,
                     values = mappings.ToArray(),
                     type = (UnityEngine.VFX.VFXTaskType)VFXTaskType.Output,
-                    model = context
+                    modelId = context.GetEntityId()
                 };
 
                 mappings.Clear();

Packages/com.unity.visualeffectgraph/Editor/Data/VFXDataParticle.cs

@@ -1444,7 +1444,7 @@ int GetBufferIndex(VFXTask task, string baseName)
                 taskDesc.parameters = cpuMappings.Concat(contextData.parameters).Concat(additionalParameters).ToArray();
                 taskDesc.instanceSplitIndex = AddInstanceSplitDesc(instanceSplitDescs, instancingSplitDescValues);
                 taskDesc.shaderSourceIndex = compiledData.taskToCompiledData[task].indexInShaderSource;
-                taskDesc.model = context;
+                taskDesc.modelId = context.GetEntityId();
                 taskDesc.usesMaterialVariant = compilationMode == VFXCompilationMode.Edition && context.usesMaterialVariantInEditMode;
 
                 if (context is IVFXMultiMeshOutput multiMeshOutput && multiMeshOutput.meshCount > 0) // If the context is a multi mesh output, split and patch task desc into several tasks
@@ -1477,7 +1477,7 @@ int GetBufferIndex(VFXTask task, string baseName)
                             sortTaskDesc.type = UnityEngine.VFX.VFXTaskType.PerOutputSort;
                             sortTaskDesc.processor = null;
                             sortTaskDesc.shaderSourceIndex = -1;
-                            sortTaskDesc.model = context;
+                            sortTaskDesc.modelId = context.GetEntityId();
 
                             sortTaskDesc.buffers = new VFXMapping[3];
                             sortTaskDesc.buffers[0] = new VFXMapping("srcBuffer", GetBufferIndex(task, k_IndirectBufferName) + j);

Packages/com.unity.visualeffectgraph/Editor/Models/VFXGraph.cs

@@ -12,7 +12,7 @@
 using UnityEngine;
 using UnityEngine.VFX;
 using UnityEngine.Profiling;
-
+using Object = System.Object;
 using UnityObject = UnityEngine.Object;
 
 namespace UnityEditor.VFX
@@ -1536,7 +1536,7 @@ internal UnityObject[] CompileAndUpdateAsset(VisualEffectAsset asset)
                             }
 
                             //OnSetupMaterial equivalent
-                            var model = task.model;
+                            var model = EditorUtility.EntityIdToObject(task.modelId);
                             if (model is IVFXSubRenderer subRenderer)
                             {
                                 subRenderer.SetupMaterial(writableMaterial);