[Port] [6000.3] Improve VolumeProfile inspector performance

Author: svc-reach-platform-support

Packages/com.unity.render-pipelines.core/Editor/Volume/VolumeComponentEditor.cs

@@ -428,24 +428,27 @@ public override void OnInspectorGUI()
             }
         }
 
+        GUIContent m_DisplayTitle;
         /// <summary>
         /// Sets the label for the component header. Override this method to provide
         /// a custom label. If you don't, Unity automatically obtains one from the class name.
         /// </summary>
         /// <returns>A label to display in the component header.</returns>
         public virtual GUIContent GetDisplayTitle()
         {
+            if (m_DisplayTitle != null) return m_DisplayTitle;
+
             var volumeComponentType = volumeComponent.GetType();
             var displayInfo = volumeComponentType.GetCustomAttribute<DisplayInfoAttribute>();
             if (displayInfo != null && !string.IsNullOrWhiteSpace(displayInfo.name))
-                return EditorGUIUtility.TrTextContent(displayInfo.name, string.Empty);
+                return m_DisplayTitle = EditorGUIUtility.TrTextContent(displayInfo.name, string.Empty);
 
             #pragma warning disable CS0618
             if (!string.IsNullOrWhiteSpace(volumeComponent.displayName))
-                return EditorGUIUtility.TrTextContent(volumeComponent.displayName, string.Empty);
+                return m_DisplayTitle = EditorGUIUtility.TrTextContent(volumeComponent.displayName, string.Empty);
             #pragma warning restore CS0618
 
-            return EditorGUIUtility.TrTextContent(ObjectNames.NicifyVariableName(volumeComponentType.Name) , string.Empty);
+            return m_DisplayTitle = EditorGUIUtility.TrTextContent(ObjectNames.NicifyVariableName(volumeComponentType.Name), string.Empty);
         }
 
         void AddToggleState(GUIContent content, bool state)

Packages/com.unity.render-pipelines.core/Editor/Volume/VolumeComponentListEditor.cs

@@ -155,6 +155,8 @@ void CreateEditor(VolumeComponent component, SerializedProperty property, int in
             else
                 m_Editors[index] = editor;
 
+            FilterEditorsBySearch();
+
             DocumentationUtils.TryGetHelpURL(component.GetType(), out string helpUrl);
             helpUrl ??= string.Empty;
             m_VolumeComponentHelpUrls[editor] = helpUrl;
@@ -222,9 +224,22 @@ public void Clear()
             asset = null;
         }
 
+        readonly HashSet<VolumeComponentEditor> m_CurrentSearchFilteredEditors = new();
+        void FilterEditorsBySearch()
+        {
+            m_CurrentSearchFilteredEditors.Clear();
+            if (string.IsNullOrEmpty(m_SearchString)) return;
+
+            foreach (var editor in m_Editors)
+            {
+                if (MatchesSearchString(editor.GetDisplayTitle().text))
+                    m_CurrentSearchFilteredEditors.Add(editor);
+            }
+        }
+        bool EditorIsIncludedInCurrentSearch(VolumeComponentEditor editor) => string.IsNullOrEmpty(m_SearchString) || m_CurrentSearchFilteredEditors.Contains(editor);
         bool MatchesSearchString(string title)
         {
-            return m_SearchString.Length == 0 || title.Contains(m_SearchString, StringComparison.OrdinalIgnoreCase);
+            return string.IsNullOrEmpty(m_SearchString) || title.Contains(m_SearchString, StringComparison.OrdinalIgnoreCase);
         }
 
         /// <summary>
@@ -263,7 +278,7 @@ bool ShouldDrawEditor(VolumeComponentEditor editor)
                 {
                     if (!editor.visible)
                         return false;
-                    return MatchesSearchString(editor.GetDisplayTitle().text);
+                    return EditorIsIncludedInCurrentSearch(editor);
                 }
 
                 void DrawEditor(VolumeComponentEditor editor, int index = -1)
@@ -310,7 +325,11 @@ void DrawEditor(VolumeComponentEditor editor, int index = -1)
                 {
                     Rect searchRect = GUILayoutUtility.GetRect(50, EditorGUIUtility.singleLineHeight);
                     searchRect.width -= 2;
-                    m_SearchString = m_SearchField.OnGUI(searchRect, m_SearchString);
+                    using (var check = new EditorGUI.ChangeCheckScope())
+                    {
+                        m_SearchString = m_SearchField.OnGUI(searchRect, m_SearchString);
+                        if (check.changed) FilterEditorsBySearch();
+                    }
                     GUILayout.Space(2);
 
                     EditorGUILayout.HelpBox(
@@ -346,7 +365,6 @@ void DrawEditor(VolumeComponentEditor editor, int index = -1)
 
                         for (int i = 0; i < editors.Count; i++)
                             DrawEditor(editors[i]);
-
                         GUILayout.Space(8);
                     }
                 }