Disable ProbeReferenceVolume debug code from master builds

Author: arttu-peltonen

Packages/com.unity.render-pipelines.core/Runtime/Lighting/ProbeVolume/ProbeReferenceVolume.Debug.cs

@@ -1,3 +1,7 @@
+#if DEVELOPMENT_BUILD || UNITY_EDITOR
+#define PROBEREFERENCEVOLUME_DEBUG
+#endif
+
 using System;
 using System.Collections.Generic;
 using System.Linq;
@@ -261,13 +265,15 @@ public void RenderDebug(Camera camera, Texture exposureTexture)
         /// <param name="exposureTexture">Texture containing the exposure value for this frame.</param>
         public void RenderDebug(Camera camera, ProbeVolumesOptions options, Texture exposureTexture)
         {
+#if PROBEREFERENCEVOLUME_DEBUG
             if (camera.cameraType != CameraType.Reflection && camera.cameraType != CameraType.Preview)
             {
                 if (options != null)
                     ProbeVolumeDebug.currentOffset = options.worldOffset.value;
 
                 DrawProbeDebug(camera, exposureTexture);
             }
+#endif
         }
 
         /// <summary>
@@ -360,6 +366,7 @@ static void SceneGUI(SceneView sceneView)
         }
 #endif
 
+#if PROBEREFERENCEVOLUME_DEBUG
         bool TryCreateDebugRenderData()
         {
             if (!GraphicsSettings.TryGetRenderPipelineSettings<ProbeVolumeDebugResources>(out var debugResources))
@@ -436,11 +443,6 @@ void CleanupDebug()
 #endif
         }
 
-        void DebugCellIndexChanged<T>(DebugUI.Field<T> field, T value)
-        {
-            ClearDebugData();
-        }
-
         void RegisterDebug()
         {
             void RefreshDebug<T>(DebugUI.Field<T> field, T value)
@@ -807,6 +809,8 @@ void UnregisterDebug(bool destroyPanel)
                 DebugManager.instance.GetPanel(k_DebugPanelName, false).children.Remove(m_DebugItems);
         }
 
+#endif // PROBEREFERENCEVOLUME_DEBUG
+
         class RenderFragmentationOverlayPassData
         {
             public Material debugFragmentationMaterial;
@@ -856,6 +860,7 @@ public void RenderFragmentationOverlay(RenderGraph renderGraph, TextureHandle co
             }
         }
 
+#if PROBEREFERENCEVOLUME_DEBUG
         bool ShouldCullCell(Vector3 cellPosition, Transform cameraTransform, Plane[] frustumPlanes)
         {
             var volumeAABB = GetCellBounds(cellPosition);
@@ -1082,6 +1087,7 @@ void DrawProbeDebug(Camera camera, Texture exposureTexture)
                 }
             }
         }
+#endif // PROBEREFERENCEVOLUME_DEBUG
 
         internal void ResetDebugViewToMaxSubdiv()
         {

Packages/com.unity.render-pipelines.core/Runtime/Lighting/ProbeVolume/ProbeReferenceVolume.cs

@@ -1,3 +1,7 @@
+#if DEVELOPMENT_BUILD || UNITY_EDITOR
+#define PROBEREFERENCEVOLUME_DEBUG
+#endif
+
 using System;
 using System.Diagnostics;
 using System.Collections.Generic;
@@ -1045,7 +1049,9 @@ public void Initialize(in ProbeVolumeSystemParameters parameters)
             // For now this condition is redundant with m_SupportDiskStreaming but we plan to support disk streaming without compute in the future.
             // So we need to split the conditions to plan for that.
             m_DiskStreamingUseCompute = SystemInfo.supportsComputeShaders && streamingUploadCS != null && streamingUploadL2CS != null;
+#if PROBEREFERENCEVOLUME_DEBUG
             InitializeDebug();
+#endif
             ProbeVolumeConstantRuntimeResources.Initialize();
             ProbeBrickPool.Initialize();
             ProbeBrickBlendingPool.Initialize();
@@ -1131,7 +1137,9 @@ public void Cleanup()
             }
 
             CleanupLoadedData();
+#if PROBEREFERENCEVOLUME_DEBUG
             CleanupDebug();
+#endif
             CleanupStreaming();
             DeinitProbeReferenceVolume();
             m_IsInitialized = false;
@@ -1675,13 +1683,14 @@ void InitProbeReferenceVolume()
 
                 m_NeedLoadAsset = true;
             }
-
+#if PROBEREFERENCEVOLUME_DEBUG
             // Refresh debug menu
             if (DebugManager.instance.GetPanel(k_DebugPanelName, false) != null)
             {
                 instance.UnregisterDebug(false);
                 instance.RegisterDebug();
             }
+#endif
         }
 
         ProbeReferenceVolume()