Skip to content

Commit e9d9fad

Browse files
Remove fast dynamic resolution in main branch
1 parent f23e4e3 commit e9d9fad

5 files changed

Lines changed: 7 additions & 193 deletions

File tree

src/main/java/io/github/ultimateboomer/resolutioncontrol/ResolutionControlMod.java

Lines changed: 7 additions & 59 deletions
Original file line numberDiff line numberDiff line change
@@ -106,11 +106,6 @@ public void onInitialize() {
106106
});
107107

108108
ClientTickEvents.END_CLIENT_TICK.register(client -> {
109-
// long frametime = client.metricsData.getSamples()[0];
110-
// if (frametime > 0) {
111-
// System.out.println(1_000_000_000 / frametime);
112-
// }
113-
114109
if (ConfigHandler.instance.getConfig().enableDynamicResolution && client.world != null
115110
&& getWindow().getX() != -32000) {
116111
DynamicResolutionHandler.INSTANCE.tick();
@@ -147,16 +142,6 @@ public void setShouldScale(boolean shouldScale) {
147142
);
148143
calculateSize();
149144
}
150-
151-
if (getEnableFastDynamicResolution()) {
152-
if (DynamicResolutionHandler.INSTANCE.isFramebufferMapEmpty()) {
153-
initScaledFramebuffers();
154-
155-
DynamicResolutionHandler.INSTANCE.generateFrameBuffers(
156-
getWindow().getFramebufferWidth(), getWindow().getFramebufferHeight(), scaledFramebuffers);
157-
}
158-
159-
}
160145

161146
this.shouldScale = shouldScale;
162147

@@ -244,17 +229,7 @@ private void initMinecraftFramebuffers() {
244229
}
245230

246231
public Framebuffer getFramebuffer() {
247-
if (getEnableFastDynamicResolution()) {
248-
if (DynamicResolutionHandler.INSTANCE.isFramebufferMapEmpty()) {
249-
// setFramebufferReference();
250-
DynamicResolutionHandler.INSTANCE.generateFrameBuffers(
251-
getWindow().getFramebufferWidth(), getWindow().getFramebufferHeight(), scaledFramebuffers);
252-
}
253-
254-
return DynamicResolutionHandler.INSTANCE.getCurrentFramebuffer(framebuffer);
255-
} else {
256-
return framebuffer;
257-
}
232+
return framebuffer;
258233
}
259234

260235
public void initScreenshotFramebuffer() {
@@ -388,17 +363,7 @@ public void setEnableDynamicResolution(boolean enableDynamicResolution) {
388363
}
389364
}
390365

391-
public boolean getEnableFastDynamicResolution() {
392-
return Config.getInstance().enableDynamicResolution && Config.getInstance().fastDynamicResolution;
393-
}
394-
395366
public void onResolutionChanged() {
396-
if (client.world != null && getEnableFastDynamicResolution()) {
397-
398-
DynamicResolutionHandler.INSTANCE.generateFrameBuffers(
399-
getWindow().framebufferWidth, getWindow().framebufferHeight, scaledFramebuffers);
400-
}
401-
402367
updateFramebufferSize();
403368
}
404369

@@ -413,12 +378,7 @@ public void updateFramebufferSize() {
413378

414379
public void resizeMinecraftFramebuffers() {
415380
initMinecraftFramebuffers();
416-
417-
if (getEnableFastDynamicResolution()) {
418-
} else {
419-
minecraftFramebuffers.forEach(this::resize);
420-
}
421-
381+
minecraftFramebuffers.forEach(this::resize);
422382
}
423383

424384
public void calculateSize() {
@@ -441,23 +401,11 @@ public void resize(@Nullable Framebuffer framebuffer) {
441401
MinecraftClient.IS_SYSTEM_MAC
442402
);
443403
} else {
444-
if (getEnableFastDynamicResolution()) {
445-
if (lastWidth != getWindow().framebufferWidth && lastHeight != getWindow().framebufferHeight) {
446-
framebuffer.resize(
447-
Math.max(getWindow().framebufferWidth, 1),
448-
Math.max(getWindow().framebufferHeight, 1),
449-
MinecraftClient.IS_SYSTEM_MAC
450-
);
451-
lastWidth = getWindow().framebufferWidth;
452-
lastHeight = getWindow().framebufferHeight;
453-
}
454-
} else {
455-
framebuffer.resize(
456-
getWindow().getFramebufferWidth(),
457-
getWindow().getFramebufferHeight(),
458-
MinecraftClient.IS_SYSTEM_MAC
459-
);
460-
}
404+
framebuffer.resize(
405+
getWindow().getFramebufferWidth(),
406+
getWindow().getFramebufferHeight(),
407+
MinecraftClient.IS_SYSTEM_MAC
408+
);
461409
}
462410
shouldScale = prev;
463411
}

src/main/java/io/github/ultimateboomer/resolutioncontrol/mixin/WorldRendererMixin.java

Lines changed: 0 additions & 82 deletions
This file was deleted.

src/main/java/io/github/ultimateboomer/resolutioncontrol/util/Config.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ public final class Config {
1414
public boolean screenshotFramebufferAlwaysAllocated = false;
1515

1616
public boolean enableDynamicResolution = false;
17-
public boolean fastDynamicResolution = false;
1817

1918
public float drMinScale = 0.5f;
2019
public float drMaxScale = 2.0f;

src/main/java/io/github/ultimateboomer/resolutioncontrol/util/DynamicResolutionHandler.java

Lines changed: 0 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -3,26 +3,16 @@
33
import io.github.ultimateboomer.resolutioncontrol.ResolutionControlMod;
44
import it.unimi.dsi.fastutil.floats.FloatArrayList;
55
import it.unimi.dsi.fastutil.floats.FloatList;
6-
import it.unimi.dsi.fastutil.objects.ObjectArrayList;
76
import net.minecraft.client.MinecraftClient;
8-
import net.minecraft.client.gl.Framebuffer;
9-
import net.minecraft.text.LiteralText;
10-
11-
import java.util.*;
127

138
public class DynamicResolutionHandler {
149
public static final DynamicResolutionHandler INSTANCE = new DynamicResolutionHandler();
15-
16-
private final Map<Framebuffer, List<Framebuffer>> frameBufferMap = new HashMap<>();
1710
private final FloatList scales = new FloatArrayList();
1811
private int baseScale;
1912

2013
private int timer = 10;
2114
private int currentScale;
2215

23-
private int lastWidth;
24-
private int lastHeight;
25-
2616
private DynamicResolutionHandler() {
2717
reset();
2818
}
@@ -76,50 +66,10 @@ private void setCurrentScale(int currentScale) {
7666

7767
if (!equal) {
7868
ResolutionControlMod.getInstance().updateFramebufferSize();
79-
MinecraftClient.getInstance().player.sendMessage(
80-
new LiteralText("Res: " + getCurrentScale()), false);
8169
}
8270
}
8371

8472
public double getCurrentScale() {
8573
return scales.getFloat(currentScale);
8674
}
87-
88-
public Framebuffer getCurrentFramebuffer(Framebuffer key) {
89-
List<Framebuffer> list = frameBufferMap.get(key);
90-
if (list == null) {
91-
return null;
92-
} else {
93-
return list.get(currentScale);
94-
}
95-
}
96-
97-
public void generateFrameBuffers(int baseWidth, int baseHeight, Collection<Framebuffer> fbs) {
98-
if (lastWidth != baseWidth && lastHeight != baseHeight) {
99-
frameBufferMap.forEach((framebuffer, list) -> list.forEach(Framebuffer::delete));
100-
frameBufferMap.clear();
101-
102-
fbs.forEach(framebuffer -> {
103-
System.out.println(framebuffer.textureWidth + " " + framebuffer.textureHeight);
104-
105-
List<Framebuffer> framebufferList = new ObjectArrayList<>(scales.size());
106-
for (int i = 0; i < scales.size(); i++) {
107-
float scale = scales.getFloat(i);
108-
109-
Framebuffer newFb = new Framebuffer(
110-
(int) Math.max(baseWidth * scale, 1), (int) Math.max(baseHeight * scale, 1),
111-
true, false);
112-
framebufferList.add(newFb);
113-
}
114-
frameBufferMap.put(framebuffer, framebufferList);
115-
});
116-
117-
lastWidth = baseWidth;
118-
lastHeight = baseHeight;
119-
}
120-
}
121-
122-
public boolean isFramebufferMapEmpty() {
123-
return frameBufferMap.isEmpty();
124-
}
12575
}

src/main/resources/resolutioncontrol.mixins.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
"GameRendererMixin",
1010
"MinecraftClientMixin",
1111
"WindowMixin",
12-
"WorldRendererMixin",
1312
"FramebufferMixin"
1413
],
1514
"injectors": {

0 commit comments

Comments
 (0)