Refactor token estimation and test code formatting

Replaced manual token estimation rounding with div_ceil for improved clarity and accuracy in benches and llm_response. Added #[allow(dead_code)] to test-only code to suppress warnings. Minor formatting improvements in imports and test code for readability.

Author: Tuntii

benches/toon_bench/benches/toon_bench.rs

@@ -31,7 +31,11 @@ fn create_users(count: usize) -> Vec<User> {
         .map(|i| User {
             id: i as u64,
             name: format!("User{}", i),
-            role: if i % 3 == 0 { "admin".into() } else { "user".into() },
+            role: if i % 3 == 0 {
+                "admin".into()
+            } else {
+                "user".into()
+            },
             active: i % 2 == 0,
         })
         .collect()
@@ -103,8 +107,8 @@ fn benchmark_output_size(c: &mut Criterion) {
         );
 
         // Estimate tokens (~4 chars per token)
-        let json_tokens = (json_str.len() + 3) / 4;
-        let toon_tokens = (toon_str.len() + 3) / 4;
+        let json_tokens = json_str.len().div_ceil(4);
+        let toon_tokens = toon_str.len().div_ceil(4);
         println!("JSON tokens (est): {}", json_tokens);
         println!("TOON tokens (est): {}", toon_tokens);
         println!(

crates/rustapi-core/src/error.rs

@@ -157,6 +157,7 @@ pub fn get_environment() -> Environment {
 /// Note: This only works if the environment hasn't been accessed yet.
 /// Returns `Ok(())` if successful, `Err(env)` if already set.
 #[cfg(test)]
+#[allow(dead_code)]
 pub fn set_environment_for_test(env: Environment) -> Result<(), Environment> {
     ENVIRONMENT.set(env)
 }

crates/rustapi-core/src/extract.rs

@@ -1294,6 +1294,7 @@ mod tests {
     #[test]
     fn test_extension_extractor_missing() {
         #[derive(Clone, Debug)]
+        #[allow(dead_code)]
         struct MyData(String);
 
         let request = create_test_request_with_headers(Method::GET, "/test", vec![]);

crates/rustapi-core/src/middleware/metrics.rs

@@ -363,7 +363,7 @@ mod tests {
         let response = handler();
 
         let http_response = crate::response::IntoResponse::into_response(response);
-        let body = http_response.into_body();
+        let _body = http_response.into_body();
 
         // The body should contain rustapi_info metric
         // We can't easily read the body here, but we verified the metric is registered

crates/rustapi-core/src/path_validation.rs

@@ -629,7 +629,7 @@ mod tests {
                 1 => format!("/{}//test", content), // Double slash
                 2 => format!("/{}/{{", content), // Unclosed brace
                 3 => format!("/{}/{{}}", content), // Empty parameter
-                4 => format!("/{}/{{1{content}}}", content = content), // Parameter starts with digit
+                4 => format!("/{content}/{{1{content}}}", content = content), // Parameter starts with digit
                 _ => content.clone(),
             };
 

crates/rustapi-extras/src/sqlx/mod.rs

@@ -156,7 +156,6 @@ pub fn convert_sqlx_error(err: sqlx::Error) -> ApiError {
 /// Note: This implementation is provided in rustapi-core with the `sqlx` feature flag.
 /// The extension trait `SqlxErrorExt` is provided here for convenience when you need
 /// explicit conversion control.
-
 #[cfg(test)]
 mod tests {
     use super::*;

crates/rustapi-toon/src/llm_response.rs

@@ -39,7 +39,9 @@ use bytes::Bytes;
 use http::{header, StatusCode};
 use http_body_util::Full;
 use rustapi_core::{ApiError, IntoResponse, Response};
-use rustapi_openapi::{MediaType, Operation, OperationModifier, ResponseModifier, ResponseSpec, SchemaRef};
+use rustapi_openapi::{
+    MediaType, Operation, OperationModifier, ResponseModifier, ResponseSpec, SchemaRef,
+};
 use serde::Serialize;
 use std::collections::HashMap;
 
@@ -135,7 +137,7 @@ fn estimate_tokens(text: &str) -> usize {
     // Simple heuristic: ~4 chars per token
     // Accounts for whitespace and punctuation overhead
     let char_count = text.len();
-    (char_count + 3) / 4 // Round up
+    char_count.div_ceil(4) // Round up
 }
 
 /// Calculate token savings percentage.
@@ -155,8 +157,14 @@ impl<T: Serialize> IntoResponse for LlmResponse<T> {
 
         // Calculate token counts if enabled
         let (json_tokens, toon_tokens, savings) = if self.include_token_headers {
-            let json_tokens = json_result.as_ref().map(|s| estimate_tokens(s)).unwrap_or(0);
-            let toon_tokens = toon_result.as_ref().map(|s| estimate_tokens(s)).unwrap_or(0);
+            let json_tokens = json_result
+                .as_ref()
+                .map(|s| estimate_tokens(s))
+                .unwrap_or(0);
+            let toon_tokens = toon_result
+                .as_ref()
+                .map(|s| estimate_tokens(s))
+                .unwrap_or(0);
             let savings = calculate_savings(json_tokens, toon_tokens);
             (Some(json_tokens), Some(toon_tokens), Some(savings))
         } else {
@@ -187,10 +195,13 @@ impl<T: Serialize> IntoResponse for LlmResponse<T> {
         let mut builder = http::Response::builder()
             .status(StatusCode::OK)
             .header(header::CONTENT_TYPE, content_type)
-            .header(X_FORMAT_USED, match self.format {
-                OutputFormat::Json => "json",
-                OutputFormat::Toon => "toon",
-            });
+            .header(
+                X_FORMAT_USED,
+                match self.format {
+                    OutputFormat::Json => "json",
+                    OutputFormat::Toon => "toon",
+                },
+            );
 
         // Token counting headers
         if let Some(json_tokens) = json_tokens {