Import Embark clippy lints v5 and fix all fallout (#99)

* vulkan: Hide unuszed `size` field from `MemoryBlock` outside `visualizer`

On newer Rust versions the linter now accurately detects fields that are
only used in (specific?) `derive` macros like `Debug`, but not anywhere
else in the codebase.  As such, they should still be considered unused.

* Add Embark clippy lints v5

https://github.com/EmbarkStudios/rust-ecosystem/blob/64cc11e72ff4304e6c0cd0c54dbb01c6c3f151bc/lints.toml

* Fix all clippy lints to adhere to Embark v5 lints

Author: MarijnS95

.cargo/config.toml

@@ -0,0 +1,81 @@
+[target.'cfg(all())']
+rustflags = [
+    # BEGIN - Embark standard lints v5 for Rust 1.55+
+    # do not change or add/remove here, but one can add exceptions after this section
+    # for more info see: <https://github.com/EmbarkStudios/rust-ecosystem/issues/59>
+    # "-Dunsafe_code",
+    "-Wclippy::all",
+    "-Wclippy::await_holding_lock",
+    "-Wclippy::char_lit_as_u8",
+    "-Wclippy::checked_conversions",
+    "-Wclippy::dbg_macro",
+    "-Wclippy::debug_assert_with_mut_call",
+    "-Wclippy::disallowed_method",
+    "-Wclippy::disallowed_type",
+    "-Wclippy::doc_markdown",
+    "-Wclippy::empty_enum",
+    "-Wclippy::enum_glob_use",
+    "-Wclippy::exit",
+    "-Wclippy::expl_impl_clone_on_copy",
+    "-Wclippy::explicit_deref_methods",
+    "-Wclippy::explicit_into_iter_loop",
+    "-Wclippy::fallible_impl_from",
+    "-Wclippy::filter_map_next",
+    "-Wclippy::flat_map_option",
+    "-Wclippy::float_cmp_const",
+    "-Wclippy::fn_params_excessive_bools",
+    "-Wclippy::from_iter_instead_of_collect",
+    "-Wclippy::if_let_mutex",
+    "-Wclippy::implicit_clone",
+    "-Wclippy::imprecise_flops",
+    "-Wclippy::inefficient_to_string",
+    "-Wclippy::invalid_upcast_comparisons",
+    "-Wclippy::large_digit_groups",
+    "-Wclippy::large_stack_arrays",
+    "-Wclippy::large_types_passed_by_value",
+    "-Wclippy::let_unit_value",
+    "-Wclippy::linkedlist",
+    "-Wclippy::lossy_float_literal",
+    "-Wclippy::macro_use_imports",
+    "-Wclippy::manual_ok_or",
+    "-Wclippy::map_err_ignore",
+    "-Wclippy::map_flatten",
+    "-Wclippy::map_unwrap_or",
+    "-Wclippy::match_on_vec_items",
+    "-Wclippy::match_same_arms",
+    "-Wclippy::match_wild_err_arm",
+    "-Wclippy::match_wildcard_for_single_variants",
+    "-Wclippy::mem_forget",
+    "-Wclippy::mismatched_target_os",
+    "-Wclippy::missing_enforced_import_renames",
+    "-Wclippy::mut_mut",
+    "-Wclippy::mutex_integer",
+    "-Wclippy::needless_borrow",
+    "-Wclippy::needless_continue",
+    "-Wclippy::needless_for_each",
+    "-Wclippy::option_option",
+    "-Wclippy::path_buf_push_overwrite",
+    "-Wclippy::ptr_as_ptr",
+    "-Wclippy::rc_mutex",
+    "-Wclippy::ref_option_ref",
+    "-Wclippy::rest_pat_in_fully_bound_structs",
+    "-Wclippy::same_functions_in_if_condition",
+    # "-Wclippy::semicolon_if_nothing_returned",
+    # "-Wclippy::single_match_else",
+    "-Wclippy::string_add_assign",
+    "-Wclippy::string_add",
+    "-Wclippy::string_lit_as_bytes",
+    "-Wclippy::string_to_string",
+    # "-Wclippy::todo",
+    "-Wclippy::trait_duplication_in_bounds",
+    "-Wclippy::unimplemented",
+    "-Wclippy::unnested_or_patterns",
+    "-Wclippy::unused_self",
+    "-Wclippy::useless_transmute",
+    "-Wclippy::verbose_file_reads",
+    "-Wclippy::zero_sized_map_values",
+    "-Wfuture_incompatible",
+    "-Wnonstandard_style",
+    "-Wrust_2018_idioms",
+    # END - Embark standard lints v5 for Rust 1.55+
+]

examples/d3d12-buffer/src/main.rs

@@ -1,5 +1,6 @@
 use winapi::shared::{dxgiformat, winerror};
 use winapi::um::{d3d12, d3dcommon};
+use winapi::Interface;
 
 mod all_dxgi {
     pub use winapi::shared::{dxgi1_3::*, dxgi1_6::*, dxgitype::*};
@@ -19,14 +20,14 @@ fn create_d3d12_device(
     for idx in 0.. {
         let mut adapter4: *mut all_dxgi::IDXGIAdapter4 = std::ptr::null_mut();
         let hr = unsafe {
-            dxgi_factory
-                .as_ref()
-                .unwrap()
-                .EnumAdapters1(idx, &mut adapter4 as *mut _ as *mut *mut _)
+            dxgi_factory.as_ref().unwrap().EnumAdapters1(
+                idx,
+                <*mut *mut all_dxgi::IDXGIAdapter4>::cast(&mut adapter4),
+            )
         };
 
         if hr == winerror::DXGI_ERROR_NOT_FOUND {
-            return None;
+            break;
         }
 
         assert_eq!(hr, winerror::S_OK);
@@ -59,10 +60,10 @@ fn create_d3d12_device(
                     let mut device: *mut d3d12::ID3D12Device = std::ptr::null_mut();
                     let hr = unsafe {
                         d3d12::D3D12CreateDevice(
-                            adapter4 as *mut _,
+                            adapter4.cast(),
                             feature_level,
-                            &<d3d12::ID3D12Device as winapi::Interface>::uuidof(),
-                            &mut device as *mut _ as *mut *mut _,
+                            &d3d12::ID3D12Device::uuidof(),
+                            <*mut *mut d3d12::ID3D12Device>::cast(&mut device),
                         )
                     };
                     match hr {
@@ -98,7 +99,7 @@ fn main() {
             all_dxgi::CreateDXGIFactory2(
                 0,
                 &all_dxgi::IID_IDXGIFactory6,
-                &mut dxgi_factory as *mut _ as *mut *mut _,
+                <*mut *mut all_dxgi::IDXGIFactory6>::cast(&mut dxgi_factory),
             )
         };
 
@@ -114,7 +115,7 @@ fn main() {
 
     // Setting up the allocator
     let mut allocator = Allocator::new(&AllocatorCreateDesc {
-        device: Dx12DevicePtr(device as *mut _),
+        device: Dx12DevicePtr(device.cast()),
         debug_settings: Default::default(),
     })
     .unwrap();
@@ -154,7 +155,7 @@ fn main() {
                 d3d12::D3D12_RESOURCE_STATE_COMMON,
                 std::ptr::null(),
                 &d3d12::IID_ID3D12Resource,
-                &mut resource as *mut _ as *mut _,
+                <*mut *mut d3d12::ID3D12Resource>::cast(&mut resource),
             )
         };
         if hr != winerror::S_OK {
@@ -211,7 +212,7 @@ fn main() {
                 d3d12::D3D12_RESOURCE_STATE_COMMON,
                 std::ptr::null(),
                 &d3d12::IID_ID3D12Resource,
-                &mut resource as *mut _ as *mut _,
+                <*mut *mut d3d12::ID3D12Resource>::cast(&mut resource),
             )
         };
         if hr != winerror::S_OK {
@@ -268,7 +269,7 @@ fn main() {
                 d3d12::D3D12_RESOURCE_STATE_COMMON,
                 std::ptr::null(),
                 &d3d12::IID_ID3D12Resource,
-                &mut resource as *mut _ as *mut _,
+                <*mut *mut d3d12::ID3D12Resource>::cast(&mut resource),
             )
         };
         if hr != winerror::S_OK {

examples/d3d12-visualization/src/imgui_renderer.rs

@@ -110,14 +110,14 @@ impl ImGuiRenderer {
                 Flags: D3D12_ROOT_SIGNATURE_FLAG_ALLOW_INPUT_ASSEMBLER_INPUT_LAYOUT,
             };
 
-            let mut blob = std::ptr::null_mut() as *mut ID3DBlob;
-            let mut error_blob = std::ptr::null_mut() as *mut ID3DBlob;
+            let mut blob = std::ptr::null_mut();
+            let mut error_blob = std::ptr::null_mut();
             let hr = unsafe {
                 D3D12SerializeRootSignature(
                     &rsig_desc,
                     D3D_ROOT_SIGNATURE_VERSION_1,
-                    &mut blob as *mut _ as *mut _,
-                    &mut error_blob as *mut _ as *mut _,
+                    &mut blob,
+                    &mut error_blob,
                 )
             };
             if FAILED(hr) {
@@ -137,14 +137,14 @@ impl ImGuiRenderer {
             }
 
             let blob = unsafe { blob.as_ref() }.unwrap();
-            let mut rsig = std::ptr::null_mut() as *mut ID3D12RootSignature;
+            let mut rsig = std::ptr::null_mut();
             let hr = unsafe {
                 device.CreateRootSignature(
                     0,
                     blob.GetBufferPointer(),
                     blob.GetBufferSize(),
                     &ID3D12RootSignature::uuidof(),
-                    &mut rsig as *mut _ as *mut _,
+                    <*mut *mut ID3D12RootSignature>::cast(&mut rsig),
                 )
             };
             if FAILED(hr) {
@@ -275,7 +275,7 @@ impl ImGuiRenderer {
             let hr = device.CreateGraphicsPipelineState(
                 &desc as *const _,
                 &ID3D12PipelineState::uuidof(),
-                &mut pipeline as *mut _ as *mut _,
+                <*mut *mut ID3D12PipelineState>::cast(&mut pipeline),
             );
             if FAILED(hr) {
                 panic!("Failed to create imgui pipeline.");
@@ -327,7 +327,7 @@ impl ImGuiRenderer {
                     D3D12_RESOURCE_STATE_PIXEL_SHADER_RESOURCE,
                     std::ptr::null(),
                     &ID3D12Resource::uuidof(),
-                    &mut font_image as *mut _ as *mut _,
+                    <*mut *mut ID3D12Resource>::cast(&mut font_image),
                 );
                 if FAILED(hr) {
                     panic!("Failed to create font image. hr: {:#x}", hr);
@@ -436,7 +436,7 @@ impl ImGuiRenderer {
                         D3D12_RESOURCE_STATE_GENERIC_READ,
                         std::ptr::null(),
                         &ID3D12Resource::uuidof(),
-                        &mut upload_buffer as *mut _ as *mut _,
+                        <*mut *mut ID3D12Resource>::cast(&mut upload_buffer),
                     )
                 };
 
@@ -465,7 +465,7 @@ impl ImGuiRenderer {
 
                     std::ptr::copy_nonoverlapping(
                         source_ptr,
-                        mapped_ptr as *mut u8,
+                        mapped_ptr,
                         (layout.Footprint.Width * 4) as usize,
                     );
                 }
@@ -541,7 +541,7 @@ impl ImGuiRenderer {
                     D3D12_RESOURCE_STATE_VERTEX_AND_CONSTANT_BUFFER,
                     std::ptr::null(),
                     &ID3D12Resource::uuidof(),
-                    &mut buffer as *mut _ as *mut _,
+                    <*mut *mut ID3D12Resource>::cast(&mut buffer),
                 )
             };
             if FAILED(hr) {
@@ -553,7 +553,7 @@ impl ImGuiRenderer {
                 buffer.as_ref().unwrap().Map(
                     0,
                     std::ptr::null(),
-                    &mut mapped_ptr as *mut _ as *mut _,
+                    <*mut *mut u8>::cast(&mut mapped_ptr),
                 )
             };
 
@@ -596,7 +596,7 @@ impl ImGuiRenderer {
                     D3D12_RESOURCE_STATE_VERTEX_AND_CONSTANT_BUFFER,
                     std::ptr::null(),
                     &ID3D12Resource::uuidof(),
-                    &mut buffer as *mut _ as *mut _,
+                    <*mut *mut ID3D12Resource>::cast(&mut buffer),
                 )
             };
             if FAILED(hr) {
@@ -608,7 +608,7 @@ impl ImGuiRenderer {
                 buffer.as_ref().unwrap().Map(
                     0,
                     std::ptr::null(),
-                    &mut mapped_ptr as *mut _ as *mut _,
+                    <*mut *mut u8>::cast(&mut mapped_ptr),
                 )
             };
             (buffer, allocation, mapped_ptr)
@@ -650,7 +650,7 @@ impl ImGuiRenderer {
                     D3D12_RESOURCE_STATE_INDEX_BUFFER,
                     std::ptr::null(),
                     &ID3D12Resource::uuidof(),
-                    &mut buffer as *mut _ as *mut _,
+                    <*mut *mut ID3D12Resource>::cast(&mut buffer),
                 )
             };
             if FAILED(hr) {
@@ -662,7 +662,7 @@ impl ImGuiRenderer {
                 buffer.as_ref().unwrap().Map(
                     0,
                     std::ptr::null(),
-                    &mut mapped_ptr as *mut _ as *mut _,
+                    <*mut *mut u8>::cast(&mut mapped_ptr),
                 )
             };
             (buffer, allocation, mapped_ptr)
@@ -877,7 +877,7 @@ impl ImGuiRenderer {
 pub(crate) fn handle_imgui_event(
     io: &mut imgui::Io,
     window: &winit::window::Window,
-    event: &winit::event::Event<()>,
+    event: &winit::event::Event<'_, ()>,
 ) -> bool {
     use winit::event::{
         DeviceEvent, ElementState, Event, KeyboardInput, MouseButton, MouseScrollDelta, TouchPhase,
@@ -955,7 +955,7 @@ pub(crate) fn handle_imgui_event(
                     MouseButton::Right => io.mouse_down[1] = pressed,
                     MouseButton::Middle => io.mouse_down[2] = pressed,
                     MouseButton::Other(idx @ 0..=4) => io.mouse_down[idx as usize] = pressed,
-                    _ => (),
+                    MouseButton::Other(_) => (),
                 }
 
                 io.want_capture_mouse