implemented changes suggested in code review

Author: mwhelan

NTestDataBuilder.Tests/DataSources/Dictionaries/FileDictionarySourceTests.cs

@@ -21,7 +21,7 @@ public void WhenInitializingList_ThenPassClassNameToRepositoryAsDictionaryName()
 
     public class DummySource : FileDictionarySource
     {
-        public DummySource(IDictionaryRepository repository) 
+        internal DummySource(IDictionaryRepository repository) 
             : base(Substitute.For<IGenerator>(), repository) { }
     }
 }

NTestDataBuilder.Tests/EquivalenceClasses/DictionaryEquivalenceClassesTests.cs

@@ -10,11 +10,11 @@
 
 namespace NTestDataBuilder.Tests.EquivalenceClasses
 {
-    public class PersonEquivalenceClassesTests
+    public class DictionaryEquivalenceClassesTests
     {
          public static AnonymousValueFixture Any { get; private set; }
 
-         public PersonEquivalenceClassesTests()
+         public DictionaryEquivalenceClassesTests()
         {
             Any = new AnonymousValueFixture();
         }

NTestDataBuilder/DataSources/Dictionaries/Cache.cs

@@ -1,10 +1,11 @@
-using System.Collections.Generic;
+using System.Collections.Concurrent;
+using System.Collections.Generic;
 
 namespace NTestDataBuilder.DataSources.Dictionaries
 {
     internal static class Cache
     {
-        private static IDictionary<string, IList<string>> _cache = new Dictionary<string, IList<string>>();
+        private static ConcurrentDictionary<string, IList<string>> _cache = new ConcurrentDictionary<string, IList<string>>();
 
         internal static IList<string> Get(string dictionary)
         {
@@ -23,7 +24,7 @@ public static bool Contains(string key)
 
         public static void Clear()
         {
-            _cache = new Dictionary<string, IList<string>>();
+            _cache = new ConcurrentDictionary<string, IList<string>>();
         }
     }
 }

NTestDataBuilder/DataSources/Dictionaries/CachedFileDictionaryRepository.cs

@@ -8,7 +8,7 @@ namespace NTestDataBuilder.DataSources.Dictionaries
     /// <summary>
     /// Retrieves words from dictionaries stored in files. First looks for external file that user might have created. If this does not exist then data is retrieved from embedded resource files.
     /// </summary>
-    public class CachedFileDictionaryRepository : IDictionaryRepository
+    internal class CachedFileDictionaryRepository : IDictionaryRepository
     {
         public IList<string> GetWordsFrom(string dictionary)
         {

NTestDataBuilder/DataSources/Dictionaries/FileDictionarySource.cs

@@ -15,7 +15,7 @@ protected FileDictionarySource()
             : this(new RandomGenerator(), new CachedFileDictionaryRepository()) { }
 
         /// <inheritdoc />
-        public FileDictionarySource(IGenerator generator, IDictionaryRepository repository)
+        internal FileDictionarySource(IGenerator generator, IDictionaryRepository repository)
             : base(generator)
         {
             _repository = repository;

NTestDataBuilder/DataSources/Dictionaries/IDictionaryRepository.cs

@@ -5,7 +5,7 @@ namespace NTestDataBuilder.DataSources.Dictionaries
     /// <summary>
     /// Retrieves words from specified dictionaries
     /// </summary>
-    public interface IDictionaryRepository
+    internal interface IDictionaryRepository
     {
         /// <summary>
         /// Retrieves words from specified dictionary

NTestDataBuilder/Properties/AssemblyInfo.cs

@@ -15,6 +15,7 @@
 [assembly: AssemblyCulture("")]
 
 [assembly: InternalsVisibleTo("NTestDataBuilder.Tests")]
+[assembly: InternalsVisibleTo("DynamicProxyGenAssembly2")] 
 
 // Setting ComVisible to false makes the types in this assembly not visible 
 // to COM components.  If you need to access a type in this assembly from