renamed PropertyNameGetter to Reflector to show additional behaviour

Author: mwhelan

README.md

@@ -79,6 +79,7 @@ Prior to v2.0 this library was known as NTestDataBuilder.
 		    }
 		}
 
+Note that you can optionally override the `BuildObject` method if you want full control over how your object is constructed, for example if you want to use a particular constructor. If you don't provide this then Dossier will create the object for you.
 
 3. Use the builder in a test, e.g.
 

TestStack.Dossier/AnonymousValueFixture.cs

@@ -82,7 +82,7 @@ public AnonymousValueFixture()
         /// <returns>The anonymous value, taking into account any registered conventions</returns>
         public T Get<TObject, T>(Expression<Func<TObject, T>> property)
         {
-            var propertyName = PropertyNameGetter.Get(property);
+            var propertyName = Reflector.GetPropertyFor(property);
             var valueSupplier = LocalValueSuppliers
                 .Concat(GlobalValueSuppliers)
                 .Concat(DefaultValueSuppliers)

TestStack.Dossier/PropertyNameGetter.cs

@@ -29,7 +29,7 @@ public ProxyBuilder(Dictionary<string, object> properties)
         public T Build()
         {
             var proxy = Substitute.For<T>();
-            var properties = typeof(T).GetProperties(BindingFlags.Public | BindingFlags.Instance);
+            var properties = Reflector.GetSettablePropertiesFor<T>();
             foreach (var property in properties.Where(property => _properties.ContainsKey(property.Name)))
             {
                 if (property.GetGetMethod().IsVirtual)

TestStack.Dossier/ProxyBuilder.cs

@@ -0,0 +1,30 @@
+using System;
+using System.Linq.Expressions;
+using System.Reflection;
+
+namespace TestStack.Dossier
+{
+    internal static class Reflector
+    {
+        public static string GetPropertyFor<TObject, TValue>(Expression<Func<TObject, TValue>> property)
+        {
+            var memExp = property.Body as MemberExpression;
+            if (memExp == null)
+                throw new ArgumentException(
+                    string.Format(
+                        "Given property expression ({0}) didn't specify a property on {1}",
+                        property,
+                        typeof(TObject).Name
+                    ),
+                    "property"
+                );
+
+            return memExp.Member.Name;
+        }
+
+        public static PropertyInfo[] GetSettablePropertiesFor<TObject>()
+        {
+            return typeof (TObject).GetProperties(BindingFlags.Public | BindingFlags.Instance);
+        }
+    }
+}

TestStack.Dossier/Reflector.cs

@@ -79,7 +79,7 @@ protected virtual TObject BuildObject()
         {
             var model = Any.Fixture.Create<TObject>();
 
-            var properties = typeof (TObject).GetProperties(BindingFlags.Public | BindingFlags.Instance);
+            var properties = Reflector.GetSettablePropertiesFor<TObject>();
             foreach (var property in properties)
             {
                 var val = Get(property.PropertyType, property.Name);
@@ -114,7 +114,7 @@ protected virtual void AlterProxy(TObject proxy) {}
         /// <param name="value">The value to record</param>
         public TBuilder Set<TValue>(Expression<Func<TObject, TValue>> property, TValue value)
         {
-            _properties[PropertyNameGetter.Get(property)] = value;
+            _properties[Reflector.GetPropertyFor(property)] = value;
             return this as TBuilder;
         }
 
@@ -130,7 +130,7 @@ public TValue Get<TValue>(Expression<Func<TObject, TValue>> property)
             if (!Has(property))
                 return Any.Get(property);
 
-            return (TValue)_properties[PropertyNameGetter.Get(property)];
+            return (TValue)_properties[Reflector.GetPropertyFor(property)];
         }
 
         public object Get(Type type, string propertyName)
@@ -174,7 +174,7 @@ public static ListBuilder<TObject, TBuilder> CreateListOfSize(int size)
         /// <returns>Whether or not there is a recorded value for the property</returns>
         protected bool Has<TValue>(Expression<Func<TObject, TValue>> property)
         {
-            return Has(PropertyNameGetter.Get(property));
+            return Has(Reflector.GetPropertyFor(property));
         }
 
         /// <summary>

TestStack.Dossier/TestDataBuilder.cs

@@ -87,7 +87,7 @@
     <Compile Include="Lists\ListBuilderGenerator.cs" />
     <Compile Include="Lists\ListBuilderInterceptor.cs" />
     <Compile Include="NullingExpandoObject.cs" />
-    <Compile Include="PropertyNameGetter.cs" />
+    <Compile Include="Reflector.cs" />
     <Compile Include="Suppliers\DefaultEmailValueSupplier.cs" />
     <Compile Include="Suppliers\DefaultLastNameValueSupplier.cs" />
     <Compile Include="Suppliers\DefaultFirstNameValueSupplier.cs" />