fixed #3

Removed Fail from Item description and test description

Author: kkozmic

ConventionTests/Conventions/Internal/ConventionData.cs

@@ -40,7 +40,7 @@ public ConventionData(params Type[] sourceTypes)
         /// <summary>
         ///     Descriptive text used for failure message in test. Should explan what is wrong, and how to fix it (how to make types that do not conform to the convention do so).
         /// </summary>
-        public string FailDescription { get; set; }
+        public string Description { get; set; }
 
         /// <summary>
         ///     Specifies that there are valid exceptions to the rule specified by the convention.
@@ -60,7 +60,7 @@ public ConventionData(params Type[] sourceTypes)
         /// </summary>
         public Predicate<Type> Types { get; set; }
 
-        public Func<Type, string> FailItemDescription { get; set; }
+        public Func<Type, string> ItemDescription { get; set; }
 
         /// <summary>
         ///     helper method to set <see cref="Assemblies" /> in a more convenient manner.

ConventionTests/Conventions/Internal/ConventionTest.cs

@@ -21,9 +21,9 @@ public override void Execute(IAssert assert)
                 assert.Inconclusive(
                     "No types found to apply the convention to. Make sure the Types predicate is correct and that the right assemblies to scan are specified.");
             }
-            var itemDescription = (data.FailItemDescription ?? (t => t.ToString()));
+            var itemDescription = (data.ItemDescription ?? (t => t.ToString()));
             var invalidTypes = Array.FindAll(typesToTest, t => data.Must(t) == false);
-            var message = (data.FailDescription ?? "Invalid types found") + Environment.NewLine + "\t" +
+            var message = (data.Description ?? "Invalid types found") + Environment.NewLine + "\t" +
                           string.Join(Environment.NewLine + "\t", invalidTypes.Select(itemDescription));
             if (data.HasApprovedExceptions)
             {

ConventionTests/Conventions/Internal/WindsorConventionData.cs

@@ -27,9 +27,9 @@ public IWindsorContainer Container
             get { return container; }
         }
 
-        public Func<IHandler, string> FailItemDescription { get; set; }
+        public Func<IHandler, string> ItemDescription { get; set; }
 
-        public string FailDescription { get; set; }
+        public string Description { get; set; }
 
         public bool HasApprovedExceptions { get; set; }
     }
@@ -53,11 +53,11 @@ public IWindsorContainer Container
             get { return container; }
         }
 
-        public Func<TDiagnosticData, string> FailItemDescription { get; set; }
+        public Func<TDiagnosticData, string> ItemDescription { get; set; }
 
         public Func<TDiagnosticData, bool> Must { get; set; }
 
-        public string FailDescription { get; set; }
+        public string Description { get; set; }
 
         public bool HasApprovedExceptions { get; set; }
 

ConventionTests/Conventions/Internal/WindsorConventionTest.cs

@@ -21,11 +21,11 @@ public override void Execute(IAssert assert)
         {
             var conventionData = SetUp();
             var diagnosticData = GetDataToTest(conventionData);
-            var itemDescription = (conventionData.FailItemDescription ?? (h => h.ToString() + "*"));
+            var itemDescription = (conventionData.ItemDescription ?? (h => h.ToString() + "*"));
             var invalidData = conventionData.Must == null
                                   ? diagnosticData
                                   : Array.FindAll(diagnosticData, h => conventionData.Must(h) == false);
-            var message = (conventionData.FailDescription ?? "Invalid elements found") + Environment.NewLine + "\t" +
+            var message = (conventionData.Description ?? "Invalid elements found") + Environment.NewLine + "\t" +
                           string.Join(Environment.NewLine + "\t", invalidData.Select(itemDescription));
             if (conventionData.HasApprovedExceptions)
             {
@@ -83,11 +83,11 @@ public override void Execute(IAssert assert)
                 assert.Inconclusive(
                     "No handlers found to apply the convention to. Make sure the handlesr predicate is correct and that the right components were registered in the container.");
             }
-            var itemDescription = (data.FailItemDescription ?? (h => h.GetComponentName()));
+            var itemDescription = (data.ItemDescription ?? (h => h.GetComponentName()));
             var invalidComponents = data.Must == null
                                         ? handlersToTest
                                         : Array.FindAll(handlersToTest, h => data.Must(h) == false);
-            var message = (data.FailDescription ?? "Invalid components found") + Environment.NewLine + "\t" +
+            var message = (data.Description ?? "Invalid components found") + Environment.NewLine + "\t" +
                           string.Join(Environment.NewLine + "\t", invalidComponents.Select(itemDescription));
             if (data.HasApprovedExceptions)
             {