Cleaned up logic a bit after review

Jake Ginnivan · Jake Ginnivan · commit 594ee4dcb8f6 · 2014-05-02T16:28:58.000+01:00
diff --git a/TestStack.BDDfy/Processors/TestRunner.cs b/TestStack.BDDfy/Processors/TestRunner.cs
@@ -19,7 +19,7 @@ public void Process(Story story)
                 var stepFailed = false;
                 foreach (var executionStep in scenario.Steps)
                 {
-                    if (stepFailed && (Configuration.Configurator.Processors.TestRunner.StopExecutionOnFailingThen || !executionStep.Asserts))
+                    if (stepFailed && ShouldExecuteStepWhenPreviousStepFailed(executionStep))
                         break;
 
                     if (executor.ExecuteStep(executionStep) == Result.Passed) 
@@ -38,5 +38,10 @@ public void Process(Story story)
                 }
             }
         }
+
+        private static bool ShouldExecuteStepWhenPreviousStepFailed(Step executionStep)
+        {
+            return Configuration.Configurator.Processors.TestRunner.StopExecutionOnFailingThen || !executionStep.Asserts;
+        }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ public void Process(Story story)`
`19`	`19`	`var stepFailed = false;`
`20`	`20`	`foreach (var executionStep in scenario.Steps)`
`21`	`21`	`{`
`22`		`- if (stepFailed && (Configuration.Configurator.Processors.TestRunner.StopExecutionOnFailingThen \|\| !executionStep.Asserts))`
	`22`	`+ if (stepFailed && ShouldExecuteStepWhenPreviousStepFailed(executionStep))`
`23`	`23`	`break;`
`24`	`24`
`25`	`25`	`if (executor.ExecuteStep(executionStep) == Result.Passed)`
`@@ -38,5 +38,10 @@ public void Process(Story story)`
`38`	`38`	`}`
`39`	`39`	`}`
`40`	`40`	`}`
	`41`	`+`
	`42`	`+ private static bool ShouldExecuteStepWhenPreviousStepFailed(Step executionStep)`
	`43`	`+ {`
	`44`	`+ return Configuration.Configurator.Processors.TestRunner.StopExecutionOnFailingThen \|\| !executionStep.Asserts;`
	`45`	`+ }`
`41`	`46`	`}`
`42`	`47`	`}`