Fixing review feedback

Author: Jake Ginnivan

TestStack.BDDfy.Tests/Scanner/FluentScanner/FluentWithExamples.cs

@@ -45,7 +45,7 @@ public void ExampleTypeMismatch()
                                       })
                     .BDDfy());
 
-            ex.Message.ShouldBe("Wrong type: System.Object cannot be assigned to Int32");
+            ex.Message.ShouldBe("System.Object cannot be assigned to Int32 (Column: 'Wrong type', Row: 1)");
         }
 
         private void AndIUseA(string multiWordHeading)

…rs/StepScanners/StepScannerExtensions.cs …epScanners/ArgumentCleaningExtensions.csTestStack.BDDfy/Scanners/StepScanners/StepScannerExtensions.cs renamed to TestStack.BDDfy/Scanners/StepScanners/ArgumentCleaningExtensions.cs TestStack.BDDfy/Scanners/StepScanners/StepScannerExtensions.cs renamed to TestStack.BDDfy/Scanners/StepScanners/ArgumentCleaningExtensions.cs

@@ -3,14 +3,14 @@
 
 namespace TestStack.BDDfy
 {
-    internal static class StepScannerExtensions
+    internal static class ArgumentCleaningExtensions
     {
         internal static object[] FlattenArrays(this object[] inputs)
         {
-            return inputs.Select(FlattenArrays).ToArray();
+            return inputs.Select(FlattenArray).ToArray();
         }
 
-        public static object FlattenArrays(this object input)
+        public static object FlattenArray(this object input)
         {
             var inputArray = input as Array;
             if (inputArray != null)

TestStack.BDDfy/Scanners/StepScanners/Examples/ExampleValue.cs

@@ -58,7 +58,10 @@ public object GetValue(Type targetType)
             }
             catch (InvalidCastException ex)
             {
-                throw new UnassignableExampleException(string.Format("{0}: {1} cannot be assigned to {2}", Header, _underlyingValue == null ? "<null>" : _underlyingValue.ToString(), targetType.Name), ex);
+                throw new UnassignableExampleException(string.Format(
+                    "{0} cannot be assigned to {1} (Column: '{2}', Row: {3})", 
+                    _underlyingValue == null ? "<null>" : _underlyingValue.ToString(),
+                    targetType.Name, Header, Row), ex, this);
             }
         }
 
@@ -71,7 +74,7 @@ public override string ToString()
 
         public string GetValueAsString()
         {
-            return _underlyingValue.FlattenArrays().ToString();
+            return _underlyingValue.FlattenArray().ToString();
         }
     }
 }

TestStack.BDDfy/Scanners/StepScanners/Examples/UnassignableExampleException.cs

@@ -6,22 +6,17 @@ namespace TestStack.BDDfy
     [Serializable]
     public class UnassignableExampleException : Exception
     {
-        public UnassignableExampleException()
-        {
-        }
-
-        public UnassignableExampleException(string message) : base(message)
-        {
-        }
-
-        public UnassignableExampleException(string message, Exception inner) : base(message, inner)
+        public UnassignableExampleException(string message, Exception inner, ExampleValue exampleValue) : base(message, inner)
         {
+            ExampleValue = exampleValue;
         }
 
         protected UnassignableExampleException(
             SerializationInfo info,
             StreamingContext context) : base(info, context)
         {
         }
+
+        public ExampleValue ExampleValue { get; private set; }
     }
 }

TestStack.BDDfy/TestStack.BDDfy.csproj

@@ -162,7 +162,7 @@
     <Compile Include="Scanners\StepScanners\MethodName\MethodNameMatcher.cs" />
     <Compile Include="Scanners\StepScanners\MethodName\MethodNameStepScanner.cs" />
     <Compile Include="Scanners\StepScanners\StepActionFactory.cs" />
-    <Compile Include="Scanners\StepScanners\StepScannerExtensions.cs" />
+    <Compile Include="Scanners\StepScanners\ArgumentCleaningExtensions.cs" />
     <Compile Include="Scanners\StepScanners\StepTitleException.cs" />
     <Compile Include="Scanners\StoryAttributeMetadataScanner.cs" />
     <Compile Include="StoryNarrativeAttribute.cs" />