Skip to content

Commit 0404fc1

Browse files
committed
removed IAnd... interfaces & cleaned up the implementation a bit
1 parent c2272c8 commit 0404fc1

9 files changed

Lines changed: 39 additions & 60 deletions

File tree

TestStack.BDDfy/Scanners/StepScanners/Fluent/FluentScanner.cs

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ namespace TestStack.BDDfy
3434
/// }
3535
/// </code>
3636
/// </example>
37-
internal class FluentScanner<TScenario> : IInitialStep<TScenario>, IAndGiven<TScenario>, IAndWhen<TScenario>, IAndThen<TScenario>
37+
internal class FluentScanner<TScenario> : IInitialStep<TScenario>, IGiven<TScenario>, IWhen<TScenario>, IThen<TScenario>
3838
where TScenario : class
3939
{
4040
private readonly List<Step> _steps = new List<Step>();
@@ -85,19 +85,19 @@ IThen<TScenario> IThenSteps<TScenario>.Then(Expression<Func<TScenario, Task>> th
8585
return this;
8686
}
8787

88-
IAndThen<TScenario> IThen<TScenario>.And(Expression<Func<TScenario, Task>> andThenStep, string stepTextTemplate)
88+
IThen<TScenario> IThen<TScenario>.And(Expression<Func<TScenario, Task>> andThenStep, string stepTextTemplate)
8989
{
9090
AddStep(andThenStep, stepTextTemplate, true, ExecutionOrder.ConsecutiveAssertion);
9191
return this;
9292
}
9393

94-
IAndThen<TScenario> IThen<TScenario>.And(Expression<Func<TScenario, Task>> andThenStep, bool includeInputsInStepTitle)
94+
IThen<TScenario> IThen<TScenario>.And(Expression<Func<TScenario, Task>> andThenStep, bool includeInputsInStepTitle)
9595
{
9696
AddStep(andThenStep, null, true, ExecutionOrder.ConsecutiveAssertion, includeInputsInStepTitle: includeInputsInStepTitle);
9797
return this;
9898
}
9999

100-
IAndWhen<TScenario> IWhen<TScenario>.And(Expression<Func<TScenario, Task>> andWhenStep, bool includeInputsInStepTitle)
100+
IWhen<TScenario> IWhen<TScenario>.And(Expression<Func<TScenario, Task>> andWhenStep, bool includeInputsInStepTitle)
101101
{
102102
AddStep(andWhenStep, null, false, ExecutionOrder.ConsecutiveTransition, includeInputsInStepTitle: includeInputsInStepTitle);
103103
return this;
@@ -109,19 +109,19 @@ IThen<TScenario> IThenSteps<TScenario>.Then(Expression<Func<TScenario, Task>> th
109109
return this;
110110
}
111111

112-
IAndGiven<TScenario> IGiven<TScenario>.And(Expression<Func<TScenario, Task>> andGivenStep, bool includeInputsInStepTitle)
112+
IGiven<TScenario> IGiven<TScenario>.And(Expression<Func<TScenario, Task>> andGivenStep, bool includeInputsInStepTitle)
113113
{
114114
AddStep(andGivenStep, null, false, ExecutionOrder.ConsecutiveSetupState, includeInputsInStepTitle: includeInputsInStepTitle);
115115
return this;
116116
}
117117

118-
IAndGiven<TScenario> IGiven<TScenario>.And(Expression<Func<TScenario, Task>> andGivenStep, string stepTextTemplate)
118+
IGiven<TScenario> IGiven<TScenario>.And(Expression<Func<TScenario, Task>> andGivenStep, string stepTextTemplate)
119119
{
120120
AddStep(andGivenStep, stepTextTemplate, false, ExecutionOrder.ConsecutiveSetupState);
121121
return this;
122122
}
123123

124-
IAndWhen<TScenario> IWhen<TScenario>.And(Expression<Func<TScenario, Task>> andWhenStep, string stepTextTemplate)
124+
IWhen<TScenario> IWhen<TScenario>.And(Expression<Func<TScenario, Task>> andWhenStep, string stepTextTemplate)
125125
{
126126
AddStep(andWhenStep, stepTextTemplate, false, ExecutionOrder.ConsecutiveTransition);
127127
return this;
@@ -242,7 +242,7 @@ IWhen<TScenario> IWhenSteps<TScenario>.When(Expression<Action<TScenario>> whenSt
242242
return this;
243243
}
244244

245-
IAndGiven<TScenario> IGiven<TScenario>.And(Expression<Action<TScenario>> andGivenStep, bool includeInputsInStepTitle)
245+
IGiven<TScenario> IGiven<TScenario>.And(Expression<Action<TScenario>> andGivenStep, bool includeInputsInStepTitle)
246246
{
247247
AddStep(andGivenStep, null, false, ExecutionOrder.ConsecutiveSetupState, includeInputsInStepTitle: includeInputsInStepTitle);
248248
return this;
@@ -254,31 +254,31 @@ IThen<TScenario> IThenSteps<TScenario>.Then(Expression<Action<TScenario>> thenSt
254254
return this;
255255
}
256256

257-
IAndWhen<TScenario> IWhen<TScenario>.And(Expression<Action<TScenario>> andWhenStep, bool includeInputsInStepTitle)
257+
IWhen<TScenario> IWhen<TScenario>.And(Expression<Action<TScenario>> andWhenStep, bool includeInputsInStepTitle)
258258
{
259259
AddStep(andWhenStep, null, false, ExecutionOrder.ConsecutiveTransition, includeInputsInStepTitle: includeInputsInStepTitle);
260260
return this;
261261
}
262262

263-
IAndGiven<TScenario> IGiven<TScenario>.And(Expression<Action<TScenario>> andGivenStep, string stepTextTemplate)
263+
IGiven<TScenario> IGiven<TScenario>.And(Expression<Action<TScenario>> andGivenStep, string stepTextTemplate)
264264
{
265265
AddStep(andGivenStep, stepTextTemplate, false, ExecutionOrder.ConsecutiveSetupState);
266266
return this;
267267
}
268268

269-
IAndGiven<TScenario> IGiven<TScenario>.And(Action andGivenStep, string title)
269+
IGiven<TScenario> IGiven<TScenario>.And(Action andGivenStep, string title)
270270
{
271271
AddStep(andGivenStep, title, false, ExecutionOrder.ConsecutiveSetupState);
272272
return this;
273273
}
274274

275-
IAndGiven<TScenario> IGiven<TScenario>.And(string title)
275+
IGiven<TScenario> IGiven<TScenario>.And(string title)
276276
{
277277
AddStep(() => {}, title, false, ExecutionOrder.ConsecutiveSetupState);
278278
return this;
279279
}
280280

281-
IAndThen<TScenario> IThen<TScenario>.And(Expression<Action<TScenario>> andThenStep, bool includeInputsInStepTitle)
281+
IThen<TScenario> IThen<TScenario>.And(Expression<Action<TScenario>> andThenStep, bool includeInputsInStepTitle)
282282
{
283283
AddStep(andThenStep, null, true, ExecutionOrder.ConsecutiveAssertion, includeInputsInStepTitle: includeInputsInStepTitle);
284284
return this;
@@ -302,37 +302,37 @@ IThen<TScenario> IThenSteps<TScenario>.Then(string title)
302302
return this;
303303
}
304304

305-
IAndWhen<TScenario> IWhen<TScenario>.And(Expression<Action<TScenario>> andWhenStep, string stepTextTemplate)
305+
IWhen<TScenario> IWhen<TScenario>.And(Expression<Action<TScenario>> andWhenStep, string stepTextTemplate)
306306
{
307307
AddStep(andWhenStep, stepTextTemplate, false, ExecutionOrder.ConsecutiveTransition);
308308
return this;
309309
}
310310

311-
IAndThen<TScenario> IThen<TScenario>.And(Expression<Action<TScenario>> andThenStep, string stepTextTemplate)
311+
IThen<TScenario> IThen<TScenario>.And(Expression<Action<TScenario>> andThenStep, string stepTextTemplate)
312312
{
313313
AddStep(andThenStep, stepTextTemplate, true, ExecutionOrder.ConsecutiveAssertion);
314314
return this;
315315
}
316316

317-
IAndWhen<TScenario> IWhen<TScenario>.And(Action andWhenStep, string title)
317+
IWhen<TScenario> IWhen<TScenario>.And(Action andWhenStep, string title)
318318
{
319319
AddStep(andWhenStep, title, false, ExecutionOrder.ConsecutiveTransition);
320320
return this;
321321
}
322322

323-
IAndWhen<TScenario> IWhen<TScenario>.And(string title)
323+
IWhen<TScenario> IWhen<TScenario>.And(string title)
324324
{
325325
AddStep(() => { }, title, false, ExecutionOrder.ConsecutiveTransition);
326326
return this;
327327
}
328328

329-
IAndThen<TScenario> IThen<TScenario>.And(Action andThenStep, string title)
329+
IThen<TScenario> IThen<TScenario>.And(Action andThenStep, string title)
330330
{
331331
AddStep(andThenStep, title, true, ExecutionOrder.ConsecutiveAssertion);
332332
return this;
333333
}
334334

335-
IAndThen<TScenario> IThen<TScenario>.And(string title)
335+
IThen<TScenario> IThen<TScenario>.And(string title)
336336
{
337337
AddStep(() => { }, title, true, ExecutionOrder.ConsecutiveAssertion);
338338
return this;

TestStack.BDDfy/Scanners/StepScanners/Fluent/IAndGiven.cs

Lines changed: 0 additions & 6 deletions
This file was deleted.

TestStack.BDDfy/Scanners/StepScanners/Fluent/IAndThen.cs

Lines changed: 0 additions & 6 deletions
This file was deleted.

TestStack.BDDfy/Scanners/StepScanners/Fluent/IAndWhen.cs

Lines changed: 0 additions & 6 deletions
This file was deleted.

TestStack.BDDfy/Scanners/StepScanners/Fluent/IGiven.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,11 @@ namespace TestStack.BDDfy
66
{
77
public interface IGiven<TScenario> : IWhenSteps<TScenario>, IThenSteps<TScenario>
88
{
9-
IAndGiven<TScenario> And(Expression<Action<TScenario>> andGivenStep, bool includeInputsInStepTitle);
10-
IAndGiven<TScenario> And(Action andGivenStep, string title);
11-
IAndGiven<TScenario> And(string title);
12-
IAndGiven<TScenario> And(Expression<Action<TScenario>> andGivenStep, string stepTextTemplate = null);
13-
IAndGiven<TScenario> And(Expression<Func<TScenario, Task>> andGivenStep, string stepTextTemplate = null);
14-
IAndGiven<TScenario> And(Expression<Func<TScenario, Task>> andGivenStep, bool includeInputsInStepTitle);
9+
IGiven<TScenario> And(Expression<Action<TScenario>> andGivenStep, string stepTextTemplate = null);
10+
IGiven<TScenario> And(Expression<Action<TScenario>> andGivenStep, bool includeInputsInStepTitle);
11+
IGiven<TScenario> And(Expression<Func<TScenario, Task>> andGivenStep, string stepTextTemplate = null);
12+
IGiven<TScenario> And(Expression<Func<TScenario, Task>> andGivenStep, bool includeInputsInStepTitle);
13+
IGiven<TScenario> And(Action andGivenStep, string title);
14+
IGiven<TScenario> And(string title);
1515
}
1616
}

TestStack.BDDfy/Scanners/StepScanners/Fluent/IThen.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,11 @@ namespace TestStack.BDDfy
66
{
77
public interface IThen<TScenario> : IStepsBase<TScenario>
88
{
9-
IAndThen<TScenario> And(Expression<Action<TScenario>> andThenStep, bool includeInputsInStepTitle);
10-
IAndThen<TScenario> And(Expression<Action<TScenario>> andThenStep, string stepTextTemplate = null);
11-
IAndThen<TScenario> And(Expression<Func<TScenario, Task>> andThenStep, bool includeInputsInStepTitle);
12-
IAndThen<TScenario> And(Expression<Func<TScenario, Task>> andThenStep, string stepTextTemplate = null);
13-
IAndThen<TScenario> And(Action andThenStep, string title);
14-
IAndThen<TScenario> And(string title);
9+
IThen<TScenario> And(Expression<Action<TScenario>> andThenStep, string stepTextTemplate = null);
10+
IThen<TScenario> And(Expression<Action<TScenario>> andThenStep, bool includeInputsInStepTitle);
11+
IThen<TScenario> And(Expression<Func<TScenario, Task>> andThenStep, string stepTextTemplate = null);
12+
IThen<TScenario> And(Expression<Func<TScenario, Task>> andThenStep, bool includeInputsInStepTitle);
13+
IThen<TScenario> And(Action andThenStep, string title);
14+
IThen<TScenario> And(string title);
1515
}
1616
}

TestStack.BDDfy/Scanners/StepScanners/Fluent/IThenSteps.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@ namespace TestStack.BDDfy
66
{
77
public interface IThenSteps<TScenario>
88
{
9-
IThen<TScenario> Then(Expression<Action<TScenario>> thenStep, bool includeInputsInStepTitle);
109
IThen<TScenario> Then(Expression<Action<TScenario>> thenStep, string stepTextTemplate = null);
11-
IThen<TScenario> Then(Expression<Func<TScenario, Task>> thenStep, bool includeInputsInStepTitle);
10+
IThen<TScenario> Then(Expression<Action<TScenario>> thenStep, bool includeInputsInStepTitle);
1211
IThen<TScenario> Then(Expression<Func<TScenario, Task>> thenStep, string stepTextTemplate = null);
12+
IThen<TScenario> Then(Expression<Func<TScenario, Task>> thenStep, bool includeInputsInStepTitle);
1313
IThen<TScenario> Then(Action thenStep, string title);
1414
IThen<TScenario> Then(string title);
1515
}

TestStack.BDDfy/Scanners/StepScanners/Fluent/IWhen.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,11 @@ namespace TestStack.BDDfy
66
{
77
public interface IWhen<TScenario> : IStepsBase<TScenario>, IThenSteps<TScenario>
88
{
9-
IAndWhen<TScenario> And(Expression<Action<TScenario>> andWhenStep, bool includeInputsInStepTitle);
10-
IAndWhen<TScenario> And(Expression<Action<TScenario>> andWhenStep, string stepTextTemplate = null);
11-
IAndWhen<TScenario> And(Expression<Func<TScenario, Task>> andWhenStep, bool includeInputsInStepTitle);
12-
IAndWhen<TScenario> And(Expression<Func<TScenario, Task>> andWhenStep, string stepTextTemplate = null);
13-
IAndWhen<TScenario> And(Action andWhenStep, string title);
14-
IAndWhen<TScenario> And(string title);
9+
IWhen<TScenario> And(Expression<Action<TScenario>> andWhenStep, string stepTextTemplate = null);
10+
IWhen<TScenario> And(Expression<Action<TScenario>> andWhenStep, bool includeInputsInStepTitle);
11+
IWhen<TScenario> And(Expression<Func<TScenario, Task>> andWhenStep, string stepTextTemplate = null);
12+
IWhen<TScenario> And(Expression<Func<TScenario, Task>> andWhenStep, bool includeInputsInStepTitle);
13+
IWhen<TScenario> And(Action andWhenStep, string title);
14+
IWhen<TScenario> And(string title);
1515
}
1616
}

TestStack.BDDfy/TestStack.BDDfy.csproj

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -141,9 +141,6 @@
141141
<Compile Include="Scanners\StepScanners\Fluent\FluentScanner.cs" />
142142
<Compile Include="Scanners\StepScanners\Fluent\FluentScannerExtensions.cs" />
143143
<Compile Include="Scanners\ScenarioScanners\FluentScenarioScanner.cs" />
144-
<Compile Include="Scanners\StepScanners\Fluent\IAndGiven.cs" />
145-
<Compile Include="Scanners\StepScanners\Fluent\IAndThen.cs" />
146-
<Compile Include="Scanners\StepScanners\Fluent\IAndWhen.cs" />
147144
<Compile Include="Scanners\StepScanners\Fluent\IStepsBase.cs" />
148145
<Compile Include="Scanners\StepScanners\Fluent\IGiven.cs" />
149146
<Compile Include="Scanners\StepScanners\Fluent\IInitialStep.cs" />

0 commit comments

Comments
 (0)