Skip to content

Commit 1ffec00

Browse files
committed
making WithIssues a dataclass
1 parent 6b2ee8d commit 1ffec00

2 files changed

Lines changed: 7 additions & 2 deletions

File tree

pylasu/parsing/results.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from dataclasses import dataclass
1+
from dataclasses import dataclass, field
22
from typing import List
33

44
from antlr4 import ParserRuleContext, Token
@@ -10,11 +10,13 @@
1010
@dataclass
1111
class FirstStageResult(WithIssues):
1212
parse_tree: ParserRuleContext
13+
issues: List[Issue] = field(default_factory=list)
1314

1415

1516
@dataclass
1617
class LexingResult(WithIssues):
1718
tokens: List[Token]
19+
issues: List[Issue] = field(default_factory=list)
1820

1921

2022
@dataclass

pylasu/validation/validation.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,14 @@ def semantic(message: str, severity: IssueSeverity = IssueSeverity.ERROR, positi
3535
return Issue(IssueType.SEMANTIC, message, severity, position)
3636

3737

38+
@dataclass
3839
class WithIssues:
3940
"""Many classes have the necessity of tracking issues"""
40-
issues: List[Issue] = field(default_factory=list)
41+
issues: List[Issue]
4142

4243

4344
@dataclass
4445
class Result(WithIssues):
4546
root: Node
47+
issues: List[Issue] = field(default_factory=list)
48+

0 commit comments

Comments
 (0)