Test classes can no longer use function this

Author: DrewImm

CHANGELOG.md

@@ -5,6 +5,7 @@
 ### Additions
 
 ### Fixes
+- Test classes cannot use function `this`
 - npm update (includes audit & outdated)
 - Lint (on master)
 

test/spec/api/bodyguard/compare-id-to-user.spec.ts

@@ -6,25 +6,28 @@ import { getBodyguardKeys, compareIdToUser } from '../../../../src/bodyguard';
  * pointyapi/bodyguard
  */
 describe('[Bodyguard] compareIdToUser', () => {
+	let user;
+	let guardKeys;
+
 	beforeAll(() => {
 		// Create user
-		this.user = new ExampleUser();
-		this.user.id = 2;
+		user = new ExampleUser();
+		user.id = 2;
 
 		// Get bodyguard keys
-		this.guardKeys = getBodyguardKeys(new ExampleUser());
+		guardKeys = getBodyguardKeys(new ExampleUser());
 	});
 
 	it('returns true if the user matches', () => {
-		// Check if this.user has an id of 2
-		const result = compareIdToUser('id', 2, this.user, this.guardKeys);
+		// Check if user has an id of 2
+		const result = compareIdToUser('id', 2, user, guardKeys);
 
 		expect(result).toBe(true);
 	});
 
 	it('returns false if the user does not match', () => {
 		// This user should not have an id of 3
-		const result = compareIdToUser('id', 3, this.user, this.guardKeys);
+		const result = compareIdToUser('id', 3, user, guardKeys);
 
 		expect(result).toBe(false);
 	});

test/spec/api/database/base-db.spec.ts

@@ -5,26 +5,30 @@ import { BaseDb } from '../../../../src/database';
  * pointyapi/database
  */
 describe('[BaseDb]', () => {
+	let baseDb;
+	let clog;
+	let cerr;
+
 	beforeAll(() => {
-		this.baseDb = new BaseDb();
+		baseDb = new BaseDb();
 	});
 
 	beforeEach(() => {
-		this.clog = console.log;
-		this.cerr = console.error;
+		clog = console.log;
+		cerr = console.error;
 	});
 
 	afterEach(() => {
-		console.log = this.clog;
-		console.error = this.cerr;
+		console.log = clog;
+		console.error = cerr;
 	});
 
 	it('contains setEntities() & allows chaining', () => {
-		expect(this.baseDb.setEntities([])).toEqual(this.baseDb);
+		expect(baseDb.setEntities([])).toEqual(baseDb);
 	});
 
 	it('contains connect() & returns a promise', () => {
-		expect(this.baseDb.connect({})).toEqual(jasmine.any(Promise));
+		expect(baseDb.connect({})).toEqual(jasmine.any(Promise));
 	});
 
 	it('can log a message', () => {
@@ -34,7 +38,7 @@ describe('[BaseDb]', () => {
 			result = true;
 		};
 
-		this.baseDb.logger();
+		baseDb.logger();
 		expect(result).toBe(true);
 	});
 });

test/spec/api/database/postgres.spec.ts

@@ -8,28 +8,31 @@ const ROOT_PATH = require('app-root-path').toString();
  * pointyapi/database
  */
 describe('[Database: Postgres]', async () => {
+	let db;
+	let clog;
+
 	beforeAll(() => {
-		this.db = new PointyPostgres();
-		this.db.connectionName = 'testconn';
-		this.db.errorHandler = (error) => fail(error);
-		this.db.logger = () => {};
+		db = new PointyPostgres();
+		db.connectionName = 'testconn';
+		db.errorHandler = (error) => fail(error);
+		db.logger = () => {};
 	});
 
 	beforeEach(() => {
-		this.clog = console.log;
+		clog = console.log;
 	});
 
 	afterEach(() => {
-		console.log = this.clog;
+		console.log = clog;
 	});
 
 	it('can set entities', () => {
-		this.db.setEntities([ ExampleUser ]);
+		db.setEntities([ ExampleUser ]);
 	});
 
 	it('can connect', async () => {
 		// Database
-		await this.db.connect(ROOT_PATH).catch((error) => fail(error));
+		await db.connect(ROOT_PATH).catch((error) => fail(error));
 	});
 
 	it('can connect with json options', async () => {

test/spec/api/endpoints/delete-endpoint.spec.ts

@@ -14,13 +14,15 @@ const errorHandler = (error) => fail(JSON.stringify(error));
  * pointyapi/endpoints
  */
 describe('[Endpoints] Delete', () => {
+	let cwarn;
+
 	beforeEach(() => {
-		this.cwarn = console.warn;
+		cwarn = console.warn;
 		console.warn = () => {};
 	});
 
 	afterEach(() => {
-		console.warn = this.cwarn;
+		console.warn = cwarn;
 	});
 
 	it('can delete', async () => {

test/spec/api/endpoints/get-endpoint.spec.ts

@@ -12,30 +12,34 @@ import { getRepository } from 'typeorm';
  * pointyapi/endpoints
  */
 describe('[Endpoints] Get', () => {
+	let cwarn;
+	let user1;
+	let user2;
+
 	beforeEach(() => {
-		this.cwarn = console.warn;
+		cwarn = console.warn;
 		console.warn = () => {};
 	});
 
 	afterEach(() => {
-		console.warn = this.cwarn;
+		console.warn = cwarn;
 	});
 
 	beforeAll(() => {
 		// Create users
-		this.user1 = new ExampleUser();
-		this.user1.fname = 'Get';
-		this.user1.lname = 'Endpoint';
-		this.user1.username = 'getEndpoint1';
-		this.user1.password = 'password123';
-		this.user1.email = 'get1@example.com';
-
-		this.user2 = new ExampleUser();
-		this.user2.fname = 'Get';
-		this.user2.lname = 'Endpoint';
-		this.user2.username = 'getEndpoint2';
-		this.user2.password = 'password123';
-		this.user2.email = 'get2@example.com';
+		user1 = new ExampleUser();
+		user1.fname = 'Get';
+		user1.lname = 'Endpoint';
+		user1.username = 'getEndpoint1';
+		user1.password = 'password123';
+		user1.email = 'get1@example.com';
+
+		user2 = new ExampleUser();
+		user2.fname = 'Get';
+		user2.lname = 'Endpoint';
+		user2.username = 'getEndpoint2';
+		user2.password = 'password123';
+		user2.email = 'get2@example.com';
 	});
 
 	it('returns the payload', async () => {
@@ -49,7 +53,7 @@ describe('[Endpoints] Get', () => {
 		}
 
 		// Set payload
-		request.payload = [ this.user1, this.user2 ];
+		request.payload = [ user1, user2 ];
 
 		// Check for getResponder()
 		response.getResponder = (result) => {
@@ -75,7 +79,7 @@ describe('[Endpoints] Get', () => {
 		}
 
 		// Set payload
-		request.payload = [ this.user1, this.user2 ];
+		request.payload = [ user1, user2 ];
 
 		// Check for getResponder()
 		response.getResponder = (result) => {
@@ -99,7 +103,7 @@ describe('[Endpoints] Get', () => {
 		}
 
 		// Set payload
-		request.payload = this.user1;
+		request.payload = user1;
 
 		// Check for getResponder()
 		response.getResponder = (result) => {

test/spec/api/endpoints/login-endpoint.spec.ts

@@ -12,13 +12,15 @@ import { addResource } from '../../../../src/utils';
  * pointyapi/endpoints
  */
 describe('[Endpoints] Login', async () => {
+	let cwarn;
+
 	beforeEach(() => {
-		this.cwarn = console.warn;
+		cwarn = console.warn;
 		console.warn = () => {};
 	});
 
 	afterEach(() => {
-		console.warn = this.cwarn;
+		console.warn = cwarn;
 	});
 
 	beforeAll(async () => {

test/spec/api/endpoints/logout-endpoint.spec.ts

@@ -12,13 +12,15 @@ import { addResource } from '../../../../src/utils';
  * pointyapi/endpoints
  */
 describe('[Endpoints] Logout', async () => {
+	let cwarn;
+
 	beforeEach(() => {
-		this.cwarn = console.warn;
+		cwarn = console.warn;
 		console.warn = () => {};
 	});
 
 	afterEach(() => {
-		console.warn = this.cwarn;
+		console.warn = cwarn;
 	});
 
 	beforeAll(async () => {

test/spec/api/endpoints/patch-endpoint.spec.ts

@@ -11,13 +11,15 @@ import { getRepository } from 'typeorm';
  * pointyapi/endpoints
  */
 describe('[Endpoints] Patch', () => {
+	let cwarn;
+
 	beforeEach(() => {
-		this.cwarn = console.warn;
+		cwarn = console.warn;
 		console.warn = () => {};
 	});
 
 	afterEach(() => {
-		console.warn = this.cwarn;
+		console.warn = cwarn;
 	});
 
 	it('can patch', async () => {

test/spec/api/endpoints/post-endpoint.spec.ts

@@ -11,13 +11,15 @@ import { getRepository } from 'typeorm';
  * pointyapi/endpoints
  */
 describe('[Endpoints] Post', () => {
+	let cwarn;
+
 	beforeEach(() => {
-		this.cwarn = console.warn;
+		cwarn = console.warn;
 		console.warn = () => {};
 	});
 
 	afterEach(() => {
-		console.warn = this.cwarn;
+		console.warn = cwarn;
 	});
 
 	it('can post (single)', async () => {