restore strategy

Author: h-mayorquin

src/spikeinterface/core/generate.py

@@ -66,7 +66,6 @@ def generate_recording(
         durations=durations,
         dtype="float32",
         seed=seed,
-        strategy="tile_pregenerated",
         # block size is fixed to one second
         noise_block_size=int(sampling_frequency),
     )
@@ -1235,13 +1234,13 @@ class MockRecording(BaseRecording):
     For noise with spatial correlations or per-channel noise levels, use
     ``spikeinterface.generation.NoiseGeneratorRecording``.
 
-    This done by tiling small noise chunk.
+    Noise is generated by pre-allocating a single noise block and tiling it across the requested
+    frame range. This is reproducible across different start/end frame calls with the same seed.
 
     2 strategies to be reproducible across different start/end frame calls:
       * "tile_pregenerated": pregenerate a small noise block and tile it depending the start_frame/end_frame
       * "on_the_fly": generate on the fly small noise chunk and tile then. seed depend also on the noise block.
 
-
     Parameters
     ----------
     num_channels : int
@@ -1255,17 +1254,14 @@ class MockRecording(BaseRecording):
     seed : int | None, default: None
         The seed for np.random.default_rng.
     strategy : "tile_pregenerated" | "on_the_fly", default: "tile_pregenerated"
-        The strategy of generating noise chunk:
-          * "tile_pregenerated": pregenerate a noise chunk of noise_block_size sample and repeat it
-                                 very fast and cusume only one noise block.
-          * "on_the_fly": generate on the fly a new noise block by combining seed + noise block index
-                          no memory preallocation but a bit more computaion (random)
+        The strategy of generating noise chunk.
+        # TODO: Remove on_the_fly strategy after discussion, see #4522.
     noise_block_size : int, default: 30000
-        Size in sample of noise block.
+        Size in samples of the pre-generated noise block.
 
     Notes
     -----
-    If modifying this function, ensure that only one call to malloc is made per call get_traces to
+    If modifying this class, ensure that only one call to malloc is made per call to get_traces to
     maintain the optimized memory profile.
     """
 
@@ -1346,7 +1342,6 @@ def __init__(
         if self.strategy == "tile_pregenerated":
             rng = np.random.default_rng(seed=self.seed)
             self.noise_block = rng.standard_normal(size=(self.noise_block_size, self.num_channels), dtype=self.dtype)
-
         elif self.strategy == "on_the_fly":
             pass
 

src/spikeinterface/preprocessing/silence_periods.py

@@ -4,7 +4,8 @@
 from .basepreprocessor import BasePreprocessor, BasePreprocessorSegment
 
 from spikeinterface.core import get_noise_levels
-from spikeinterface.core.generate import NoiseGeneratorRecording
+from spikeinterface.core.generate import MockRecording
+from .normalize_scale import ScaleRecording
 from spikeinterface.core.job_tools import split_job_kwargs
 from spikeinterface.core.base import base_period_dtype
 
@@ -87,16 +88,16 @@ def __init__(
                     recording, return_in_uV=False, random_slices_kwargs=random_slices_kwargs
                 )
 
-            noise_generator = NoiseGeneratorRecording(
+            mock_noise = MockRecording(
                 num_channels=recording.get_num_channels(),
                 sampling_frequency=recording.sampling_frequency,
                 durations=[recording.select_segments(i).get_duration() for i in range(recording.get_num_segments())],
                 dtype=recording.dtype,
                 seed=seed,
-                noise_levels=noise_levels,
                 strategy="on_the_fly",
                 noise_block_size=int(recording.sampling_frequency),
             )
+            noise_generator = ScaleRecording(mock_noise, gain=noise_levels, dtype=recording.dtype)
         else:
             noise_generator = None