Skip to content

Commit a3f8db3

Browse files
authored
Fix false-positive margin warning in forkserver workers (#4506)
1 parent 295bbbf commit a3f8db3

2 files changed

Lines changed: 8 additions & 2 deletions

File tree

src/spikeinterface/core/__init__.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@
8383
get_global_job_kwargs,
8484
set_global_job_kwargs,
8585
reset_global_job_kwargs,
86+
is_set_global_job_kwargs_set,
8687
)
8788

8889
# tools

src/spikeinterface/preprocessing/filter.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,12 @@
33
import numpy as np
44

55
from spikeinterface.core.core_tools import define_function_handling_dict_from_class
6-
from spikeinterface.core import get_chunk_with_margin, ensure_chunk_size, get_global_job_kwargs
6+
from spikeinterface.core import (
7+
get_chunk_with_margin,
8+
ensure_chunk_size,
9+
get_global_job_kwargs,
10+
is_set_global_job_kwargs_set,
11+
)
712

813
from .basepreprocessor import BasePreprocessor, BasePreprocessorSegment
914

@@ -118,7 +123,7 @@ def __init__(
118123
margin = int(margin_ms * fs / 1000.0)
119124

120125
global_job_kwargs_chunk_size = ensure_chunk_size(recording, **get_global_job_kwargs())
121-
if margin > MARGIN_TO_CHUNK_PERCENT_WARNING * global_job_kwargs_chunk_size:
126+
if is_set_global_job_kwargs_set() and margin > MARGIN_TO_CHUNK_PERCENT_WARNING * global_job_kwargs_chunk_size:
122127
warnings.warn(
123128
f"The margin size ({margin} samples) is more than {int(MARGIN_TO_CHUNK_PERCENT_WARNING * 100)}% "
124129
f"of the global chunk size {global_job_kwargs_chunk_size} samples. This may lead to performance bottlenecks when "

0 commit comments

Comments
 (0)