Fix writing to binary recording in Kilosort (#4540)

chrishalcrow · web-flow · commit 7b13bd7ee8e4 · 2026-04-21T09:32:45.000+02:00
diff --git a/src/spikeinterface/sorters/external/kilosort4.py b/src/spikeinterface/sorters/external/kilosort4.py
@@ -138,7 +138,7 @@ def _setup_recording(cls, recording, sorter_output_folder, params, verbose):
                 # local copy needed
                 binary_file_path = sorter_output_folder / "recording.dat"
                 write_binary_recording(
-                    recording=recording,
+                    recording,
                     file_paths=[binary_file_path],
                     **get_job_kwargs(params, verbose),
                 )
diff --git a/src/spikeinterface/sorters/external/kilosortbase.py b/src/spikeinterface/sorters/external/kilosortbase.py
@@ -151,7 +151,7 @@ def _setup_recording(cls, recording, sorter_output_folder, params, verbose):
             else:
                 padded_recording = recording
             write_binary_recording(
-                recording=padded_recording,
+                padded_recording,
                 file_paths=[binary_file_path],
                 dtype="int16",
                 **get_job_kwargs(params, verbose),

Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,7 @@ def _setup_recording(cls, recording, sorter_output_folder, params, verbose):`
`138`	`138`	`# local copy needed`
`139`	`139`	`binary_file_path = sorter_output_folder / "recording.dat"`
`140`	`140`	`write_binary_recording(`
`141`		`- recording=recording,`
	`141`	`+ recording,`
`142`	`142`	`file_paths=[binary_file_path],`
`143`	`143`	`**get_job_kwargs(params, verbose),`
`144`	`144`	`)`