Skip to content

Commit 839f101

Browse files
committed
Add fix, test privileged option
1 parent a5bc1f5 commit 839f101

3 files changed

Lines changed: 17 additions & 8 deletions

File tree

.github/workflows/test_containers_gpu.yml

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
name: CI-Test in AWS for GPU
22

33
on:
4+
workflow_dispatch:
45
push:
56
branches:
67
- ci-test-gpu
@@ -25,17 +26,26 @@ jobs:
2526
test-gpu-sorters:
2627
needs: deploy-runner
2728
runs-on: [self-hosted, cml-gpu]
28-
timeout-minutes: 4320 # 72h
29+
timeout-minutes: 360 # 6h
2930
container:
3031
image: docker://iterativeai/cml:0-dvc2-base1-gpu
31-
options: --gpus all
32+
options: --privileged --gpus all
3233
steps:
3334
- uses: actions/checkout@v3
3435

35-
- name: Install singularity dependencies
36+
- name: Install dependencies
3637
run: |
3738
sudo apt-get update
38-
sudo apt-get install -y squashfs-tools
39+
sudo apt-get install -y wget squashfs-tools
40+
pip install -U pip
41+
pip install -r requirements_test.txt
42+
43+
sudo apt install apt-transport-https ca-certificates curl software-properties-common
44+
curl -fsSL https://download.docker.com/linux/ubuntu/gpg | sudo apt-key add -
45+
sudo add-apt-repository "deb [arch=amd64] https://download.docker.com/linux/ubuntu `lsb_release -cs` test"
46+
sudo apt update
47+
sudo apt install docker-ce
48+
pip install docker
3949
4050
- uses: eWaterCycle/setup-singularity@v7
4151
with:
@@ -45,5 +55,4 @@ jobs:
4555
env:
4656
REPO_TOKEN: ${{ secrets.PERSONAL_ACCESS_TOKEN }}
4757
run: |
48-
pip install -r requirements_test.txt
49-
pytest -sv tests/test_singularity_containers.py::test_tridesclous
58+
pytest -sv tests/test_containers_gpu.py

requirements_test.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
11
git+https://github.com/SpikeInterface/spikeinterface.git#egg=spikeinterface[full]
2-
docker==5.0.3
32
spython==0.2.1
43
pytest==7.1.2

tests/test_containers_gpu.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ def run_kwargs(work_dir):
3434
num_segments=1
3535
)
3636
test_recording = test_recording.save(name='toy')
37-
return dict(recording=test_recording, verbose=True, singularity_image=True)
37+
return dict(recording=test_recording, verbose=True, docker_image=True)
3838

3939

4040
def test_kilosort2(run_kwargs):
@@ -52,6 +52,7 @@ def test_kilosort3(run_kwargs):
5252
print(sorting)
5353

5454

55+
@pytest.mark.skip(reason="Need to check errors")
5556
def test_pykilosort(run_kwargs):
5657
sorting = ss.run_pykilosort(output_folder="pykilosort", **run_kwargs)
5758
print(sorting)

0 commit comments

Comments
 (0)