better code style for typescript

Author: timea-solid

eslint.config.mjs

@@ -1,5 +1,4 @@
 import tsParser from '@typescript-eslint/parser'
-import tseslintPlugin from '@typescript-eslint/eslint-plugin'
 import importPlugin from 'eslint-plugin-import'
 
 export default [
@@ -12,7 +11,7 @@ export default [
     ],
   },
   {
-    files: ['src/**/*.js', 'src/**/*.ts', 'src/**/*.cjs', 'src/**/*.mjs'],
+    files: ['src/**/*.ts'],
     languageOptions: {
       parser: tsParser,
       parserOptions: {
@@ -21,19 +20,20 @@ export default [
       },
     },
     plugins: {
-      '@typescript-eslint': tseslintPlugin,
       import: importPlugin,
     },
     rules: {
+      // Style rules (not handled by TypeScript)
       semi: ['error', 'never'],
       quotes: ['error', 'single'],
-      'no-unused-vars': 'off', // handled by TS
-      '@typescript-eslint/no-unused-vars': ['warn'],
-      '@typescript-eslint/no-explicit-any': 'warn',
+      
+      // Disable ESLint rules that TypeScript handles better
+      'no-unused-vars': 'off', // TypeScript handles this via noUnusedLocals
+      'no-undef': 'off', // TypeScript handles undefined variables
     },
   },
   {
-    files: ['test/**/*.js', 'test/**/*.ts'],
+    files: ['test/**/*.ts'],
     languageOptions: {
       parser: tsParser,
       parserOptions: {

package-lock.json

@@ -52,7 +52,6 @@
     "@babel/preset-env": "^7.28.3",
     "@babel/preset-typescript": "^7.27.1",
     "@types/jest": "^30.0.0",
-    "@typescript-eslint/eslint-plugin": "^8.46.2",
     "@typescript-eslint/parser": "^8.34.0",
     "babel-jest": "^30.1.2",
     "babel-loader": "^10.0.0",

package.json

@@ -87,7 +87,6 @@ export function createAclLogic(store): AclLogic {
 
         return fetcher.load(docURI).then(result => {
             if (!result.ok) {
-                // eslint-disable-next-line @typescript-eslint/no-explicit-any
                 throw new Error('fetchACLRel: While loading:' + (result as any).error)
             }
 

src/acl/aclLogic.ts

@@ -7,9 +7,7 @@ import * as debug from '../util/debug'
  * see: https://github.com/facebook/jest/issues/936#issuecomment-545080082 for more
  * @return {any} - an appContext object
  */
-// eslint-disable-next-line @typescript-eslint/no-explicit-any
 export const appContext = ():any => {
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     let { SolidAppContext }: any = window
     SolidAppContext ||= {}
     SolidAppContext.viewingNoAuthPage = false
@@ -42,7 +40,6 @@ export const appContext = ():any => {
  * @returns {NamedNode|null}
  */
 export function offlineTestID (): NamedNode | null {
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any 
     const { $SolidTestEnvironment }: any = window
     if (
       typeof $SolidTestEnvironment !== 'undefined' &&

src/authn/authUtil.ts

@@ -96,7 +96,6 @@ export function createChatLogic(store, profileLogic): ChatLogic {
             await store.fetcher.load(
                 new NamedNode(chatContainer.value + 'index.ttl#this')
             )
-        // eslint-disable-next-line @typescript-eslint/no-unused-vars
         } catch (e) {
             exists = false
         }

src/chat/chatLogic.ts

@@ -2,7 +2,6 @@ import { NamedNode } from 'rdflib'
 import { InboxLogic } from '../types'
 import { getArchiveUrl } from '../util/utils'
 
-// eslint-disable-next-line @typescript-eslint/no-unused-vars
 export function createInboxLogic(store, profileLogic, utilityLogic, containerLogic, aclLogic): InboxLogic {
 
     async function createInboxFor(peerWebId: string, nick: string) {

src/inbox/inboxLogic.ts

@@ -17,7 +17,6 @@ import * as debug from '../util/debug'
 ** into a `ConnectedStore` or a `LiveStore`.  A Fetcher object is
 ** available at store.fetcher, and `fetch` function at `store.fetcher._fetch`,
 */
-// eslint-disable-next-line @typescript-eslint/no-explicit-any
 export function createSolidLogic(specialFetch: { fetch: (url: any, requestInit: any) => any }, session: Session): SolidLogic {
 
     debug.log('SolidLogic: Unique instance created.  There should only be one of these.')

src/logic/solidLogic.ts

@@ -17,7 +17,6 @@ export function createProfileLogic(store, authn, utilityLogic): ProfileLogic {
     async function silencedLoadPreferences(user: NamedNode): Promise <NamedNode | undefined> {
         try {
             return await loadPreferences(user)
-        // eslint-disable-next-line @typescript-eslint/no-unused-vars
         } catch (err) {
             return undefined
         }

src/profile/profileLogic.ts

@@ -23,7 +23,6 @@ export function createTypeIndexLogic(store, authn, profileLogic, utilityLogic):
         let publicTypeIndex
         try {
             publicTypeIndex = await utilityLogic.followOrCreateLink(user, ns.solid('publicTypeIndex') as NamedNode, suggestion, profile)
-        // eslint-disable-next-line @typescript-eslint/no-unused-vars
         } catch (err) {
             const message = `User ${user} has no pointer in profile to publicTypeIndex file.`
             debug.warn(message)
@@ -33,7 +32,6 @@ export function createTypeIndexLogic(store, authn, profileLogic, utilityLogic):
         let preferencesFile
         try {
             preferencesFile = await profileLogic.silencedLoadPreferences(user)
-        // eslint-disable-next-line @typescript-eslint/no-unused-vars
         } catch (err) {
             preferencesFile = null
         }
@@ -47,7 +45,6 @@ export function createTypeIndexLogic(store, authn, profileLogic, utilityLogic):
             try {
                 privateTypeIndex = store.any(user, ns.solid('privateTypeIndex'), undefined, profile) ||
                     await utilityLogic.followOrCreateLink(user, ns.solid('privateTypeIndex') as NamedNode, suggestedPrivateTypeIndex, preferencesFile)
-            // eslint-disable-next-line @typescript-eslint/no-unused-vars
                 } catch (err) {
                 const message = `User ${user} has no pointer in preference file to privateTypeIndex file.`
                 debug.warn(message)
@@ -71,7 +68,6 @@ export function createTypeIndexLogic(store, authn, profileLogic, utilityLogic):
         let preferencesFile
         try {
             preferencesFile = await profileLogic.silencedLoadPreferences(user)
-            // eslint-disable-next-line @typescript-eslint/no-unused-vars
         } catch (err) {
             const message = `User ${user} has no pointer in profile to preferences file.`
             debug.warn(message)
@@ -82,7 +78,6 @@ export function createTypeIndexLogic(store, authn, profileLogic, utilityLogic):
             )
             let result = []
             for (const org of communities) {
-                // eslint-disable-next-line @typescript-eslint/no-explicit-any
                 result = result.concat(await loadTypeIndexesFor(org as NamedNode) as any)
             }
             return result
@@ -98,7 +93,6 @@ export function createTypeIndexLogic(store, authn, profileLogic, utilityLogic):
         const scopes = await loadAllTypeIndexes(user)
         let scopedApps = []
         for (const scope of scopes) {
-            // eslint-disable-next-line @typescript-eslint/no-explicit-any
             const scopedApps0 = await getScopedAppsFromIndex(scope, klass) as any
             scopedApps = scopedApps.concat(scopedApps0)
         }