Merge pull request #10 from SingleRust/dev-matrix-mul-optimization

ianfd · web-flow · commit bc5f967c0e56 · 2025-07-25T01:38:22.000+01:00
fixed small orientation issue and malformed matrix
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -4,7 +4,7 @@ description = "A Rust port of LAS2 from SVDLIBC"
 keywords = ["svd"]
 categories = ["algorithms", "data-structures", "mathematics", "science"]
 name = "single-svdlib"
-version = "1.0.5"
+version = "1.0.6"
 edition = "2021"
 license-file = "SVDLIBC-LICENSE.txt"
 
diff --git a/src/randomized/mod.rs b/src/randomized/mod.rs
@@ -96,6 +96,8 @@ where
                 PowerIterationNormalizer::QR => {
                     let qr = z.qr();
                     z = qr.q();
+                    // After QR normalization, z has fewer columns, so we need to resize y
+                    y = DMatrix::<T>::zeros(m_rows, z.ncols());
                 }
                 PowerIterationNormalizer::LU => {
                     normalize_columns(&mut z);

Original file line number	Diff line number	Diff line change
`@@ -96,6 +96,8 @@ where`
`96`	`96`	`PowerIterationNormalizer::QR => {`
`97`	`97`	`let qr = z.qr();`
`98`	`98`	`z = qr.q();`
	`99`	`+ // After QR normalization, z has fewer columns, so we need to resize y`
	`100`	`+ y = DMatrix::<T>::zeros(m_rows, z.ncols());`
`99`	`101`	`}`
`100`	`102`	`PowerIterationNormalizer::LU => {`
`101`	`103`	`normalize_columns(&mut z);`