fixing bug with ArrayConverter affecting other objects, better default

logErr, finishing and testing refactor of ObjectConverter, adding tests
to GeneralExample

Author: SimplyProgrammer

SerialX-core/src/main/java/org/ugp/serialx/LogProvider.java

@@ -40,7 +40,17 @@ public void logErr(Object obj, Throwable ex)
 				throw new RuntimeException(obj.toString());
 			throw new RuntimeException(ex);
 		}
-		System.err.println(obj);
+		
+		try 
+		{
+			StackTraceElement caller = Thread.currentThread().getStackTrace()[2];
+			String callerName = caller.getClassName();
+			System.err.println(callerName.substring(callerName.lastIndexOf('.')+1) + "#" + caller.getMethodName() + ": " + obj);
+		}
+		catch (Exception e)
+		{
+			System.err.println(obj);
+		}
 	}
 
 	/**

SerialX-core/src/main/java/org/ugp/serialx/Utils.java

@@ -426,7 +426,7 @@ else if (objs[i] instanceof Class)
 		}
 
 		for (int i = 0; i < classes.length; i++) 
-			classes[i] = objs[i].getClass();
+			classes[i] = objs[i] == null ? Object.class : objs[i].getClass();
 		return classes;
 	}
 

SerialX-core/src/main/java/org/ugp/serialx/converters/DataParser.java

@@ -260,7 +260,7 @@ public CharSequence toString(Object obj, Object... args)
 				}
 			}
 
-			LogProvider.instance.logErr(DataConverter.class.getSimpleName() + ": Unable to convert \"" + obj == null ? "null" : obj.getClass().getName() + "\" to string because none of registered converters were aplicable for this object!", null);
+			LogProvider.instance.logErr("Unable to convert \"" + obj == null ? "null" : obj.getClass().getName() + "\" to string because none of registered converters were aplicable for this object!", null);
 			return null;
 		}
 
@@ -316,7 +316,7 @@ public Object parse(String str, boolean returnAsStringIfNotFound, Class<?>[] ign
 			if (returnAsStringIfNotFound)
 				return str;
 
-			LogProvider.instance.logErr(DataParser.class.getSimpleName() + ": Unable to parse \"" + str + "\" because none of registred parsers were suitable!", null);
+			LogProvider.instance.logErr("Unable to parse \"" + str + "\" because none of registred parsers were suitable!", null);
 			return null;
 		}
 

SerialX-core/src/main/java/org/ugp/serialx/converters/ProtocolConverter.java

@@ -23,7 +23,6 @@
 
 /**
  * This converter is capable of converting any Object using {@link SerializationProtocol} as well as invoking static functions!
- * This is also responsible for {@link Scope}!
  * Its case sensitive!
  * <br>
  * <br>
@@ -48,14 +47,15 @@
 		    <td>10</td>
 	  	</tr>
 	</table>
-		<br>
+	Note: Be aware that invocation of static members such as functions and fields (:: operator) is disabled by default for the sake of security...<br> 
+	<br>
 	This parser requires additional parser arg at index 0 of type {@link GenericScope} or {@link Serializer} that will be used for further parsing and operating (default new {@link JussSerializer}).<br>
 	This parser requires additional parser arg at index 3 of type {@link ProtocolRegistry} or {@link SerializationProtocol} itself that will be used for parsing protocol expressions (default {@link SerializationProtocol#REGISTRY}).<br>
  *  This parser will insert one additional argument into array of additional parser args at index 4, in case of serialization index 5, that will be of type {@link Class} and it will contains information about class of object that is being unserialized or serialized using protocol!</br>
  *  
  * @author PETO
  * 
- * @since 1.3.0
+ * @since 1.3.0 (separated from ObjectConverter since 1.3.7)
  */
 public class ProtocolConverter implements DataConverter 
 {
@@ -71,6 +71,8 @@ public class ProtocolConverter implements DataConverter
 	 */
 	protected boolean useBase64IfCan = false;
 
+	protected boolean allowStaticMemberInvocation = false;
+	
 	@Override
 	public Object parse(ParserRegistry myHomeRegistry, String str, Object... compilerArgs)
 	{	
@@ -99,11 +101,11 @@ public Object parse(ParserRegistry myHomeRegistry, String str, Object... compile
 	 */
 	protected Object parse(ParserRegistry myHomeRegistry, Class<?> objClass, String str, Object... compilerArgs)
 	{
-		if (objClass == IsSelectorScope.class) 
+		if (objClass == IsSelectorScope.class) //Handle css-like selector scope to variable assignment
 		{
 			StringBuilder sb = new StringBuilder(str);
 			sb.setCharAt(str.indexOf(' '), '=');
-			return myHomeRegistry.parse(sb.toString(), compilerArgs);
+			return myHomeRegistry.parse(sb.toString(), compilerArgs); //Should work only when ObjectConverter and VariableConverter are present...
 		}
 
 		if (compilerArgs.length < 5)
@@ -116,6 +118,12 @@ protected Object parse(ParserRegistry myHomeRegistry, Class<?> objClass, String
 		if (!isOneOf(args[0].charAt(0), '{', '[') && (nameIndex = args[0].indexOf("::")) > -1) //Is static member invocation
 		{
 			String memberName = args[0].substring(nameIndex + 2);
+			if (!isAllowStaticMemberInvocation())
+			{
+				LogProvider.instance.logErr("Invocation of static member \"" + memberName + "\" from class \"" + objClass.getName() + "\" was denied because this feature is disabled by default for security reasons!", null);
+				return null;
+			}
+				
 			if (args.length > 1)
 				return InvokeStaticFunc(objClass, oldObjectClass, memberName, parseAll(myHomeRegistry, args, 1, true, compilerArgs), compilerArgs);
 
@@ -274,6 +282,26 @@ public void setUseBase64IfCan(boolean useBase64IfCan)
 		this.useBase64IfCan = useBase64IfCan;
 	}
 
+	/**
+	 * @return True if invocation of static members (:: operator) is allowed (false by default)!
+	 * 
+	 * @since 1.3.7
+	 */
+	public boolean isAllowStaticMemberInvocation()
+	{
+		return allowStaticMemberInvocation;
+	}
+
+	/**
+	 * @param allowStaticMemberInvocation | Enable/disable the invocation of static members (:: operator) (false by default)!
+	 * 
+	 * @since 1.3.7
+	 */
+	public void setAllowStaticMemberInvocation(boolean allowStaticMemberInvocation) 
+	{
+		this.allowStaticMemberInvocation = allowStaticMemberInvocation;
+	}
+
 	/**
 	 * @param obj | Object to get protocol for!
 	 * @param mode | Protocol mode!

SerialX-core/src/main/java/org/ugp/serialx/protocols/MapProtocol.java

@@ -37,7 +37,7 @@ public Map<Object, Object> unserialize(Class<? extends Map<Object, Object>> obje
 	{
 		boolean isFromScope = args.length == 1 && args[0] instanceof GenericScope;
 		if (args.length % 2 != 0 && !isFromScope)
-			LogProvider.instance.logErr(getClass().getSimpleName() + ": Some variables have no values, this is not good!", null);
+			LogProvider.instance.logErr("Some variables have no values, this is not good!", null);
 
 		if (objectClass.isInterface())
 			objectClass = (Class<? extends Map<Object, Object>>) HashMap.class;

SerialX-core/src/main/java/org/ugp/serialx/protocols/ScopeProtocol.java

@@ -23,7 +23,7 @@ public Object[] serialize(GenericScope<?, ?> object) throws Exception
 	{
 		if (object.getClass() != Scope.class)
 			return new Object[] {object.castTo(Scope.class)};
-		throw new UnsupportedOperationException(getClass().getSimpleName() + ": You are trying to serialize GenericScope or Scope via protocol! This is not good and should not even be possible! Scopes are meant to be serialized via converters!");
+		throw new UnsupportedOperationException("You are trying to serialize GenericScope or Scope via protocol! This is not good and should not even be possible! Scopes are meant to be serialized via converters!");
 	}
 
 	@Override

SerialX-core/src/main/java/org/ugp/serialx/protocols/SerializationProtocol.java

@@ -30,7 +30,7 @@ public abstract class SerializationProtocol<T>
 	 * 
 	 * @since 1.3.0
 	 */
-	public static final ProtocolRegistry REGISTRY = new ProtocolRegistry(new UniversalObjectInstantiationProtocol<>(Object.class), new ListProtocol(), new MapProtocol(), new StringProtocol(), new ScopeProtocol(), new SelfSerializableProtocol(), new EnumProtocol());
+	public static final ProtocolRegistry REGISTRY = new ProtocolRegistry(/*This might be unsafe: new UniversalObjectInstantiationProtocol<>(Object.class),*/ new ListProtocol(), new MapProtocol(), new StringProtocol(), new ScopeProtocol(), new SelfSerializableProtocol(), new EnumProtocol());
 
 	/**
 	 * This mode is for protocols that are used for serialization only!
@@ -191,7 +191,7 @@ public static <O> Object[] serializeObj(ProtocolRegistry registry, O object) thr
 		SerializationProtocol<O> prot = registry.GetProtocolFor(object, MODE_SERIALIZE);
 		if (prot == null)
 		{
-			LogProvider.instance.logErr(SerializationProtocol.class.getSimpleName() + ": Unable to serialize \"" + object + "\" because there is no registered and active protocol for serializing " + object.getClass() + "!", null);
+			LogProvider.instance.logErr("Unable to serialize \"" + object + "\" because there is no registered and active protocol for serializing " + object.getClass() + "!", null);
 			return null;
 		}
 		return prot.serialize(object);
@@ -231,7 +231,7 @@ public static <O> O unserializeObj(ProtocolRegistry registry, Class<? extends O>
 		SerializationProtocol<O> prot = (SerializationProtocol<O>) registry.GetProtocolFor(objectClass, MODE_DESERIALIZE);
 		if (prot == null)
 		{
-			LogProvider.instance.logErr(SerializationProtocol.class.getSimpleName() + ": Unable to unserialize " + Arrays.toString(args) + " because there is no registered and active protocol for unserializing \"" + objectClass + "\"!", null);
+			LogProvider.instance.logErr("Unable to unserialize " + Arrays.toString(args) + " because there is no registered and active protocol for unserializing \"" + objectClass + "\"!", null);
 			return null;
 		}
 		return (O) prot.unserialize(objectClass, args);
@@ -294,7 +294,7 @@ public ProtocolRegistry clone()
 		public void add(int index, SerializationProtocol<?> element) 
 		{
 			if (GetProtocolFor(element.applicableFor()) != null && element.applicableFor() != Object.class)
-				LogProvider.instance.logErr(getClass().getSimpleName() + ": Protocol applicable for \"" + element.applicableFor().getName() + "\" is already registred!", null);
+				LogProvider.instance.logErr("Protocol applicable for \"" + element.applicableFor().getName() + "\" is already registred!", null);
 			addDuplicatively(index, element);
 		}
 

SerialX-core/src/main/java/org/ugp/serialx/protocols/UniversalObjectInstantiationProtocol.java

@@ -33,7 +33,7 @@ public UniversalObjectInstantiationProtocol(Class<T> applicableFor)
 	@Override
 	public Object[] serialize(T object) 
 	{
-		throw new UnsupportedOperationException(getClass().getSimpleName() + ": This protocol is only for reading! It cant serialize " + object);
+		throw new UnsupportedOperationException("This protocol is only for reading! It cant serialize " + object);
 	}
 
 	@SuppressWarnings("unchecked")
@@ -54,7 +54,7 @@ public T unserialize(Class<? extends T> objectClass, Object... args) throws Exce
 				catch (IllegalArgumentException e) 
 				{}
 		}
-		LogProvider.instance.logErr(getClass().getSimpleName() + ": Unable to call create new instance of \"" + objectClass + "\" because inserted arguments " + Arrays.asList(args) + " cannot be applied on any public constructor in required class!", null);
+		LogProvider.instance.logErr("Unable to create new instance of \"" + objectClass + "\" because inserted arguments " + Arrays.asList(args) + " cannot be applied on any public constructor in required class!", null);
 		return null;
 	}
 

SerialX-devtools/src/main/java/org/ugp/serialx/devtools/converters/DebugParserRegistry.java

@@ -94,7 +94,7 @@ public CharSequence toString(Object obj, Object... args) {
 			}
 		}
 
-		LogProvider.instance.logErr(DataConverter.class.getSimpleName() + ": Unable to convert \"" + obj == null ? "null" : obj.getClass().getName() + "\" to string because none of registered converters were aplicable for this object!", null);
+		LogProvider.instance.logErr("Unable to convert \"" + obj == null ? "null" : obj.getClass().getName() + "\" to string because none of registered converters were aplicable for this object!", null);
 		return null;
 	}
 
@@ -149,7 +149,7 @@ public Object parse(String str, boolean returnAsStringIfNotFound, Class<?>[] ign
 		if (returnAsStringIfNotFound)
 			return str;
 
-		LogProvider.instance.logErr(DataParser.class.getSimpleName() + ": Unable to parse \"" + str + "\" because none of registred parsers were suitable!", null);
+		LogProvider.instance.logErr("Unable to parse \"" + str + "\" because none of registred parsers were suitable!", null);
 		return null;
 	}
 

SerialX-juss/src/main/java/org/ugp/serialx/juss/JussSerializer.java

@@ -63,7 +63,7 @@ public class JussSerializer extends Serializer implements ImportsProvider
 	 * 
 	 * @since 1.3.2
 	 */
-	public static final ParserRegistry JUSS_PARSERS = new ParserRegistry(new OperationGroups(), new VariableConverter(), new StringConverter(), new ObjectConverter(), new ArrayConverter(), new NumberConverter(), new BooleanConverter(), new CharacterConverter(), new NullConverter(), new SerializableBase64Converter());
+	public static final ParserRegistry JUSS_PARSERS = new ParserRegistry(new ImportConverter(), new OperationGroups(), new VariableConverter(), new StringConverter(), new ObjectConverter(), new ArrayConverter(), new NumberConverter(), new BooleanConverter(), new CharacterConverter(), new NullConverter(), new SerializableBase64Converter());
 
 	/**
 	 * {@link ParserRegistry} with all parsers required to parse JUSS with additional operators.