Skip to content

Commit 5ddb3a4

Browse files
some micro optimalizations i < len-1 -> i > 0
1 parent 3a1d678 commit 5ddb3a4

4 files changed

Lines changed: 19 additions & 16 deletions

File tree

SerialX-core/src/main/java/org/ugp/serialx/converters/ProtocolConverter.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -205,10 +205,7 @@ public CharSequence toString(ParserRegistry myHomeRegistry, Object arg, Serializ
205205
args = args.clone();
206206
for (int i = 0, sizeEndl = 10000; i < objArgs.length; i++)
207207
{
208-
if (args.length > 2)
209-
args[2] = index + 1;
210-
sb.append(myHomeRegistry.toString(objArgs[i], args));
211-
if (i < objArgs.length-1)
208+
if (i > 0)
212209
if (sb.length() > sizeEndl)
213210
{
214211
sb.append('\n');
@@ -218,6 +215,10 @@ public CharSequence toString(ParserRegistry myHomeRegistry, Object arg, Serializ
218215
}
219216
else
220217
sb.append(' ');
218+
219+
if (args.length > 2)
220+
args[2] = index + 1;
221+
sb.append(myHomeRegistry.toString(objArgs[i], args));
221222
}
222223

223224
args[4] = oldObjectClass;

SerialX-core/src/main/java/org/ugp/serialx/protocols/AutoProtocol.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import java.beans.PropertyDescriptor;
55
import java.util.ArrayList;
66
import java.util.HashMap;
7+
import java.util.LinkedList;
78
import java.util.List;
89

910
import org.ugp.serialx.Scope;

SerialX-juss/src/main/java/org/ugp/serialx/juss/JussSerializer.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -323,15 +323,15 @@ else if (args[1] instanceof Integer)
323323

324324
for (i = 0; i < valuesLen; i++) //Values
325325
{
326+
if (i > 0)
327+
source.append('\n');
328+
326329
Object obj = objs.get(i);
327330
CharSequence serialized = reg.toString(obj, args);
328331

329332
appandVal(source, serialized, obj, tabs, i >= valuesLen-1);
330333
if (generateComments && (!(obj instanceof Scope) || ((Scope) obj).isEmpty()))
331334
GenerateComment(source, reg, obj);
332-
333-
if (i < valuesLen-1)
334-
source.append('\n');
335335
}
336336

337337
if (source instanceof Flushable)

SerialX-juss/src/main/java/org/ugp/serialx/juss/converters/ArrayConverter.java

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -103,23 +103,24 @@ public CharSequence toString(ParserRegistry myHomeRegistry, Object obj, Object..
103103
StringBuilder sb = new StringBuilder();
104104
for (int i = 0, length = elms.length, sizeEndl = 10000; i < length; i++)
105105
{
106-
CharSequence str = myHomeRegistry.toString(elms[i], args);
107-
char ch = str.charAt(0);
108-
if ((ch | ' ') == '{')
109-
sb.append("("+str+")");
110-
else
111-
sb.append(str);
112-
113-
if (i < length-1)
106+
if (i > 0)
114107
if (sb.length() > sizeEndl)
115108
{
116-
sb.append('\n');
109+
sb.append('\n');
117110
for (int j = 0; j < tabs+1; j++)
118111
sb.append('\t');
119112
sizeEndl += 10000;
120113
}
121114
else
122115
sb.append(' ');
116+
117+
CharSequence str = myHomeRegistry.toString(elms[i], args);
118+
char ch = str.charAt(0);
119+
if ((ch | ' ') == '{')
120+
sb.append('(').append(str).append(')');
121+
else
122+
sb.append(str);
123+
123124
}
124125
return index > 0 ? sb.insert(0, '(').append(')') : sb;
125126
}

0 commit comments

Comments
 (0)