Impossible to return multiple discounts from the same function

[mariusa]

There's a huge limitation on functions (discounts) which makes this unusable in real life cases: even though a function can return a list of multiple discounts (say, one for each cart line item), Shopify will apply only one of it. We need all the discounts to be applied.

For example: Volume discounts have different tiers for different quantities. A cart line could have quantity 2 and qualify for 1st tier (10% discount), another cart line could have quantity 6 and qualify for 2nd tier (20% discount). This is impossible to handle now, as even though the function returns 2 different discounts to apply, Shopify applies only one.
Need DiscountApplicationStrategy: ALL, not just one: https://shopify.dev/api/functions/reference/product-discounts/graphql/common-objects/discountapplicationstrategy

There are forum posts about this, but nobody at Shopify didn't even reply:
https://community.shopify.com/c/shopify-functions/shopify-functions-product-discount-api-multiple-discounts/td-p/1693369
https://community.shopify.com/c/shopify-functions/need-discountapplicationstrategy-all/td-p/1865853

[rahultiwari-hulkapps]

+1
That is what we are looking for. We really need DiscountApplicationStrategy: ALL so different percent/fixed discounts can be applied multiple line targets.

[rahultiwari-hulkapps]

Hello Shopify,

I hope you are looking here, is there any ETA for this? This is the main blocker for many developers.

Thank you so much.

[isque03]

Another +1
Ran into the same issue right away while working on implementing function discounts. Thanks for your help!

[mmarcon91]

We have the same problem

[GYMarshy]

+1 here too

[nfusionsolutions]

We need this also. Has Shopify support responded?

[UsmanFirdous]

I have same issue looking for solution

[sirowland]

Also looking for a solution to this.

Our use case:

• We have multiple cart line items that need their own specific discount
• we have custom products, so the product variant is not unique (we would have millions of variants).

If the target was a cart line id instead of a product variant id and iterated through the cart lines, we would be able to run discounts like so:

cart line 1 (product variant 1 - width 1 length 2) -> function -> discount result 1
cart line 2 (product variant 1 - width 2 length 3) -> function -> discount result 2
cart line 3 (product variant 2 - width 1 length 2) -> function -> discount result 3

[cyberabis]

+1...

We might have a single volume discount setup for 2 products, say A and B.
Cart has x quantity of A, and y quantity of B. But the function is unable to apply 2 discounts across the cart line items.

[rahultiwari-hulkapps]

Any update/ETA here?

[mmarcon91]

We’re removing the Script Editor app from the Shopify App Store on April 3, 2023

You decided to remove Shopify script from the store, which remained a possibility to solve this type of discounting.
Now how can we solve for the new Shopify Plus this logic?

[rndgf]

+1

I join this waiting list :)
Just starting to play with functions, and want to implement some "private sales" discount rules (change a cart item price based on a variant metafield), seems to fit perfectly our need EXCEPT THAT it's impossible to have multiple discounts rules for the same function output...

PLEASE, at least make us a statement ?

• Possible : Yes / No ?
• If Yes : an approximative ETA ?

I think it's a basic feature which need to be implement asap.
Currently, in my case, we need to rollback to "script editor" which is not the good path to 2024 end of life.

[ayushishah169]

I have the same issue with multi-tier discounts, looking for solution.

[Wtrapp]

+1

[gancena]

+1 many of our clients need/want this to work

[AndreaMorone]

Stille not working, the output contains an array of different discounts targeting different products at 10% and 20% OFF, but it still discounts with the same amount. I think is still 'unstable' to use it.

[Sanj718]

Hey guys, sorry for a bit out of topic questions, but how you been able to show custom discount message in checkout? I'm passing my message in target, but not seeing it in checkout... "20% OFF VIP CUSTOMER"

  return {
    discounts: [
      {
        message: "20% OFF VIP CUSTOMER",
        targets: variantIds,
        value,
        
      },
    ],
  
    discountApplicationStrategy: DiscountApplicationStrategy.Maximum
  };

[AndreaMorone]

What API version are you using? ProductDiscount or OrderDiscount? The output seems correct to me. Does the discount apply without the message?

[Sanj718]

Yes, I've used 2023-10 and unstable, none of them works... it only shows Discount code as message.

[Sanj718]

I'm trying to implement Product Discount and custom message:

Not sure why.... I was never able to see the custom message. Maybe there are some other pre-requisites I'm missing?

And this is my full output...

{
  "discounts": [
    {
      "message": "20% OFF YOLO",
      "targets": [
        {
          "productVariant": {
            "id": "gid://shopify/ProductVariant/42476793299132",
            "quantity": 2
          }
        }
      ],
      "value": {
        "percentage": {
          "value": 20
        }
      }
    }
  ],
  "discountApplicationStrategy": "ALL"
}

[Sanj718]

Any help here would be appreciated

[mhcdev]

We're actively working on this and planning to release this feature in 2 weeks. I will post an update here so you can test it for your respective use cases.

Will this update allow us to select cart items by line item/key instead of variant id so we can target items properly for discounts? Or is this only going to allow a single function to return multiple discounts?

[mhcdev]

I don't think that would be a satisfactory solution to this issue. Most ppl need to be able to target specific line items for discounts not just variants in the cart. Without that detail this discounting function is incomplete and will not be a proper replacement for scripts.

[javl]

Isn't it? Even though the target selector uses variant IDs, aren't those functionally the same as line items, as the script runs in a single cart at a time?

[nickwesselman]

You can follow the status of line item discount support under this feature request.

[mhcdev]

Not really. There is a chance a variant can be in the cart multiple times w/ different line item properties and need to have different discounts applied to each one. If we are only targeting by variantID we will never be able to apply discounts to the right items in this case. This is why the item key was added to the REST API for cart line items.

[javl]

That makes sense, @mhcdev. Thanks.

[mishac]

You can have the same variant in different line items with different discounts in the context of upsells, bundles, etc.

…

On Fri, 13 Oct 2023 at 09:27, Jasper van Loenen ***@***.***> wrote: Isn't it? Even though the target selector uses variant IDs, aren't those functionally the same as line items, as the script runs in a single cart at a time? — Reply to this email directly, view it on GitHub <#194 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAQY54BOZKWAG5NN5JJXTLX7E6ULANCNFSM6AAAAAAWMOVTK4> . You are receiving this because you are subscribed to this thread.Message ID: <Shopify/function-examples/repo-discussions/194/comments/7273942@ github.com>

[mhcdev]

You can follow the status of line item discount support under this feature request.

I think they are pretty much the same issue. Both items need to be solved for functions to take over script discounts.

[sebastianpisula]

support for line item properties is very important IMHO

[dianacheptene]

All, this issue is specifically tracking the inability to return multiple discounts from the same function. Another thread is tracking the inability to target line items.

[jacknavynicy]

Hi @dianacheptene so the scheduled release will have the fix for this discussion only right? for that another thread you mentioned is there any schedule for that to be released? Thank you!

[dianacheptene]

Hi jack,
I've replied in that thread.

[damir-samatov]

Right now Discount Extension Function is very limited in terms of it's capabilities and flexiblity, it only allows assigning a discount to single cart item (by variantID, which is confusing cuz it does not give control over specific line item I wish to discount).
Although Function allows returning multiple targets with differrent discounts, it only applies the first one or the one with the highest discount amount, which does not make sense.

When can we expect those issues to be resolved?

Thank you!

[dianacheptene]

Although Function allows returning multiple targets with differrent discounts, it only applies the first one or the one with the highest discount amount, which does not make sense.

Hi Damir, as mentioned above we're adding the ability to apply ALL applicable discounts in one function. We're a few weeks away from releasing this enhancement.

by variantID, which is confusing cuz it does not give control over specific line item I wish to discount

We're tracking this issue in a separate thread.

[elvonkh]

@dianacheptene

Thank you for responding on this thread.
Just a clarification regarding the function usage.

Will application of discounts go with a single function? or should we create multiple functions?

Also this might not be related to this discussion, however discounts have limitation for amount of functions to be created per store.
The real issue that I have:

• I have created 5 automatic discounts in my app. I delete my app. I installed the app. I cannot create any discounts
• I have created 3 automatic discounts in my first application. I created 2 automatic discounts in second application. I cannot create 3rd discount in my second application as well as I cannot create 4th automatic discount in my first application

Probably, shopify has limitation for automatic discount PER SHOP. So the shop can bear 5 automatic discounts. Devs might be confused when developing a feature. Can you include this limitation in your documentation, please?

I cannot find any documentation regarding this. cc: https://community.shopify.com/c/shopify-functions/app-automatic-discount-limitation/td-p/1921328

[dianacheptene]

Noted. We'll update the docs to make it more clear.

[AndreaMorone]

Just to give an update on this topic. Seems that DISCOUNT APPLICATION STRATEGY::ALL is working and applying correctly, it's just the message that is wrong. From my tests it's like the message still uses DISCOUNT APPLICATION STRATEGY::FIRST.

[AndreaMorone]

yep, I confirm!

[KapilAnncode]

Can you please tell me how I can pass "DiscountApplicationStrategy.All" in the function response, because in my api.ts file that's inside the "generated" subfolder of the created function. there is no option for all

my api.ts file DiscountApplicationStrategy contains like this
export enum DiscountApplicationStrategy {
/** Only apply the first discount with conditions that are satisfied. /
First = 'FIRST',
/* Only apply the discount that offers the maximum reduction. */
Maximum = 'MAXIMUM'
}

even after updating extension version to api_version = "2024-01"
and when I'm putting hardcoded All= 'All', inside the DiscountApplicationStrategy and when I'm running npm run shopify app function typegen command or run num run dev to remove hardcoded value from api.ts file DiscountApplicationStrategy container.

[AndreaMorone]

Did you try with

npm run --silent shopify app function schema

[rgilbert82]

@KapilAnncode
DiscountApplicationStrategy.All didn't work for me, but "ALL" did. All caps. Like this:

return {
      discounts: discountsArray,
      discountApplicationStrategy: "ALL"
};

[KapilAnncode]

Thanks, @AndreaMorone, Yes it worked for me after updating the function schema.

[killalau]

May I know if DiscountApplicationStrategy::ALL will be also available for order discount function or not?

[dianacheptene]

What use case are you looking to solve?

[dianacheptene]

All, the DiscountApplicationStrategy: ALL is now available in the 2024-01 release candidate. Please open new topics for any issues you may encounter.

[michelarteta]

Very nice, thank you @dianacheptene

[pbtripletree]

Seems like DiscountStrategy.First is used when a variant is targeted by two separate discounts. My expectation was that the discounts would stack, or at the very least DiscountStrategy.Max would be used in the event of overlap. We chalking this up as a feature or bug?

[meandillar]

It would be great to be able to choose the fallback, whether it be stacking, first or max!

[Mooh07]

I have a similar issue and it should be a bug.
Basically I have one automatic discount set up in admin dashboard that applies to all products, I have a function discount running in background with complex logic to apply discounts.

The automatic discount that applies to all products is 20%
Now I have 2 cart items, one that has a discount value of 50% applied through our discount function, the second item has a 5% discount.

Now the logically it should either stack or it should apply the greater applicable discount for second item, which makes it 20% instead of 5%, but the problem I'm getting 5%.

Screenshot for admin dashboard that indicates the bigger value should be taken in discounts, this is a bug

[ghost]

Gražutė

…

On Thu, 7 Dec 2023 at 02:17, pbtripletree ***@***.***> wrote: Seems like DiscountStrategy.First is used when a variant is targeted by two separate discounts. My expectation was that the discounts would stack, or at the very least DiscountStrategy.Max would be used in the event of overlap. We chalking this up as a feature or bug? Screenshot.2023-12-06.at.5.07.18.PM.png (view on web) <https://github.com/Shopify/function-examples/assets/29215222/c5d9233f-3bff-4437-8472-1057b17e0a38> Screenshot.2023-12-06.at.5.07.00.PM.png (view on web) <https://github.com/Shopify/function-examples/assets/29215222/920ef289-26f6-426b-8b7a-8cceca0fa938> — Reply to this email directly, view it on GitHub <#194 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA2JKN3LGAKPXYI5Z6TZEGLYIEDLPAVCNFSM6AAAAAAWMOVTK6VHI2DSMVQWIX3LMV43SRDJONRXK43TNFXW4Q3PNVWWK3TUHM3TOOBSGUYDA> . You are receiving this because you commented.Message ID: ***@***.*** com>

[nickwesselman]

Closing as this feature is complete and released.

[thosakwe]

Will DiscountApplicationStrategy.ALL be added to order discounts as well?

If not, then for anyone reading this, a workaround is to combine multiple discounts, into 1, where each eligible product variant is a target. The limitation here is that every product will receive the same discount.