Skip to content

Commit 42083ba

Browse files
isaacroldanClaude Code
andcommitted
Fix CI: update test expectations, lint formatting, unexport AppAssetsConfig
Co-authored-by: Claude Code <claude-code@anthropic.com>
1 parent 177752f commit 42083ba

4 files changed

Lines changed: 8 additions & 8 deletions

File tree

packages/app/src/cli/models/extensions/specification.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ export interface ExtensionSpecification<TConfiguration extends BaseConfigType =
151151
appAssetsConfig?: (config: TConfiguration) => AppAssetsConfig | undefined
152152
}
153153

154-
export interface AppAssetsConfig {
154+
interface AppAssetsConfig {
155155
/** The config key that points to the assets directory (e.g. 'admin.static_root') */
156156
assetsKey: string
157157
/** The assets directory relative to the extension directory */

packages/app/src/cli/services/build/steps/include-assets-step.test.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1082,10 +1082,7 @@ describe('executeIncludeAssetsStep', () => {
10821082

10831083
// When / Then — overwrites existing manifest.json
10841084
await expect(executeIncludeAssetsStep(step, contextWithConfig)).resolves.not.toThrow()
1085-
expect(fs.writeFile).toHaveBeenCalledWith(
1086-
'/test/output/manifest.json',
1087-
expect.any(String),
1088-
)
1085+
expect(fs.writeFile).toHaveBeenCalledWith('/test/output/manifest.json', expect.any(String))
10891086
})
10901087

10911088
test('writes an empty manifest when anchor resolves to a non-array value', async () => {

packages/app/src/cli/services/dev/extension.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ describe('devUIExtensions()', () => {
6969
devOptions: {...options, websocketURL: 'wss://mock.url/extensions'},
7070
payloadStore: {mock: 'payload-store'},
7171
getExtensions: expect.any(Function),
72+
getAppAssets: expect.any(Function),
7273
})
7374
})
7475

packages/app/src/cli/services/dev/processes/dev-session/dev-session.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -351,9 +351,11 @@ export class DevSession {
351351
.filter((event) => event.type !== 'deleted')
352352
.map((event) => event.extension.uid)
353353

354-
// PENDING: Clean up. This is a temporary workaround because `admin` is not compatible with inheritedUids in Core.
355-
// It needs to be included in the manifest always.
356-
updatedUids.push('admin')
354+
// WORKAROUND. This is a temporary fix because `admin` is not compatible with inheritedUids in Core.
355+
// It needs to be included in the manifest always if present in the app.
356+
if (appEvent.app.allExtensions.some((ext) => ext.type === 'admin')) {
357+
updatedUids.push('admin')
358+
}
357359

358360
const nonUpdatedUids = appEvent.app.allExtensions
359361
.filter((ext) => !updatedUids.includes(ext.uid))

0 commit comments

Comments
 (0)