Address review: fix lease leak in requeue, remove dead :reset heartbeat state

Author: ianks

ruby/lib/ci/queue/redis/base.rb

@@ -373,6 +373,9 @@ def heartbeat
             when :tick
               # command = [:tick, entry_id, lease_id]
               heartbeat_process.tick!(command[1], command[2])
+            when :reset
+              # Test finished, stop ticking until next test starts
+              nil
             when :stop
               break
             end

ruby/lib/ci/queue/redis/worker.rb

@@ -200,7 +200,7 @@ def requeue(entry, offset: Redis.requeue_offset)
           test_id = CI::Queue::QueueEntry.test_id(entry)
           assert_reserved!(test_id)
           entry = reserved_entries.fetch(test_id, entry)
-          lease = @reserved_leases[test_id]
+          lease = @reserved_leases.delete(test_id)
           unreserve_entry(test_id)
           global_max_requeues = config.global_max_requeues(total)
 
@@ -224,6 +224,7 @@ def requeue(entry, offset: Redis.requeue_offset)
             reserved_tests << test_id
             reserved_entries[test_id] = entry
             reserved_entry_ids[entry] = test_id
+            @reserved_leases[test_id] = lease if lease
           end
           requeued
         end