Only include select aliases in select expressions

Author: mythz

src/ServiceStack.OrmLite/Expressions/SqlExpression.cs

@@ -48,6 +48,7 @@ public abstract partial class SqlExpression<T> : ISqlExpression, IHasUntypedSqlE
         protected bool selectDistinct = false;
         protected bool visitedExpressionIsTableColumn = false;
         protected bool skipParameterizationForThisExpression = false;
+        protected bool isSelectExpression = false;
         private bool hasEnsureConditions = false;
         private bool inSqlMethodCall = false;
 
@@ -346,7 +347,11 @@ private SqlExpression<T> InternalSelect(Expression fields, bool distinct=false)
             Reset(sep=string.Empty);
 
             CustomSelect = true;
+            
+            isSelectExpression = true;
             var selectSql = Visit(fields);
+            isSelectExpression = false;
+            
             if (!IsSqlClass(selectSql))
             {
                 selectSql = ConvertToParam(selectSql);
@@ -2100,10 +2105,12 @@ protected virtual object VisitNew(NewExpression nex)
             if (isAnonType)
             {
                 var exprs = VisitExpressionList(nex.Arguments);
-
-                for (var i = 0; i < exprs.Count; ++i)
+                if (isSelectExpression)
                 {
-                    exprs[i] = SetAnonTypePropertyNamesForSelectExpression(exprs[i], nex.Arguments[i], nex.Members[i]);
+                    for (var i = 0; i < exprs.Count; ++i)
+                    {
+                        exprs[i] = SetAnonTypePropertyNamesForSelectExpression(exprs[i], nex.Arguments[i], nex.Members[i]);
+                    }
                 }
 
                 return new SelectList(exprs);

tests/ServiceStack.OrmLite.Tests/OrderByTests.cs

@@ -83,5 +83,26 @@ public void Can_OrderByFields()
             Assert.That(OrmLiteUtils.OrderByFields(d,"-a,b").NormalizeQuotes(), Is.EqualTo("'a' desc, 'b'"));
             Assert.That(OrmLiteUtils.OrderByFields(d,"a,-b").NormalizeQuotes(), Is.EqualTo("'a', 'b' desc"));
         }
+        
+        [Test]
+        public void Can_Multi_OrderBy_AliasValue()
+        {
+            using var db = OpenDbConnection();
+
+            db.DropAndCreateTable<LetterFrequency>();
+            var items = 5.Times(x => new LetterFrequency {
+                Letter = $"{'A' + x}",
+                Value = x + 1
+            });
+            db.InsertAll(items);
+
+            OrmLiteUtils.PrintSql();
+            var q = db.From<LetterFrequency>();
+            q.OrderBy(x => new { x.Value });
+            // q.OrderBy(x => x.Value);
+            var results = db.Select(q);
+            
+            Assert.That(results.Map(x => x.Value), Is.EqualTo(new[]{ 1, 2, 3, 4, 5}));
+        }
     }
 }