Skip to content

Commit 5dff00e

Browse files
committed
Fix Windows slipstream: pre-build picoquic via bash, then cargo without AUTO_BUILD
1 parent dd2c552 commit 5dff00e

1 file changed

Lines changed: 10 additions & 4 deletions

File tree

.github/workflows/release.yml

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,6 @@ jobs:
8484

8585
build-slipstream-windows:
8686
runs-on: windows-latest
87-
continue-on-error: true
8887
steps:
8988
- name: Checkout slipstream-rust
9089
uses: actions/checkout@v4
@@ -99,11 +98,18 @@ jobs:
9998
- name: Install cmake
10099
run: choco install cmake --installargs 'ADD_CMAKE_TO_PATH=System' -y
101100

102-
- name: Build
101+
- name: Pre-build picoquic with bash
103102
shell: bash
104103
working-directory: slipstream-rust
105104
env:
106-
PICOQUIC_AUTO_BUILD: '1'
105+
PICOQUIC_BUILD_DIR: ${{ github.workspace }}/slipstream-rust/.picoquic-build
106+
run: bash scripts/build_picoquic.sh
107+
108+
- name: Build slipstream-client
109+
shell: bash
110+
working-directory: slipstream-rust
111+
env:
112+
PICOQUIC_BUILD_DIR: ${{ github.workspace }}/slipstream-rust/.picoquic-build
107113
run: |
108114
cargo build --release -p slipstream-client --features slipstream-ffi/openssl-vendored
109115
cp target/release/slipstream-client.exe ../slipstream-client-windows-amd64.exe
@@ -115,7 +121,7 @@ jobs:
115121
path: slipstream-client-windows-amd64.exe
116122

117123
release:
118-
needs: [build, build-slipstream-linux]
124+
needs: [build, build-slipstream-linux, build-slipstream-windows]
119125
runs-on: ubuntu-latest
120126
steps:
121127
- uses: actions/download-artifact@v4

0 commit comments

Comments
 (0)