Skip to content

Commit de00f0c

Browse files
committed
Prevent redundant WebSocket close calls
Added a check to ensure socket.close() is only called if the WebSocket is not already closing or closed, preventing unnecessary operations and potential errors.
1 parent 37e653c commit de00f0c

2 files changed

Lines changed: 13 additions & 1 deletion

File tree

.changeset/upset-pens-buy.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
"@evolu/common": patch
3+
---
4+
5+
Prevent redundant WebSocket close calls
6+
7+
Added a check to ensure socket.close() is only called if the WebSocket is not already closing or closed, preventing unnecessary operations and potential errors.

packages/common/src/WebSocket.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,12 @@ export const createWebSocket: CreateWebSocket = (
171171
socket.onmessage = null;
172172
socket.onerror = null;
173173

174-
socket.close();
174+
if (
175+
socket.readyState !== socket.CLOSING &&
176+
socket.readyState !== socket.CLOSED
177+
) {
178+
socket.close();
179+
}
175180
socket = null;
176181
};
177182

0 commit comments

Comments
 (0)