Remove assertNoErrorInCatch and update references

Deleted the assertNoErrorInCatch helper from Assert.ts and removed its usage from WebSocket.ts and documentation. Errors in Promise catch blocks now throw directly, simplifying error handling and reducing unnecessary abstraction.

Author: steida

.github/copilot-instructions.md

@@ -179,7 +179,7 @@ const formatCurrencyCodeError = createTypeErrorFormatter<CurrencyCodeError>(
 - Use for catching developer mistakes eagerly (e.g., invalid configuration)
 
 ```ts
-import { assert, assertNonEmptyArray, assertNoErrorInCatch } from "./Assert.js";
+import { assert, assertNonEmptyArray } from "./Assert.js";
 
 // ✅ Good example
 const length = buffer.getLength();

apps/web/src/app/(landing)/blog/the-copy-paste-typescript-standard-library/page.mdx

@@ -86,7 +86,7 @@ It’s half a joke and half the truth. Programmers should understand the code th
 
 - [Result](https://github.com/evoluhq/evolu/blob/main/packages/common/src/Result.ts) (type‑safe errors)
 - [Brand](https://github.com/evoluhq/evolu/blob/main/packages/common/src/Brand.ts) (prevents mixing incompatible values, e.g., `type UserId = string & Brand<"UserId">`)
-- [Assert](https://github.com/evoluhq/evolu/blob/main/packages/common/src/Assert.ts) (fail‑fast helpers: `assert`, `assertNonEmptyArray`, `assertNoErrorInCatch`)
+- [Assert](https://github.com/evoluhq/evolu/blob/main/packages/common/src/Assert.ts) (fail‑fast helpers: `assert`, `assertNonEmptyArray`)
 - [Array](https://github.com/evoluhq/evolu/blob/main/packages/common/src/Array.ts) (non‑empty arrays and helpers: `NonEmptyArray`, `isNonEmptyArray`, `appendToArray`)
 - [Function](https://github.com/evoluhq/evolu/blob/main/packages/common/src/Function.ts) (small function utils: `exhaustiveCheck`, `identity`, `LazyValue`)
 - [Object](https://github.com/evoluhq/evolu/blob/main/packages/common/src/Object.ts) (object helpers: `isPlainObject`, `mapObject`, `objectToEntries`, `excludeProp`)

packages/common/src/Assert.ts

@@ -96,22 +96,3 @@ export const assertNonEmptyReadonlyArray: <T>(
 ) => {
   assert(arr.length > 0, message);
 };
-
-/**
- * Asserts no error reaches a `.catch` block, throwing a developer error if it
- * does. Used in Promise chains where errors indicate bugs to be fixed.
- *
- * ### Example
- *
- * ```ts
- * Promise.reject("test").catch((e) =>
- *   assertNoErrorInCatch("WebSocket retry", e),
- * );
- * ```
- */
-export function assertNoErrorInCatch(context: string, error: unknown): never {
-  throw new Error(
-    `Error in ${context}: an unexpected error reached a catch block and requires a fix`,
-    { cause: error },
-  );
-}

packages/common/src/WebSocket.ts

@@ -4,7 +4,6 @@
  * @module
  */
 
-import { assertNoErrorInCatch } from "./Assert.js";
 import { constVoid } from "./Function.js";
 import { err, ok, Result } from "./Result.js";
 import { retry, RetryError, RetryOptions } from "./Task.js";
@@ -222,6 +221,7 @@ export const createWebSocket: CreateWebSocket = (
             ? { type: "WebSocketConnectionError", event }
             : { type: "WebSocketConnectError", event };
           onError?.(error);
+
           // Trigger reconnect only on WebSocketConnectError.
           if (error.type === "WebSocketConnectError") {
             resolve(err(error));
@@ -243,7 +243,7 @@ export const createWebSocket: CreateWebSocket = (
       onError?.(result.error as WebSocketError);
     })
     .catch((error: unknown) => {
-      assertNoErrorInCatch("WebSocket retry", error);
+      throw error;
     });
 
   return {