Refactor createIdFromString, add tests

Author: steida

.changeset/dry-cobras-listen.md

@@ -0,0 +1,5 @@
+---
+"@evolu/common": patch
+---
+
+Refactor createIdFromString, add tests

packages/common/src/Type.ts

@@ -1377,19 +1377,19 @@ export const createId = <B extends string = never>(
 export const createIdFromString = <B extends string = never>(
   value: string,
 ): [B] extends [never] ? Id : Id & Brand<B> => {
-  const hash = sha256(utf8ToBytes(value)); // 32 bytes = 256 bits
+  const hash = sha256(utf8ToBytes(value));
 
   let output = "";
   let buffer = 0;
   let bits = 0;
 
-  for (let i = 0; i < hash.length && output.length < 21; i++) {
-    buffer = (buffer << 8) | hash[i]; // push 8 bits
+  for (const byte of hash) {
+    buffer = (buffer << 8) | byte;
     bits += 8;
 
-    while (bits >= 6 && output.length < 21) {
+    while (bits >= 6 && output.length < idTypeValueLength) {
       bits -= 6;
-      const index = (buffer >> bits) & 0b111111; // extract top 6 bits
+      const index = (buffer >> bits) & 0b111111;
       output += base64UrlAlphabet[index];
     }
   }

packages/common/test/Type.test.ts

@@ -949,7 +949,8 @@ test("createId", () => {
 
 test("createIdFromString", () => {
   const id = createIdFromString("abc");
-  expect(Id.from(id)).toEqual(ok("QHMpZvrshcOs47aRxCvN-"));
+  expect(Id.is(id)).toBe(true);
+  expect(id).toEqual("QHMpZvrshcOs47aRxCvN-");
 
   const id1 = createIdFromString("user-api-123");
   const id2 = createIdFromString("user-api-123");
@@ -959,6 +960,27 @@ test("createIdFromString", () => {
   expect(id1).toBe(id2); // Deterministic
   expectTypeOf<typeof id1>().toEqualTypeOf<Id>();
   expectTypeOf<typeof todoId>().toEqualTypeOf<Id & Brand<"Todo">>();
+
+  const emptyId = createIdFromString("");
+  expect(Id.is(emptyId)).toBe(true);
+  expect(emptyId).toHaveLength(21);
+
+  const longString = "a".repeat(1000);
+  const longId = createIdFromString(longString);
+  expect(Id.is(longId)).toBe(true);
+  expect(longId).toHaveLength(21);
+
+  const specialId = createIdFromString("test!@#$%^&*()_+-={}[]|\\:;\"'<>?,./");
+  expect(Id.is(specialId)).toBe(true);
+  expect(specialId).toHaveLength(21);
+
+  const unicodeId = createIdFromString("测试🚀💡");
+  expect(Id.is(unicodeId)).toBe(true);
+  expect(unicodeId).toHaveLength(21);
+
+  const id3 = createIdFromString("test1");
+  const id4 = createIdFromString("test2");
+  expect(id3).not.toBe(id4);
 });
 
 test("PositiveNumber", () => {