Fix: Don't log SQL in the engine adapter if the statement contains values

Author: izeigerman

sqlmesh/core/engine_adapter/base.py

@@ -2126,10 +2126,13 @@ def execute(
                         else e
                     ),
                 )
-                self._log_sql(sql)
+                contains_values = isinstance(e, exp.Insert) and e.find(exp.Values) is not None
+                self._log_sql(sql, contains_values=contains_values)
                 self._execute(sql, **kwargs)
 
-    def _log_sql(self, sql: str) -> None:
+    def _log_sql(self, sql: str, contains_values: bool = False) -> None:
+        if contains_values:
+            sql = "<Redacted because SQL contains values>"
         logger.log(self._execute_log_level, "Executing SQL: %s", sql)
 
     def _execute(self, sql: str, **kwargs: t.Any) -> None:

tests/core/engine_adapter/test_base.py

@@ -3071,3 +3071,22 @@ def test_insert_overwrite_by_partition_query_insert_overwrite_strategy(
     assert sql_calls == [
         'INSERT OVERWRITE TABLE "test_schema"."test_table" ("a", "ds", "b") SELECT "a", "ds", "b" FROM "tbl"'
     ]
+
+
+def test_log_sql(make_mocked_engine_adapter: t.Callable, mocker: MockerFixture):
+    adapter = make_mocked_engine_adapter(EngineAdapter)
+
+    mock_logger = mocker.patch("sqlmesh.core.engine_adapter.base.logger")
+
+    df = pd.DataFrame({"id": [1, 2, 3], "value": ["test1", "test2", "test3"]})
+
+    adapter.execute(parse_one("SELECT 1"))
+    adapter.execute(parse_one("INSERT INTO test SELECT * FROM source"))
+    adapter.execute(parse_one("INSERT INTO test (id, value) VALUES (1, 'test')"))
+    adapter.insert_append("test", df)
+
+    assert mock_logger.log.call_count == 4
+    assert mock_logger.log.call_args_list[0][0][2] == "SELECT 1"
+    assert mock_logger.log.call_args_list[1][0][2] == 'INSERT INTO "test" SELECT * FROM "source"'
+    assert mock_logger.log.call_args_list[2][0][2] == "<Redacted because SQL contains values>"
+    assert mock_logger.log.call_args_list[3][0][2] == "<Redacted because SQL contains values>"