fix: ignore grants for model kinds that don't support it

Author: newtonapple

sqlmesh/core/model/kind.py

@@ -150,6 +150,11 @@ def full_history_restatement_only(self) -> bool:
     def supports_python_models(self) -> bool:
         return True
 
+    @property
+    def supports_grants(self) -> bool:
+        """Whether this model kind supports grants configuration."""
+        return self.is_materialized or self.is_view
+
 
 class ModelKindName(str, ModelKindMixin, Enum):
     """The kind of model, determining how this data is computed and stored in the warehouse."""

sqlmesh/core/model/meta.py

@@ -446,11 +446,8 @@ def _root_validator(self) -> Self:
             )
 
         # Validate grants configuration for model kind support
-        if self.grants is not None:
-            if kind.is_symbolic:
-                raise ValueError(f"grants cannot be set for {kind.name} models")
-            elif not (kind.is_materialized or kind.is_view):
-                raise ValueError(f"grants field is not supported for {kind.name} models")
+        if self.grants is not None and not kind.supports_grants:
+            raise ValueError(f"grants cannot be set for {kind.name} models")
 
         return self
 

sqlmesh/dbt/model.py

@@ -651,11 +651,12 @@ def to_sqlmesh(
             if physical_properties:
                 model_kwargs["physical_properties"] = physical_properties
 
+        kind = self.model_kind(context)
+
         # A falsy grants config (None or {}) is considered as unmanaged per dbt semantics
-        if self.grants:
+        if self.grants and kind.supports_grants:
             model_kwargs["grants"] = self.grants
 
-        kind = self.model_kind(context)
         allow_partials = model_kwargs.pop("allow_partials", None)
         if allow_partials is None:
             # Set allow_partials to True for dbt models to preserve the original semantics.

tests/core/test_model.py

@@ -53,6 +53,8 @@
     TimeColumn,
     ExternalKind,
     ViewKind,
+    EmbeddedKind,
+    SCDType2ByTimeKind,
     create_external_model,
     create_seed_model,
     create_sql_model,
@@ -11907,6 +11909,17 @@ def test_grants_invalid_model_kind_errors(kind: str):
         )
 
 
+def test_model_kind_supports_grants():
+    assert FullKind().supports_grants is True
+    assert ViewKind().supports_grants is True
+    assert IncrementalByTimeRangeKind(time_column="ds").supports_grants is True
+    assert IncrementalByUniqueKeyKind(unique_key=["id"]).supports_grants is True
+    assert SCDType2ByTimeKind(unique_key=["id"]).supports_grants is True
+
+    assert EmbeddedKind().supports_grants is False
+    assert ExternalKind().supports_grants is False
+
+
 def test_grants_validation_no_grants():
     model = create_sql_model("db.table", parse_one("SELECT 1 AS id"), kind="FULL")
     assert model.grants is None

tests/dbt/test_model.py

@@ -995,3 +995,34 @@ def test_model_grants_engine_specific_bigquery() -> None:
     assert grants_config is not None
     assert grants_config["bigquery.dataviewer"] == ["user@domain.com"]
     assert grants_config["select"] == ["analyst@company.com"]
+
+
+def test_ephemeral_model_with_global_grants(create_empty_project):
+    dbt_project_dir, dbt_model_dir = create_empty_project()
+
+    yaml = YAML()
+    dbt_project_config = {
+        "name": "test_project",
+        "version": "1.0.0",
+        "config-version": 2,
+        "profile": "test",
+        "model-paths": ["models"],
+        "models": {"test_project": {"grants": {"select": ["reporter", "analyst"]}}},
+    }
+    dbt_project_file = dbt_project_dir / "dbt_project.yml"
+    with open(dbt_project_file, "w", encoding="utf-8") as f:
+        yaml.dump(dbt_project_config, f)
+
+    ephemeral_model_sql = """
+        {{ config(materialized='ephemeral') }}
+        SELECT 1 as id
+    """
+    ephemeral_model_file = dbt_model_dir / "ephemeral_model.sql"
+    with open(ephemeral_model_file, "w", encoding="utf-8") as f:
+        f.write(ephemeral_model_sql)
+
+    context = Context(paths=dbt_project_dir)
+    model = context.get_model('"local"."main"."ephemeral_model"')
+
+    assert model.kind.is_embedded
+    assert model.grants is None  # grants config is skipped for ephemeral / embedded models