Revert rename of connection event (#1091)

Author: EzraBrooks

package.json

@@ -2,7 +2,7 @@
   "name": "roslib",
   "homepage": "https://robotwebtools.github.io",
   "description": "The standard ROS Javascript Library",
-  "version": "2.0.0-alpha5",
+  "version": "2.0.0-alpha6",
   "license": "BSD-2-Clause",
   "files": [
     "dist"

src/core/Ros.ts

@@ -42,15 +42,15 @@ export interface TypeDefDict {
  * Manages connection to the rosbridge server and all interactions with ROS.
  *
  * Emits the following events:
- *  * 'open'  - Connected to the rosbridge server.
+ *  * 'connection'  - Connected to the rosbridge server.
  *  * 'close' - Disconnected to the rosbridge server.
  *  * 'error' - There was an error with ROS.
  *  * <topicName> - A message came from rosbridge with the given topic name.
  *  * <serviceID> - A service response came from rosbridge with the given ID.
  */
 export default class Ros extends EventEmitter<
   {
-    open: [TransportEvent];
+    connection: [TransportEvent];
     close: [TransportEvent];
     error: [TransportEvent];
     // Any dynamically-named event should correspond to a rosbridge protocol message
@@ -101,7 +101,7 @@ export default class Ros extends EventEmitter<
 
     transport.on("open", (event: TransportEvent) => {
       this.#isConnected = true;
-      this.emit("open", event);
+      this.emit("connection", event);
     });
 
     transport.on("close", (event: TransportEvent) => {
@@ -191,7 +191,7 @@ export default class Ros extends EventEmitter<
     if (this.isConnected()) {
       this.transport?.send(message);
     } else {
-      this.once("open", () => {
+      this.once("connection", () => {
         this.transport?.send(message);
       });
     }

test/ros.test.ts

@@ -247,7 +247,10 @@ describe("Ros", function () {
       const rosOnceSpy = vi.spyOn(ros, "once");
       ros.callOnConnection({ op: "set_level", level: "info" });
 
-      expect(rosOnceSpy).toHaveBeenCalledWith("open", expect.any(Function));
+      expect(rosOnceSpy).toHaveBeenCalledWith(
+        "connection",
+        expect.any(Function),
+      );
       expect(mockTransport.send).not.toHaveBeenCalled();
 
       // Once connected, the message is sent

test/setup/ros-backend.ts

@@ -27,7 +27,7 @@ async function waitForRosConnection(ros: Ros, timeout = 5000) {
       reject(new Error("Timeout waiting for ROS connection"));
     }, timeout);
 
-    ros.on("open", () => {
+    ros.on("connection", () => {
       clearTimeout(timeoutId);
       resolve();
     });