#1947 fixed out of bounds access

Robosturm · Robosturm · commit bad92fd58175 · 2026-02-28T09:32:29.000+01:00
diff --git a/objects/editorselection.cpp b/objects/editorselection.cpp
@@ -460,9 +460,10 @@ void EditorSelection::changeSelectedPlayer(qint32 player)
     {
         m_currentPlayer = nullptr;
     }
-    else if (player >= m_Players.size())
+    else if (player + 1 >= m_Players.size())
     {
         m_currentPlayerIdx = 0;
+        player = 0;
         m_currentPlayer = m_Players.at(0)->getOwner();
     }
     else

Original file line number	Diff line number	Diff line change
`@@ -460,9 +460,10 @@ void EditorSelection::changeSelectedPlayer(qint32 player)`
`460`	`460`	`{`
`461`	`461`	`m_currentPlayer = nullptr;`
`462`	`462`	`}`
`463`		`- else if (player >= m_Players.size())`
	`463`	`+ else if (player + 1 >= m_Players.size())`
`464`	`464`	`{`
`465`	`465`	`m_currentPlayerIdx = 0;`
	`466`	`+ player = 0;`
`466`	`467`	`m_currentPlayer = m_Players.at(0)->getOwner();`
`467`	`468`	`}`
`468`	`469`	`else`