Fixes bug in on-the-fly message handling of unicode strings (#120)

chfritz · chris-smith · commit 63c6e0e42dc4 · 2018-11-13T09:03:52.000-05:00
* Fixes bug in on-the-fly message handling of unicode strings Fixes #119.
diff --git a/src/utils/messageGeneration/fields.js b/src/utils/messageGeneration/fields.js
@@ -283,7 +283,7 @@ fields.getPrimitiveSize = function(fieldType, fieldValue) {
   }
   else if (fieldType === 'string') {
     if (fieldValue !== undefined) {
-      fieldSize = fieldValue.length + 4;
+      fieldSize = Buffer.byteLength(fieldValue, 'utf8') + 4;
     }
   }
   else if (fieldType === 'time') {

Original file line number	Diff line number	Diff line change
`@@ -283,7 +283,7 @@ fields.getPrimitiveSize = function(fieldType, fieldValue) {`
`283`	`283`	`}`
`284`	`284`	`else if (fieldType === 'string') {`
`285`	`285`	`if (fieldValue !== undefined) {`
`286`		`- fieldSize = fieldValue.length + 4;`
	`286`	`+ fieldSize = Buffer.byteLength(fieldValue, 'utf8') + 4;`
`287`	`287`	`}`
`288`	`288`	`}`
`289`	`289`	`else if (fieldType === 'time') {`