Skip to content

Commit 94b4cd7

Browse files
Apply ruff/pygrep-hooks rule PGH003 (#708)
Use specific rule codes when ignoring type issues
1 parent 4fcf186 commit 94b4cd7

4 files changed

Lines changed: 5 additions & 9 deletions

File tree

.github/workflows/create_workflows.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
import argparse
2828
from pathlib import Path
2929

30-
import yaml # type: ignore
30+
import yaml
3131
from jinja2 import Environment, FileSystemLoader, select_autoescape
3232

3333
apt_based = [

neurodocker/reproenv/renderers.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -660,8 +660,7 @@ def copy(
660660

661661
@_log_instruction
662662
def env(self, **kwds: str) -> SingularityRenderer:
663-
# TODO: why does this raise a type error?
664-
self._environment.extend(kwds.items()) # type: ignore
663+
self._environment.extend(kwds.items())
665664
return self
666665

667666
@_log_instruction
@@ -695,10 +694,7 @@ def install(self, pkgs: list[str], opts=None) -> SingularityRenderer:
695694

696695
@_log_instruction
697696
def label(self, **kwds: str) -> SingularityRenderer:
698-
# TODO: why are we getting this error?
699-
# Argument 1 to "update" of "dict" has incompatible type
700-
# "Dict[str, Mapping[str, str]]"; expected "Mapping[str, str]"
701-
self._labels.update(kwds) # type: ignore
697+
self._labels.update(kwds)
702698
return self
703699

704700
@_log_instruction

neurodocker/reproenv/state.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
try:
1717
from yaml import CSafeLoader as SafeLoader
1818
except ImportError: # pragma: no cover
19-
from yaml import SafeLoader # type: ignore # pragma: no cover
19+
from yaml import SafeLoader # type: ignore[assignment] # pragma: no cover
2020

2121
from neurodocker.reproenv.exceptions import (
2222
RendererError,

neurodocker/reproenv/template.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ def versions(self) -> set[str]:
220220
def dependencies(self, pkg_manager: str) -> list[str]:
221221
deps_dict = self._template.get("dependencies", {})
222222
# TODO: not sure why the following line raises a type error in mypy.
223-
return deps_dict.get(pkg_manager, []) # type: ignore
223+
return deps_dict.get(pkg_manager, []) # type: ignore[return-value]
224224

225225
def install(self, pkgs: list[str], opts: str = None) -> str:
226226
raise NotImplementedError(

0 commit comments

Comments
 (0)