Make number of retries configurable

Author: ryangribble

Rally.RestApi/RallyRestApi.cs

@@ -132,6 +132,7 @@ internal class StringValue : Attribute
 		#region Properties and Fields
 		private ApiAuthManager authManger;
 		private HttpService httpService;
+		private int maxRetries;
 		private readonly DynamicJsonSerializer serializer = new DynamicJsonSerializer();
 		/// <summary>
 		/// The HTTP headers to be included on all REST requests
@@ -176,6 +177,7 @@ public string WebServiceUrl
 		/// <param name="authManger">The authorization manager to use when authentication requires it. If no driver is 
 		/// provided a console authentication manager will be used which does not allow SSO authentication.</param>
 		/// <param name="webServiceVersion">The WSAPI version to use (defaults to DEFAULT_WSAPI_VERSION)</param>
+		/// <param name="maxRetries">Requests will be attempted a number of times (defaults to 3)</param>
 		/// <example>
 		/// For a console application, no authentication manager is needed as shown in this example.
 		/// <code language="C#">
@@ -196,7 +198,7 @@ public string WebServiceUrl
 		/// wpfAuthMgr = new RestApiAuthMgrWpf(applicationToken, encryptionKey, encryptionUtilities);
 		/// </code>
 		/// </example>
-		public RallyRestApi(ApiAuthManager authManger = null, string webServiceVersion = DEFAULT_WSAPI_VERSION)
+		public RallyRestApi(ApiAuthManager authManger = null, string webServiceVersion = DEFAULT_WSAPI_VERSION, int maxRetries = 3)
 		{
 			// NOTE: The example for using the RestApiAuthMgrWpf is also shown there. Make sure you 
 			// update both if you change it.
@@ -211,6 +213,8 @@ public RallyRestApi(ApiAuthManager authManger = null, string webServiceVersion =
 				WsapiVersion = DEFAULT_WSAPI_VERSION;
 
 			AuthenticationState = AuthenticationResult.NotAuthorized;
+
+			this.maxRetries = maxRetries;
 		}
 		#endregion
 
@@ -1339,7 +1343,7 @@ private DynamicJsonObject DoGetAsPost(Request request, bool retry = true, int re
 				Dictionary<string, string> processedHeaders = GetProcessedHeaders();
 				DynamicJsonObject response = serializer.Deserialize(httpService.GetAsPost(GetSecuredUri(uri), data, processedHeaders));
 
-				if (retry && response[response.Fields.First()].Errors.Count > 0 && retryCounter < 3)
+				if (retry && response[response.Fields.First()].Errors.Count > 0 && retryCounter < this.maxRetries)
 				{
 					ConnectionInfo.SecurityToken = GetSecurityToken();
 					httpService = new HttpService(authManger, ConnectionInfo);
@@ -1351,7 +1355,7 @@ private DynamicJsonObject DoGetAsPost(Request request, bool retry = true, int re
 			}
 			catch (Exception)
 			{
-				if (retryCounter < 3)
+				if (retryCounter < this.maxRetries)
 				{
 					Thread.Sleep(retrySleepTime * retryCounter);
 					return DoGetAsPost(request, true, ++retryCounter);
@@ -1378,7 +1382,7 @@ private DynamicJsonObject DoGet(Uri uri, bool retry = true, int retryCounter = 1
 				Dictionary<string, string> processedHeaders = GetProcessedHeaders();
 				DynamicJsonObject response = serializer.Deserialize(httpService.Get(uri, processedHeaders));
 
-				if (retry && response[response.Fields.First()].Errors.Count > 0 && retryCounter < 3)
+				if (retry && response[response.Fields.First()].Errors.Count > 0 && retryCounter < this.maxRetries)
 				{
 					ConnectionInfo.SecurityToken = GetSecurityToken();
 					httpService = new HttpService(authManger, ConnectionInfo);
@@ -1390,7 +1394,7 @@ private DynamicJsonObject DoGet(Uri uri, bool retry = true, int retryCounter = 1
 			}
 			catch (Exception)
 			{
-				if (retryCounter < 3)
+				if (retryCounter < this.maxRetries)
 				{
 					Thread.Sleep(retrySleepTime * retryCounter);
 					return DoGet(uri, true, ++retryCounter);
@@ -1417,7 +1421,7 @@ private DynamicJsonObject DoPost(Uri uri, DynamicJsonObject data, bool retry = t
 				Dictionary<string, string> processedHeaders = GetProcessedHeaders();
 				var response = serializer.Deserialize(httpService.Post(GetSecuredUri(uri), serializer.Serialize(data), processedHeaders));
 
-				if (retry && response[response.Fields.First()].Errors.Count > 0 && retryCounter < 3)
+				if (retry && response[response.Fields.First()].Errors.Count > 0 && retryCounter < this.maxRetries)
 				{
 					ConnectionInfo.SecurityToken = GetSecurityToken();
 					httpService = new HttpService(authManger, ConnectionInfo);
@@ -1429,7 +1433,7 @@ private DynamicJsonObject DoPost(Uri uri, DynamicJsonObject data, bool retry = t
 			}
 			catch (Exception)
 			{
-				if (retryCounter < 3)
+				if (retryCounter < this.maxRetries)
 				{
 					Thread.Sleep(retrySleepTime * retryCounter);
 					return DoPost(uri, data, true, ++retryCounter);
@@ -1479,7 +1483,7 @@ private string GetSecurityToken()
 		{
 			try
 			{
-				DynamicJsonObject securityTokenResponse = DoGet(new Uri(GetFullyQualifiedRef(SECURITY_ENDPOINT)));
+				DynamicJsonObject securityTokenResponse = DoGet(new Uri(GetFullyQualifiedRef(SECURITY_ENDPOINT)), this.maxRetries > 1);
 				return securityTokenResponse["OperationResult"]["SecurityToken"];
 			}
 			catch