Skip to content

Commit 0df39f1

Browse files
fix: remove outdated scaffold tests (engines, tsdown)
engines check hardcoded 20.19.0 but we use >=24.0.0. tsdown.config.ts check is wrong — vite-plus handles bundling. ADD-02 kept as it tests real --projectDir functionality.
1 parent e1bfaa5 commit 0df39f1

2 files changed

Lines changed: 0 additions & 13 deletions

File tree

tests/integration/golden/add.spec.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,6 @@ test.group("ADD-02 -- qwik add with --projectDir", (group) => {
5353
test("adds integration to --projectDir subdirectory", ({ assert }) => {
5454
const result = runCli(["add", "--projectDir=./sub", "--skipConfirmation=true"], tmpDir);
5555
assert.strictEqual(result.status, 0);
56-
// Will FAIL until Phase 5 implements add command with --projectDir support (stub does not write adapter files).
57-
// Positive assertion: adapter file must be written to the sub/ subdirectory.
58-
// Will FAIL against stub — stub does not write any files.
5956
const adapterFile = join(tmpDir, "sub", "adapters", "cloudflare-pages", "vite.config.ts");
6057
assert.isTrue(
6158
existsSync(adapterFile),

tests/unit/scaffold.spec.ts

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,6 @@ import { test } from "@japa/runner";
55
const ROOT = join(import.meta.dirname, "..", "..");
66

77
test.group("Scaffold", () => {
8-
test("package.json has engines >=20.19.0", ({ assert }) => {
9-
const pkg = JSON.parse(readFileSync(join(ROOT, "package.json"), "utf-8"));
10-
assert.property(pkg, "engines");
11-
assert.include(pkg.engines.node, "20.19.0");
12-
});
13-
148
test("package.json files includes stubs", ({ assert }) => {
159
const pkg = JSON.parse(readFileSync(join(ROOT, "package.json"), "utf-8"));
1610
assert.include(pkg.files, "stubs");
@@ -27,8 +21,4 @@ test.group("Scaffold", () => {
2721
assert.property(pkg.exports["."], "import");
2822
assert.property(pkg.exports["."], "require");
2923
});
30-
31-
test("tsdown.config.ts exists", ({ assert }) => {
32-
assert.isTrue(existsSync(join(ROOT, "tsdown.config.ts")));
33-
});
3424
});

0 commit comments

Comments
 (0)