fix: Properly set separating lines in summary (#6)

Author: MariusMerkleQC

diffly/summary.py

@@ -563,11 +563,12 @@ def _section_columns(self) -> RenderableType:
                 "Column", max_width=COLUMN_SECTION_COLUMN_WIDTH, overflow=OVERFLOW
             )
             matches.add_column("Match Rate", justify="right")
-            if any(
+            has_top_changes_column = any(
                 self.top_k_changes_by_column[col_name] > 0
                 for col_name in self._comparison._other_common_columns
                 if self._comparison.fraction_same()[col_name] < 1
-            ):
+            )
+            if has_top_changes_column:
                 matches.add_column("Top Changes", justify="right")
             if self.show_perfect_column_matches:
                 max_col_len = max(
@@ -635,7 +636,7 @@ def _section_columns(self) -> RenderableType:
 
                     matches.add_row(*columns)
                     if (
-                        top_k_column_changes > 0
+                        has_top_changes_column
                         or max_col_len > COLUMN_SECTION_COLUMN_WIDTH
                     ):
                         matches.add_section()

docs/guides/features/summary.ipynb

@@ -22,7 +22,7 @@
     },
     {
       "cell_type": "code",
-      "execution_count": null,
+      "execution_count": 1,
       "metadata": {},
       "outputs": [],
       "source": [
@@ -41,7 +41,7 @@
     },
     {
       "cell_type": "code",
-      "execution_count": 19,
+      "execution_count": 2,
       "metadata": {},
       "outputs": [
         {
@@ -77,7 +77,7 @@
               "└────────────┴────────────┴──────────┴────────────┴───┴────────────┴──────────┴───────┴────────────┘"
             ]
           },
-          "execution_count": 19,
+          "execution_count": 2,
           "metadata": {},
           "output_type": "execute_result"
         }
@@ -95,7 +95,7 @@
     },
     {
       "cell_type": "code",
-      "execution_count": 20,
+      "execution_count": 3,
       "metadata": {},
       "outputs": [],
       "source": [
@@ -119,7 +119,7 @@
     },
     {
       "cell_type": "code",
-      "execution_count": 21,
+      "execution_count": 4,
       "metadata": {},
       "outputs": [
         {
@@ -184,7 +184,7 @@
     },
     {
       "cell_type": "code",
-      "execution_count": 22,
+      "execution_count": 5,
       "metadata": {},
       "outputs": [
         {
@@ -247,7 +247,7 @@
     },
     {
       "cell_type": "code",
-      "execution_count": 23,
+      "execution_count": 6,
       "metadata": {},
       "outputs": [
         {
@@ -324,7 +324,7 @@
     },
     {
       "cell_type": "code",
-      "execution_count": 24,
+      "execution_count": 7,
       "metadata": {},
       "outputs": [
         {
@@ -362,6 +362,7 @@
             "   │                 │         │                                 \u001b[33m0.5\u001b[0m -> \u001b[33m1.0\u001b[0m (1x) │\n",
             "   ├─────────────────┼─────────┼─────────────────────────────────────────────────┤\n",
             "   │ \u001b[36mloyalty_card_id\u001b[0m │  90.00% │                                                 │\n",
+            "   ├─────────────────┼─────────┼─────────────────────────────────────────────────┤\n",
             "   │ \u001b[36mproduct        \u001b[0m │ 100.00% │                                                 │\n",
             "   ├─────────────────┼─────────┼─────────────────────────────────────────────────┤\n",
             "   │ \u001b[36mquantity       \u001b[0m │ 100.00% │                                                 │\n",
@@ -400,7 +401,7 @@
     },
     {
       "cell_type": "code",
-      "execution_count": 25,
+      "execution_count": 8,
       "metadata": {},
       "outputs": [
         {
@@ -481,7 +482,7 @@
     },
     {
       "cell_type": "code",
-      "execution_count": 26,
+      "execution_count": 9,
       "metadata": {},
       "outputs": [
         {
@@ -540,7 +541,7 @@
     },
     {
       "cell_type": "code",
-      "execution_count": 27,
+      "execution_count": 10,
       "metadata": {},
       "outputs": [
         {
@@ -590,7 +591,7 @@
   ],
   "metadata": {
     "kernelspec": {
-      "display_name": "default",
+      "display_name": "Python 3",
       "language": "python",
       "name": "python3"
     },
@@ -604,7 +605,7 @@
       "name": "python",
       "nbconvert_exporter": "python",
       "pygments_lexer": "ipython3",
-      "version": "3.14.2"
+      "version": "3.14.3"
     }
   },
   "nbformat": 4,

tests/summary/fixtures/equal_non_empty_different_columns/gen/pretty_False_perfect_True_top_True_slim_False_sample_rows_False_sample_pk_False.txt

@@ -20,6 +20,5 @@
  ▔▔▔▔▔▔▔
    ┌───────────┬─────────┬──┐
    │ speed_kph │ 100.00% │  │
-   ├───────────┼─────────┼──┤
    │ weight_kg │ 100.00% │  │
    └───────────┴─────────┴──┘

tests/summary/fixtures/equal_non_empty_different_columns/gen/pretty_False_perfect_True_top_True_slim_False_sample_rows_True_sample_pk_True.txt

@@ -20,6 +20,5 @@
  ▔▔▔▔▔▔▔
    ┌───────────┬─────────┬──┐
    │ speed_kph │ 100.00% │  │
-   ├───────────┼─────────┼──┤
    │ weight_kg │ 100.00% │  │
    └───────────┴─────────┴──┘

tests/summary/fixtures/equal_non_empty_different_columns/gen/pretty_True_perfect_True_top_True_slim_False_sample_rows_False_sample_pk_False.txt

@@ -22,8 +22,6 @@
  ▔▔▔▔▔▔▔
    ┌─────────────────┬─────────┬──┐
    │ life_expectancy │ 100.00% │  │
-   ├─────────────────┼─────────┼──┤
    │ speed_kph       │ 100.00% │  │
-   ├─────────────────┼─────────┼──┤
    │ weight_kg       │ 100.00% │  │
    └─────────────────┴─────────┴──┘

tests/summary/fixtures/equal_non_empty_different_columns/gen/pretty_True_perfect_True_top_True_slim_False_sample_rows_True_sample_pk_True.txt

@@ -22,9 +22,7 @@
  ▔▔▔▔▔▔▔
    ┌─────────────────┬─────────┬──┐
    │ life_expectancy │ 100.00% │  │
-   ├─────────────────┼─────────┼──┤
    │ speed_kph       │ 100.00% │  │
-   ├─────────────────┼─────────┼──┤
    │ weight_kg       │ 100.00% │  │
    └─────────────────┴─────────┴──┘