From 810059ad3cc9d3b3e35ce3af689d9d7b78216b2a Mon Sep 17 00:00:00 2001 From: Nicco Kunzmann Date: Thu, 15 Oct 2026 21:02:52 +0100 Subject: [PATCH 1/4] Change welcome messages --- .github/workflows/agent-scan.yml | 74 +++++++++++++++++++++++++++++--- 1 file changed, 68 insertions(+), 6 deletions(-) diff --git a/.github/workflows/agent-scan.yml b/.github/workflows/agent-scan.yml index de26d55eb..6714e5166 100644 --- a/.github/workflows/agent-scan.yml +++ b/.github/workflows/agent-scan.yml @@ -16,11 +16,11 @@ on: - created jobs: - agentscan: + agentscan-pr: runs-on: ubuntu-latest + if: github.event_name == 'pull_request_target' permissions: pull-requests: write - issues: write contents: read steps: # - name: Cache AgentScan analysis @@ -32,15 +32,77 @@ jobs: - name: AgentScan uses: MatteoGabriele/agentscan-action@8112fb79b33fafb8506159df20129a34209ac410 # v2.5.0 with: -# allowed-users: "angatha,ennamarie19,niccokunzmann,peskypotato,SashankBhamidi,stevepiercy" honeypot: true - message-honeypot: "Thanks for the {type}, @{username}! A maintainer will review it shortly." - message-honeypot-first-time: "Welcome, @{username}! Thanks for your first {type} here!" + message-honeypot: | + Thanks for opening the pull request, @{username}! A maintainer will review it within the next 3 days. + + Please, make sure you use our [Pull Request Template](https://github.com/collective/icalendar/blob/main/.github/pull_request_template.md) and check as many boxes as you can. + If there is another Pull Request open for the same issue, review it and help make it better with your ideas. + + Our [contributing guide](https://icalendar.readthedocs.io/en/stable/contribute/index.html) should answer most of your questions. + While you are waiting - we appreciate your review on other open Pull Requests. + That helps us maintainers speed up merges. + + Thank you for your contributions! 🙏 + message-honeypot-first-time: | + Welcome, @{username}! Thanks for your first Pull Request here! 🥳 + A maintainer will give you a review within the next 3 days. + + Please, make sure you use our [Pull Request Template](https://github.com/collective/icalendar/blob/main/.github/pull_request_template.md) and check as many boxes as you can. + If there is another Pull Request open for the same issue, review it and help make it better with your ideas. + + Because this is your first contribution, we will take special care to help you get started. + Please, refrain from opening another Pull Request until this one is done. + + Also familiarize yourself with our [contributing guide](https://icalendar.readthedocs.io/en/stable/contribute/index.html). + And while you are waiting, you can have a look around - there are other open Pull Requests from contributors like you. + You are invited to review their work and in that spirit receive a review yourself. + + Thank you very much! 🙏 + label-automation: "agentscan:automated-account" + label-community-flagged: "agentscan:community-flagged" + label-mixed: "agentscan:needs-review" + mode: full + scan-issues: true + scan-pull-requests: true + trusted-author-associations: "owner,collaborator" # for collective, we allow those registered on the project only to not receive a scan message + + agentscan-issue: + runs-on: ubuntu-latest + if: github.event_name == 'issues' + permissions: + issues: write + contents: read + steps: + - name: AgentScan + uses: MatteoGabriele/agentscan-action@8112fb79b33fafb8506159df20129a34209ac410 # v2.5.0 + with: + honeypot: true + message-honeypot: | + Thanks for opening this issue, @{username}! + + Please have a look of you find any other related issues and leave them a comment. + Our [contributing guide](https://icalendar.readthedocs.io/en/stable/contribute/index.html) + should answer most of your questions and is always worth a read. + + --- + + We do not assign issues, if you would like to work on this issue, please go ahead and open a Pull Request. + message-honeypot-first-time: | + Welcome, @{username}! Thanks for opening your first issue here! + + Please have a look of you find any other related issues and leave them a comment about this one. + Also, check our [contributing guide](https://icalendar.readthedocs.io/en/stable/contribute/index.html). + If you have any questions, please ask! + + --- + + We do not assign issues, if you would like to work on this issue, please go ahead and open a Pull Request. label-automation: "agentscan:automated-account" label-community-flagged: "agentscan:community-flagged" label-mixed: "agentscan:needs-review" mode: full scan-issues: true scan-pull-requests: true -# trusted-author-associations: "owner" + trusted-author-associations: "owner,collaborator" # for collective, we allow those registered on the project only to not receive a scan message From 514d48024b761003a3c151a5217d59330409fdfe Mon Sep 17 00:00:00 2001 From: Nicco Kunzmann Date: Thu, 15 Oct 2026 21:12:19 +0100 Subject: [PATCH 2/4] Improve greetings --- .github/workflows/agent-scan.yml | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/.github/workflows/agent-scan.yml b/.github/workflows/agent-scan.yml index 6714e5166..cb76575e8 100644 --- a/.github/workflows/agent-scan.yml +++ b/.github/workflows/agent-scan.yml @@ -34,13 +34,17 @@ jobs: with: honeypot: true message-honeypot: | - Thanks for opening the pull request, @{username}! A maintainer will review it within the next 3 days. + Thanks for opening the pull request, @{username}! + + A maintainer will review it within the next 3 days. Please, make sure you use our [Pull Request Template](https://github.com/collective/icalendar/blob/main/.github/pull_request_template.md) and check as many boxes as you can. If there is another Pull Request open for the same issue, review it and help make it better with your ideas. Our [contributing guide](https://icalendar.readthedocs.io/en/stable/contribute/index.html) should answer most of your questions. - While you are waiting - we appreciate your review on other open Pull Requests. + If you still have any questions, please leave a comment! + + While you are waiting: we appreciate your review on other open Pull Requests. That helps us maintainers speed up merges. Thank you for your contributions! 🙏 @@ -58,6 +62,7 @@ jobs: And while you are waiting, you can have a look around - there are other open Pull Requests from contributors like you. You are invited to review their work and in that spirit receive a review yourself. + If you have any questions, please feel free to reach out and leave a comment. Thank you very much! 🙏 label-automation: "agentscan:automated-account" label-community-flagged: "agentscan:community-flagged" @@ -81,22 +86,24 @@ jobs: message-honeypot: | Thanks for opening this issue, @{username}! - Please have a look of you find any other related issues and leave them a comment. + Please have a look of you find any other related issues and leave them a comment about this one. Our [contributing guide](https://icalendar.readthedocs.io/en/stable/contribute/index.html) - should answer most of your questions and is always worth a read. + should tell you what to expect. It is always worth a read. --- + A general note: We do not assign issues, if you would like to work on this issue, please go ahead and open a Pull Request. message-honeypot-first-time: | Welcome, @{username}! Thanks for opening your first issue here! Please have a look of you find any other related issues and leave them a comment about this one. Also, check our [contributing guide](https://icalendar.readthedocs.io/en/stable/contribute/index.html). - If you have any questions, please ask! + If you have any questions, feel free to ask! --- + A general note: We do not assign issues, if you would like to work on this issue, please go ahead and open a Pull Request. label-automation: "agentscan:automated-account" label-community-flagged: "agentscan:community-flagged" From 9885724e403e23b9058d4fe65a5e4d51bba41a2e Mon Sep 17 00:00:00 2001 From: Nicco Kunzmann Date: Thu, 15 Oct 2026 21:17:57 +0100 Subject: [PATCH 3/4] log changes --- news/1818.internal | 1 + 1 file changed, 1 insertion(+) create mode 100644 news/1818.internal diff --git a/news/1818.internal b/news/1818.internal new file mode 100644 index 000000000..e05ae1225 --- /dev/null +++ b/news/1818.internal @@ -0,0 +1 @@ +Update greeting messages for issues and pull requests. @niccokunzmann \ No newline at end of file From 9fddfd73abf2851482fcf98263dff6842f610310 Mon Sep 17 00:00:00 2001 From: Nicco Kunzmann Date: Thu, 15 Oct 2026 21:19:05 +0100 Subject: [PATCH 4/4] fix yaml syntax --- .github/workflows/agent-scan.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/agent-scan.yml b/.github/workflows/agent-scan.yml index cb76575e8..ae6c88123 100644 --- a/.github/workflows/agent-scan.yml +++ b/.github/workflows/agent-scan.yml @@ -111,5 +111,5 @@ jobs: mode: full scan-issues: true scan-pull-requests: true - trusted-author-associations: "owner,collaborator" # for collective, we allow those registered on the project only to not receive a scan message + trusted-author-associations: "owner,collaborator" # for collective, we allow those registered on the project only to not receive a scan message