Skip to content

Commit fc2bb00

Browse files
committed
fix for issue not logging constructors. allow println(int) to go through normally to aid in debugging.
1 parent ca69151 commit fc2bb00

3 files changed

Lines changed: 19 additions & 3 deletions

File tree

Code/ChroniclerJ/src/main/java/edu/columbia/cs/psl/chroniclerj/visitor/NonDeterministicLoggingMethodVisitor.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -169,9 +169,8 @@ public void visitMethodInsn(int opcode, String owner, String name, String desc,
169169
&& nonDeterministicMethods.contains(owner + "." + name + ":" + desc)
170170
&& !(owner.equals(Instrumenter.instrumentedClasses.get(classDesc).superName) && this.name
171171
.equals("<init>"))) {
172+
172173
super.visitMethodInsn(opcode, owner, name, desc, itfc);
173-
if (analyzer.stack != null && analyzer.stack.size() > 0
174-
&& analyzer.stack.get(analyzer.stack.size() - 1).equals(owner))
175174
logValueAtTopOfStackToArray(
176175
MethodCall.getLogClassName(Type.getType("L" + owner + ";")), "aLog",
177176
"[Ljava/lang/Object;", Type.getType("L" + owner + ";"), true, owner

Code/ChroniclerJ/src/main/resources/nondeterministic-methods.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39844,7 +39844,6 @@ com/sun/java/swing/plaf/windows/WindowsTableHeaderUI.rolloverColumnUpdated:(II)V
3984439844
com/sun/java/util/jar/pack/ConstantPool.verbose:()I
3984539845
com/sun/tools/jdwpgen/Context.commandWritingSubcontext:()Lcom/sun/tools/jdwpgen/Context;
3984639846
com/sun/org/apache/xerces/internal/impl/dtd/XMLDTDProcessor.normalizeDefaultAttrValue:(Lcom/sun/org/apache/xerces/internal/xni/XMLString;)Z
39847-
java/io/PrintStream.println:(I)V
3984839847
java/net/URI.getAuthority:()Ljava/lang/String;
3984939848
sun/util/calendar/Gregorian.getCalendarDate:(JLjava/util/TimeZone;)Lsun/util/calendar/CalendarDate;
3985039849
sun/rmi/server/MarshalInputStream.resolveProxyClass:([Ljava/lang/String;)Ljava/lang/Class;
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
package edu.columbia.cs.psl.test.chroniclerj;
2+
3+
import java.util.List;
4+
import java.util.Scanner;
5+
6+
public class ScannerTestCase {
7+
static List<Integer> list;
8+
9+
public static void main(String[] args) {
10+
11+
Scanner in = new Scanner(System.in);
12+
int num = in.nextInt();
13+
14+
System.out.println(num);
15+
list.add(0);
16+
17+
}
18+
}

0 commit comments

Comments
 (0)