fix params, drop-last, get and trim

Author: shmuelko

src/practitest_firecracker/practitest.clj

@@ -263,7 +263,7 @@
                                      (map
                                        (fn [test-name]
                                          {test-name
-                                          [(into {} (difference (set (get new-map test-name)) (set (get existing-instance test-name))))]})
+                                          (into [] (difference (set (get new-map test-name)) (set (get existing-instance test-name))))})
                                        (keys new-map)))
 
         make-instances (flatten (api/make-instances missing-instances new-testname-to-params test-id-testname))

src/practitest_firecracker/query_dsl.cljc

@@ -52,7 +52,7 @@
                            (return-error "Syntax error: 'drop' must have two arguments" query))
     'drop-last           (if (<= 1 (count args) 2)
                            (if (or (string? (last args)) (coll? (last args)))
-                             (apply drop-last args)
+                             (drop-last (parse-int (first args)) (last args))
                              (return-error "Syntax error: 'drop-last' second argument has to be ISeqable (String, Array etc.)" query))
                            (return-error "Syntax error: 'drop-last' must have one or two arguments" query))
     'take-last           (case (count args)
@@ -78,12 +78,12 @@
                                (string/split (second args) complied)))
                            (return-error "Syntax error: 'split' must have two arguments" query))
     'get               (if (= 2 (count args))
-                         (first (take 1 (drop (- (parse-int (first args)) 1) (last args))))
+                         (string/join (get (last args) (dec (parse-int (first args)))))
                          (return-error "Syntax error: 'get' must have two arguments" query))
     'trim               (if (= 1 (count args))
                           (if (string? (first args))
                             (string/trim (first args))
-                            (return-error "Syntax error: 'trim' should be applied on a string" query))
+                            "")
                           (return-error "Syntax error: 'trim' must have only one argument" query))
     (return-error #?(:clj (format "Syntax error: unsupported function '%s'" op)
                      :cljs (str "Syntax error: unsupported function: " op)) query)))