Skip to content

Commit 43b1619

Browse files
committed
fix test params from command got overridden
1 parent fce53cb commit 43b1619

1 file changed

Lines changed: 22 additions & 20 deletions

File tree

  • src/practitest_firecracker/parser

src/practitest_firecracker/parser/core.clj

Lines changed: 22 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -347,26 +347,28 @@
347347
(not specflow-scenario))
348348
(log/warn "Unable to detect BDD scenario for test" (:classname test) (:name test) " - will create FC test"))
349349

350-
(assoc test
351-
:bdd-test? (some? bdd-scenario)
352-
:gherkin-scenario bdd-scenario
353-
;; Extract scenario outline params to special arg (accessible via ?outline-params-row in firecracker config)
354-
:outline-params-row (:row (:outline-params bdd-scenario))
355-
:outline-params-map (:map (:outline-params bdd-scenario))
356-
:errors (count (filter #(= (:failure-type %) :error) (:test-cases test)))
357-
:failures (count (filter #(= (:failure-type %) :failure) (:test-cases test)))
358-
:flakes (count (filter #(= (:failure-type %) :flake) (:test-cases test)))
359-
:skipped (count (filter #(= (:failure-type %) :skipped) (:test-cases test)))
360-
:tests (count (:test-cases test))
361-
;; :name name
362-
;; :name-test-suite name
363-
:suite-name (:suite-name test)
364-
:pt-first-case-name (:name (first (:test-cases test)))
365-
:pt-test-name name
366-
:pt-name-combine (str name " - " (:name (first (:test-cases test))))
367-
:time-elapsed (round (reduce + (map :time (:test-cases test))) :precision 3)
368-
:full-class-name (:classname test)
369-
:package-name package)))
350+
(merge
351+
;; Computed defaults (lowest priority)
352+
{:errors (count (filter #(= (:failure-type %) :error) (:test-cases test)))
353+
:failures (count (filter #(= (:failure-type %) :failure) (:test-cases test)))
354+
:flakes (count (filter #(= (:failure-type %) :flake) (:test-cases test)))
355+
:skipped (count (filter #(= (:failure-type %) :skipped) (:test-cases test)))
356+
:tests (count (:test-cases test))}
357+
;; Original XML attributes (higher priority - user settings override defaults)
358+
test
359+
;; Required computed fields (highest priority - must be set)
360+
{:bdd-test? (some? bdd-scenario)
361+
:gherkin-scenario bdd-scenario
362+
;; Extract scenario outline params to special arg (accessible via ?outline-params-row in firecracker config)
363+
:outline-params-row (:row (:outline-params bdd-scenario))
364+
:outline-params-map (:map (:outline-params bdd-scenario))
365+
:suite-name (:suite-name test)
366+
:pt-first-case-name (:name (first (:test-cases test)))
367+
:pt-test-name name
368+
:pt-name-combine (str name " - " (:name (first (:test-cases test))))
369+
:time-elapsed (round (reduce + (map :time (:test-cases test))) :precision 3)
370+
:full-class-name (:classname test)
371+
:package-name package})))
370372

371373
(defn get-test-aggregations [test val {:keys [scenarios-map]
372374
:as options}]

0 commit comments

Comments
 (0)