Skip to content

Lag/Crash while having WorldEdit (including FAWE) and PowerRanks installed #96

Description

@ProJakob

I've been here with a friend of mine before due to the same issue. PowerRanks permission lookup function seems to still be kinda slow. This can cause huge lag spikes when spamming tab completions because WorldEdit abuses this function by checking any tab completion for permissions many times. This behaviour of WorldEdit in combination with the slow permission lookup of PowerRanks allows easily timing out the server which causes it to crash with malicious modifications.

Maybe add a small caching feature that caches the lookup for 50-150 milliseconds? That would probably already speed it up enough. Another implementation of that cache could also include indefinitely caching results until some state changes like adding/removing ranks or permissions.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions