Fix ScriptAnalyzer Failures from updated rules

Author: Jaykul

Source/Private/CopyReadMe.ps1

@@ -21,21 +21,22 @@ function CopyReadMe {
         # If set, overwrite the existing readme
         [Switch]$Force
     )
+    process {
+        # Copy the readme file as an about_ help file
+        Write-Verbose "Test for ReadMe: $Pwd\$($ReadMe)"
+        if ($ReadMe -and (Test-Path $ReadMe -PathType Leaf)) {
+            # Make sure there's a language path
+            $LanguagePath = Join-Path $OutputDirectory $Culture
+            if (!(Test-Path $LanguagePath -PathType Container)) {
+                $null = New-Item $LanguagePath -Type Directory -Force
+            }
+            Write-Verbose "Copy ReadMe to: $LanguagePath"
 
-    # Copy the readme file as an about_ help file
-    Write-Verbose "Test for ReadMe: $Pwd\$($ReadMe)"
-    if($ReadMe -and (Test-Path $ReadMe -PathType Leaf)) {
-        # Make sure there's a language path
-        $LanguagePath = Join-Path $OutputDirectory $Culture
-        if(!(Test-Path $LanguagePath -PathType Container)) {
-            $null = New-Item $LanguagePath -Type Directory -Force
-        }
-        Write-Verbose "Copy ReadMe to: $LanguagePath"
-
-        $about_module = Join-Path $LanguagePath "about_$($ModuleName).help.txt"
-        if(!(Test-Path $about_module)) {
-            Write-Verbose "Turn readme into about_module"
-            Copy-Item -LiteralPath $ReadMe -Destination $about_module
+            $about_module = Join-Path $LanguagePath "about_$($ModuleName).help.txt"
+            if (!(Test-Path $about_module)) {
+                Write-Verbose "Turn readme into about_module"
+                Copy-Item -LiteralPath $ReadMe -Destination $about_module -Force:$Force
+            }
         }
     }
 }

Source/Private/GetBuildInfo.ps1

@@ -2,7 +2,8 @@ function GetBuildInfo {
     [CmdletBinding()]
     param(
         # The path to the Build Manifest Build.psd1
-        [Parameter()][AllowNull()]
+        [Parameter()]
+        [AllowNull()]
         [string]$BuildManifest,
 
         # Pass MyInvocation from the Build-Command so we can read parameter values

Source/Private/SetModuleContent.ps1

@@ -10,6 +10,8 @@ function SetModuleContent {
 
             The goal here is to pretend this is a pipeline, for the sake of memory and file IO
     #>
+    [Diagnostics.CodeAnalysis.SuppressMessageAttribute("PSReviewUnusedParameter", "OutputPath", Justification = "The rule is buggy")]
+    [Diagnostics.CodeAnalysis.SuppressMessageAttribute("PSReviewUnusedParameter", "Encoding", Justification = "The rule is buggy ")]
     [CmdletBinding()]
     param(
         # Where to write the joined output
@@ -37,7 +39,7 @@ function SetModuleContent {
 
         # Create a proxy command style scriptblock for Set-Content to keep the file handle open
         $SetContentCmd = $ExecutionContext.InvokeCommand.GetCommand('Microsoft.PowerShell.Management\Set-Content', [System.Management.Automation.CommandTypes]::Cmdlet)
-        $SetContent = {& $SetContentCmd -Path $OutputPath -Encoding $Encoding }.GetSteppablePipeline($myInvocation.CommandOrigin)
+        $SetContent = {& $SetContentCmd -Path $OutputPath -Encoding $Encoding}.GetSteppablePipeline($myInvocation.CommandOrigin)
         $SetContent.Begin($true)
     }
     process  {

Source/Public/Build-Module.ps1

@@ -37,6 +37,7 @@ function Build-Module {
     #>
     [Diagnostics.CodeAnalysis.SuppressMessageAttribute("PSUseApprovedVerbs", "", Justification="Build is approved now")]
     [Diagnostics.CodeAnalysis.SuppressMessageAttribute("PSUseCmdletCorrectly", "")]
+    [Diagnostics.CodeAnalysis.SuppressMessageAttribute("PSReviewUnusedParameter", "", Justification="Parameter handling is in InitializeBuild")]
     [CmdletBinding(DefaultParameterSetName="SemanticVersion")]
     [Alias("build")]
     param(

Source/Public/Convert-CodeCoverage.ps1

@@ -17,10 +17,7 @@ function Convert-CodeCoverage {
         # The output of `Invoke-Pester -Pasthru`
         # Note: Pester doesn't apply a custom type name
         [Parameter(ValueFromPipeline)]
-        [PSObject]$InputObject,
-
-        # Output paths as short paths, relative to the SourceRoot
-        [switch]$Relative
+        [PSObject]$InputObject
     )
     process {
         Push-Location $SourceRoot

Source/Public/Convert-LineNumber.ps1

@@ -25,10 +25,7 @@ function Convert-LineNumber {
         [psobject]$InputObject,
 
         [Parameter(ParameterSetName="FromInvocationInfo")]
-        [switch]$Passthru,
-
-        # Output paths as short paths, relative to the SourceRoot
-        [switch]$Relative
+        [switch]$Passthru
     )
     begin {
         $filemap = @{}
@@ -42,14 +39,12 @@ function Convert-LineNumber {
         if(!(Test-Path $SourceFile)) {
             throw "'$SourceFile' does not exist"
         }
-        $PSScriptRoot = Split-Path $SourceFile
-
-        Push-Location $PSScriptRoot
+        Push-Location (Split-Path $SourceFile)
         try {
             if (!$filemap.ContainsKey($SourceFile)) {
                 # Note: the new pattern is #Region but the old one was # BEGIN
-                $matches = Select-String '^(?:#Region|# BEGIN) (?<SourceFile>.*) (?<LineNumber>\d+)?$' -Path $SourceFile
-                $filemap[$SourceFile] = @($matches.ForEach{
+                $regions = Select-String '^(?:#Region|# BEGIN) (?<SourceFile>.*) (?<LineNumber>\d+)?$' -Path $SourceFile
+                $filemap[$SourceFile] = @($regions.ForEach{
                         [PSCustomObject]@{
                             PSTypeName = "BuildSourceMapping"
                             SourceFile = $_.Matches[0].Groups["SourceFile"].Value.Trim("'")